DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@amd.com>
To: Chaoyong He <chaoyong.he@corigine.com>, dev@dpdk.org
Cc: oss-drivers@corigine.com, Long Wu <long.wu@corigine.com>,
	Peng Zhang <peng.zhang@corigine.com>
Subject: Re: [PATCH v2 1/4] ethdev: add function to check representor port
Date: Fri, 23 Feb 2024 09:29:10 +0000	[thread overview]
Message-ID: <17958b3f-0fa4-408d-af01-1f934a0bfc55@amd.com> (raw)
In-Reply-To: <20240223024217.3052031-2-chaoyong.he@corigine.com>

On 2/23/2024 2:42 AM, Chaoyong He wrote:
> From: Long Wu <long.wu@corigine.com>
> 
> Add a function to check if a device is representor port, also
> modified the related codes for PMDs.
> 

Thanks Long for the patch.

> Signed-off-by: Long Wu <long.wu@corigine.com>
> Reviewed-by: Chaoyong He <chaoyong.he@corigine.com>
> Reviewed-by: Peng Zhang <peng.zhang@corigine.com>
> ---
>  doc/guides/rel_notes/release_24_03.rst     |  3 +++
>  drivers/net/bnxt/bnxt.h                    |  3 ---
>  drivers/net/bnxt/bnxt_ethdev.c             |  4 ++--
>  drivers/net/bnxt/tf_ulp/bnxt_tf_pmd_shim.c | 12 ++++++------
>  drivers/net/bnxt/tf_ulp/bnxt_ulp.c         |  4 ++--
>  drivers/net/bnxt/tf_ulp/ulp_def_rules.c    |  4 ++--
>  drivers/net/cpfl/cpfl_representor.c        |  2 +-
>  drivers/net/enic/enic.h                    |  5 -----
>  drivers/net/enic/enic_ethdev.c             |  2 +-
>  drivers/net/enic/enic_fm_flow.c            | 20 ++++++++++----------
>  drivers/net/enic/enic_main.c               |  4 ++--
>  drivers/net/i40e/i40e_ethdev.c             |  2 +-
>  drivers/net/ice/ice_dcf_ethdev.c           |  2 +-
>  drivers/net/ixgbe/ixgbe_ethdev.c           |  2 +-
>  drivers/net/nfp/flower/nfp_flower_flow.c   |  2 +-
>  drivers/net/nfp/nfp_mtr.c                  |  2 +-
>  drivers/net/nfp/nfp_net_common.c           |  4 ++--
>  drivers/net/nfp/nfp_net_flow.c             |  2 +-
>  lib/ethdev/ethdev_driver.h                 | 17 +++++++++++++++++
>  19 files changed, 54 insertions(+), 42 deletions(-)
> 

There are two more instance in 'rte_class_eth.c'

> diff --git a/doc/guides/rel_notes/release_24_03.rst b/doc/guides/rel_notes/release_24_03.rst
> index 879bb4944c..8178417b98 100644
> --- a/doc/guides/rel_notes/release_24_03.rst
> +++ b/doc/guides/rel_notes/release_24_03.rst
> @@ -185,6 +185,9 @@ API Changes
>  * ethdev: Renamed structure ``rte_flow_action_modify_data`` to be
>    ``rte_flow_field_data`` for more generic usage.
>  
> +* ethdev: Add new function ``rte_eth_dev_is_repr()`` to check if a device is
> +  representor port.
> +
>  

This is not user facing API, no need to update the release notes.

<...>

> +/**
> + * @internal
> + * Check if the ethdev is a representor port.
> + *
> + * @param dev
> + *  Pointer to struct rte_eth_dev.
> + *
> + * @return
> + *  false the ethdev is not a representor port.
> + *  true  the ethdev is a representor port.
> + */
> +static inline bool
> +rte_eth_dev_is_repr(const struct rte_eth_dev *dev)
> +{
> +	return ((dev->data->dev_flags & RTE_ETH_DEV_REPRESENTOR) != 0);
> +}
> +

There is a 'rte_eth_representor_id_get()' API above, can you move this
new one below it to group them together?


  reply	other threads:[~2024-02-23  9:29 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-10 10:42 [PATCH 0/4] add support of partial offload Chaoyong He
2024-02-10 10:42 ` [PATCH 1/4] net/nfp: support MARK flow action Chaoyong He
2024-02-10 10:42 ` [PATCH 2/4] net/nfp: add interface to check representor Chaoyong He
2024-02-12 16:24   ` Ferruh Yigit
2024-02-17  1:31     ` Chaoyong He
2024-02-10 10:42 ` [PATCH 3/4] net/nfp: representor adds RSS configuration Chaoyong He
2024-02-10 10:42 ` [PATCH 4/4] net/nfp: support RSS flow action Chaoyong He
2024-02-12 10:10 ` [PATCH 0/4] add support of partial offload David Marchand
2024-02-17  1:31   ` Chaoyong He
2024-02-23  2:42 ` [PATCH v2 0/4] add support of MARK and RSS flow action Chaoyong He
2024-02-23  2:42   ` [PATCH v2 1/4] ethdev: add function to check representor port Chaoyong He
2024-02-23  9:29     ` Ferruh Yigit [this message]
2024-02-23  2:42   ` [PATCH v2 2/4] net/nfp: support MARK flow action Chaoyong He
2024-02-23  2:42   ` [PATCH v2 3/4] net/nfp: add representor RSS configuration Chaoyong He
2024-02-23  2:42   ` [PATCH v2 4/4] net/nfp: support RSS flow action Chaoyong He
2024-02-26  1:44   ` [PATCH v3 0/4] add support of MARK and " Chaoyong He
2024-02-26  1:44     ` [PATCH v3 1/4] ethdev: add function to check representor port Chaoyong He
2024-02-26 14:31       ` Ferruh Yigit
2024-02-26  1:44     ` [PATCH v3 2/4] net/nfp: support MARK flow action Chaoyong He
2024-02-26  1:44     ` [PATCH v3 3/4] net/nfp: add representor RSS configuration Chaoyong He
2024-02-26  1:45     ` [PATCH v3 4/4] net/nfp: support RSS flow action Chaoyong He
2024-02-26 14:31     ` [PATCH v3 0/4] add support of MARK and " Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=17958b3f-0fa4-408d-af01-1f934a0bfc55@amd.com \
    --to=ferruh.yigit@amd.com \
    --cc=chaoyong.he@corigine.com \
    --cc=dev@dpdk.org \
    --cc=long.wu@corigine.com \
    --cc=oss-drivers@corigine.com \
    --cc=peng.zhang@corigine.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).