DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: "Jan Mędala" <jan@semihalf.com>
Cc: dev@dpdk.org, Bruce Richardson <bruce.richardson@intel.com>,
	Alexander Matushevsky <matua@amazon.com>,
	Evgeny Schemeilin <evgenys@amazon.com>,
	Jakub Palider <jpa@semihalf.com>
Subject: Re: [dpdk-dev] [PATCH v7 4/4] ena: DPDK polling-mode driver for Amazon Elastic Network Adapters (ENA)
Date: Thu, 17 Mar 2016 14:57:02 +0100	[thread overview]
Message-ID: <1796521.zug8sZHtGq@xps13> (raw)
In-Reply-To: <CANw_3ZeANtJCKQf+mvY_wgNM_p8C+3H8D8sB--ZAOo4+mJDqnA@mail.gmail.com>

2016-03-17 14:48, Jan Mędala:
> >
> > >  #
> > > +# Compile burst-oriented Amazon ENA PMD driver
> > > +#
> > > +CONFIG_RTE_LIBRTE_ENA_PMD=y
> > > +CONFIG_RTE_LIBRTE_ENA_DEBUG_INIT=y
> >
> > Do you really want initialization debuggin to be on by default? Normally,
> > we
> > keep all debug options disabled.
> 
> This is actually error logging, so it's silent for user until there is
> something wrong with initialization.
> Do you want me to rename it to point more accurately it's role?

There should not be any option at all to disable error logging.

  reply	other threads:[~2016-03-17 13:58 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-15 14:40 [dpdk-dev] [PATCH v7 0/4] " Jan Medala
2016-03-15 14:40 ` [dpdk-dev] [PATCH v7 1/4] ena: Amazon ENA documentation Jan Medala
2016-03-15 14:40 ` [dpdk-dev] [PATCH v7 2/4] ena: Amazon ENA communication layer Jan Medala
2016-03-15 14:40 ` [dpdk-dev] [PATCH v7 3/4] ena: Amazon ENA communication layer for DPDK platform Jan Medala
2016-03-15 14:40 ` [dpdk-dev] [PATCH v7 4/4] ena: DPDK polling-mode driver for Amazon Elastic Network Adapters (ENA) Jan Medala
2016-03-16 14:34   ` Bruce Richardson
2016-03-17 13:48     ` Jan Mędala
2016-03-17 13:57       ` Thomas Monjalon [this message]
2016-03-17 14:21         ` Jan Mędala

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1796521.zug8sZHtGq@xps13 \
    --to=thomas.monjalon@6wind.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=evgenys@amazon.com \
    --cc=jan@semihalf.com \
    --cc=jpa@semihalf.com \
    --cc=matua@amazon.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).