From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F2440A00C2; Wed, 28 Sep 2022 12:14:05 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D7ABF4113D; Wed, 28 Sep 2022 12:14:05 +0200 (CEST) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by mails.dpdk.org (Postfix) with ESMTP id 870D54113C for ; Wed, 28 Sep 2022 12:14:04 +0200 (CEST) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id C16975C01C6; Wed, 28 Sep 2022 06:14:03 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Wed, 28 Sep 2022 06:14:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; t=1664360043; x= 1664446443; bh=VjqCvhQAyUZ4LrTvkzM8cVsV2xTGjsbsVJGCk6BsqSM=; b=E KWS2t6UHsqJOf8mrP3tdfIAQloY7yvrt5hHF7ginZnE2T5PxIxhxNSzMJp9DQylG WgJdbWb+GS5mlwqC1SStsIFFxm502hFdemOH0O7X3rAlSnj+Z0Ft0ZXpF9h2RU/7 5/q0yvloPMpYGECQ0GVZ/8g5iSni712m7mDxw+xKFKLgPAWKI8MxNyeb3kbc742+ XI5K7HKUis2l4e/EDgm48+ag/tBpIiZuy59/jL+CvhpTY6Y8ErKzsfNCqMPzeCa5 2BVlAeJ3bxndgI4wf/fRHp2OeixMLboND0Y9j6V9Ar2L/XVhoYPQqc+L/T98DrmV n3NOGGWKw7LYVK6dzR/OA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1664360043; x= 1664446443; bh=VjqCvhQAyUZ4LrTvkzM8cVsV2xTGjsbsVJGCk6BsqSM=; b=k b3OumiPG5rD8/Mc0eAGJTHJ9Sf2popvuPGl4CGO0H+QfPBXPudLOzVGwq7gzZ4/V wSPFVhhrvrj3BFlY2JEyF7vIGd0f+sz9pk2pqiLhJWoZzDeS9VeiuWCnUoorC9Kf vxrCxO4qjra/UKuuxXEEph8/BL3Lkxp/uRhJ+OCZapYaWHNkvROd9KAJz+zf8yep GRJYfwXxQgO514jSwZQhtXKbGvnCZYpo0WycEAkZ/b4xILCxA27ZgCC9zIquUJ6O 11utF3+JoWQRyEcuEAilvhRF3A+rp75OO0LEuRaeqwIUkTL7VPmqr9wHawv4x+pS /hr/6LGzLq4CI3US/qsbQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeegkedgvdeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedtjeeiieefhedtfffgvdelteeufeefheeujefgueetfedttdei kefgkeduhedtgfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 28 Sep 2022 06:14:02 -0400 (EDT) From: Thomas Monjalon To: Akhil Goyal , Jerin Jacob , Anoob Joseph Cc: Archana Muniganti , Tejasree Kondoj , dev@dpdk.org Subject: Re: [PATCH v2 15/18] crypto/cnxk: remove unused ctx buf len Date: Wed, 28 Sep 2022 12:14:00 +0200 Message-ID: <1796753.QCnGb9OGeP@thomas> In-Reply-To: <20220809105356.561-16-anoobj@marvell.com> References: <20220808080606.220-1-anoobj@marvell.com> <20220809105356.561-1-anoobj@marvell.com> <20220809105356.561-16-anoobj@marvell.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 09/08/2022 12:53, Anoob Joseph: > Ctx len buf field is unused. Remove it. There is no such field. What do you mean exactly? > -struct roc_se_fc_params { > - /* 0th cache line */ > - union { > - struct roc_se_buf_ptr bufs[1]; > - struct { > - struct roc_se_iov_ptr *src_iov; > - struct roc_se_iov_ptr *dst_iov; > - }; > - }; > - void *iv_buf; > - void *auth_iv_buf; > - struct roc_se_buf_ptr meta_buf; > - struct roc_se_buf_ptr ctx_buf; > - uint32_t rsvd2; > - uint8_t rsvd3; > - uint8_t iv_ovr; > - uint8_t cipher_iv_len; > - uint8_t auth_iv_len; > - > - /* 1st cache line */ > - struct roc_se_buf_ptr aad_buf __plt_cache_aligned; > - struct roc_se_buf_ptr mac_buf; > -}; > - > -PLT_STATIC_ASSERT((offsetof(struct roc_se_fc_params, aad_buf) % 128) == 0); > - > #define ROC_SE_PDCP_ALG_TYPE_ZUC 0 > #define ROC_SE_PDCP_ALG_TYPE_SNOW3G 1 > #define ROC_SE_PDCP_ALG_TYPE_AES_CTR 2 > @@ -349,6 +323,25 @@ struct roc_se_ctx { > uint8_t *auth_key; > }; > > +struct roc_se_fc_params { > + union { > + struct roc_se_buf_ptr bufs[1]; > + struct { > + struct roc_se_iov_ptr *src_iov; > + struct roc_se_iov_ptr *dst_iov; > + }; > + }; > + void *iv_buf; > + void *auth_iv_buf; > + struct roc_se_ctx *ctx; > + struct roc_se_buf_ptr meta_buf; > + uint8_t cipher_iv_len; > + uint8_t auth_iv_len; > + > + struct roc_se_buf_ptr aad_buf; > + struct roc_se_buf_ptr mac_buf; > +};