From: Thomas Monjalon <thomas@monjalon.net>
To: Akhil Goyal <akhil.goyal@nxp.com>, Fan Zhang <roy.fan.zhang@intel.com>
Cc: dev@dpdk.org,
"pablo.de.lara.guarch@intel.com" <pablo.de.lara.guarch@intel.com>
Subject: Re: [dpdk-dev] [PATCH v4] cryptodev: make xform key pointer constant
Date: Fri, 05 Jul 2019 14:30:14 +0200 [thread overview]
Message-ID: <1797255.U67UyW4ygL@xps> (raw)
In-Reply-To: <VE1PR04MB6639642956ED9BD563E6F90AE6E30@VE1PR04MB6639.eurprd04.prod.outlook.com>
25/06/2019 14:46, Akhil Goyal:
>
> >
> > This patch changes the key pointer data types in cipher, auth,
> > and aead xforms from "uint8_t *" to "const uint8_t *" for a
> > more intuitive and safe sessionn creation.
> >
> > Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
> > Acked-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>
> > Acked-by: Akhil Goyal <akhil.goyal@nxp.com>
> > ---
> > v4:
> > - Removed deprecation notice and updated release note.
> > - Updated ABI version.
> >
> > v3:
> > - rebased on top of latest dpdk-next-crypto
> >
> > v2:
> > - fixed a missed memory free for ixgbe ipsec
>
> Applied to dpdk-next-crypto
> The changes related to update for ABI version were incomplete in this patch, so they were dropped. Another patch from Anoob was also updating the ABI version, so not required in this patch.
I think this patch is not complete, because there is a compilation issue
with mvsam PMD when compiling arm64-thunderx-linux-gcc:
drivers/crypto/mvsam/rte_mrvl_pmd.c:260:35: error:
assignment discards 'const' qualifier from pointer target type
prev parent reply other threads:[~2019-07-05 12:30 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-01 13:43 [dpdk-dev] [PATCH] " Fan Zhang
2019-03-15 16:37 ` Kusztal, ArkadiuszX
2019-03-15 16:37 ` Kusztal, ArkadiuszX
2019-03-19 9:43 ` [dpdk-dev] [PATCH v2] " Fan Zhang
2019-03-19 9:43 ` Fan Zhang
2019-03-20 13:32 ` [dpdk-dev] [PATCH v3] " Fan Zhang
2019-03-20 13:32 ` Fan Zhang
2019-03-20 17:28 ` Kusztal, ArkadiuszX
2019-03-20 17:28 ` Kusztal, ArkadiuszX
2019-03-29 14:07 ` Akhil Goyal
2019-03-29 14:07 ` Akhil Goyal
2019-03-29 14:19 ` Thomas Monjalon
2019-03-29 14:19 ` Thomas Monjalon
2019-03-29 15:48 ` Akhil Goyal
2019-03-29 15:48 ` Akhil Goyal
2019-03-29 16:01 ` Akhil Goyal
2019-03-29 16:01 ` Akhil Goyal
2019-05-28 9:52 ` Zhang, Roy Fan
2019-05-29 6:29 ` Akhil Goyal
2019-06-19 15:08 ` Akhil Goyal
2019-06-20 6:47 ` Thomas Monjalon
2019-06-24 13:35 ` [dpdk-dev] [PATCH v4] " Fan Zhang
2019-06-25 12:46 ` Akhil Goyal
2019-07-05 12:30 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1797255.U67UyW4ygL@xps \
--to=thomas@monjalon.net \
--cc=akhil.goyal@nxp.com \
--cc=dev@dpdk.org \
--cc=pablo.de.lara.guarch@intel.com \
--cc=roy.fan.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).