From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id AF576A2EEB for ; Fri, 13 Sep 2019 12:48:02 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7306B1F06D; Fri, 13 Sep 2019 12:48:02 +0200 (CEST) Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) by dpdk.org (Postfix) with ESMTP id 079F01F017 for ; Fri, 13 Sep 2019 12:48:00 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 6D3084F7; Fri, 13 Sep 2019 06:47:58 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Fri, 13 Sep 2019 06:47:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=w1GtF/cNoaS0gs2nL4aozhokDn6LjKjZmsWk18dTPSA=; b=gWxFYtBJ4cHL PUFm3tKw6ohlAZcMbLlhDkLqn90BWAsb4uQojRWuLGQn4cZJ3jYI0Jelz28lno2v Vyeo2xHCMlUgOuanGkMixELZMmzJYxYp0sS/G7ydDj82aahMtVyV+4lFYJpSf0Uo PTscXYKFhafJtAX0CMjqSnUAuW/KvoM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=w1GtF/cNoaS0gs2nL4aozhokDn6LjKjZmsWk18dTP SA=; b=QoQ2y2DALN+EKef2rZe9bbNnLu78MPu5KixpXtnDDJPiK2o/pY1lA0AGF pM0tUknMZLnYvFd8RxuwRX8uPZduTM0WNSbm1idRWdd9azOWykP55pR5C/B8USZj Qs0J412ck6nrtm01weMl9bkqhteq5eZhMbRQtjAyVuKWfpqVbPfFArZKp1januvl k1r90nXCoBExPhJJ6EzmNCnTa0nec/4K4BkkMI6YO0QazEBGbXYIF34lBuTHEiyH XYUSxOl803/KfJjScj7R5fEz29IQIo9okj0o0DVUu27b7zPpPr5n64vqCl3vrAKy s9bCdXNsBC8Wiiej3QyttkERY5hSg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedrtdejgdefvdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhho mhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 3D911D60066; Fri, 13 Sep 2019 06:47:56 -0400 (EDT) From: Thomas Monjalon To: Andrew Rybchenko Cc: "Iremonger, Bernard" , Neil Horman , "Mcnamara, John" , "Kovacevic, Marko" , "Yigit, Ferruh" , "dev@dpdk.org" , Ivan Ilchenko Date: Fri, 13 Sep 2019 12:47:55 +0200 Message-ID: <1797442.2sc5hEFe06@xps> In-Reply-To: <16be701c-2160-f630-19a7-c48a2a63e5d2@solarflare.com> References: <1566915962-5472-1-git-send-email-arybchenko@solarflare.com> <8CEF83825BEC744B83065625E567D7C260DF77A1@IRSMSX108.ger.corp.intel.com> <16be701c-2160-f630-19a7-c48a2a63e5d2@solarflare.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v4 02/54] ethdev: change rte_eth_dev_info_get() return value to int X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 13/09/2019 12:36, Andrew Rybchenko: > On 9/13/19 1:18 PM, Iremonger, Bernard wrote: > > ./check-git-log.sh -1 > > Wrong headline format: > > ethdev: change rte_eth_dev_info_get() return value to int > > In this particular case we decided (may be incorrectly) that it would > be more harm if we rephrase it without mentioning function name. > It is trivial to fix. No strong opinion. As a general rule, function name is forbidden to avoid cryptic titles. Here it could be: ethdev: add return code to device info get function > My main goal of yesterday re-spin was to check build with missing > patch applied to DPDK main repo, but unfortunately there are still > some build issues (meson column) which I don't understand. It is my fault. I hope meson CI is fixed now.