From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f181.google.com (mail-wi0-f181.google.com [209.85.212.181]) by dpdk.org (Postfix) with ESMTP id E782FC370 for ; Thu, 23 Jul 2015 15:01:34 +0200 (CEST) Received: by wibud3 with SMTP id ud3so217921971wib.0 for ; Thu, 23 Jul 2015 06:01:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=LNpto7rAtKL7PTeM8AKuWPfbIBFw44qJgwSlH2iadRI=; b=V61asWkGnHnM8+icjCn8HD5QwRd3xTLSAQ4m24Xz6ttYjn+wTHSli6k/99awrt//D6 g+coTs5LgDLMgem/jX/MPVUrQR9CE1yWYxM4cMxoTI1QHRP1Ci5rmHOBUDEUI7AULeX3 9XPqNEiQ0PAKmLoxqeap63t78ZsnMhzPYabOgzURvWwKvNSm93ecwzOiIHxklq5fSGHH fWO3nHHaeKBHTvMP9amTniRPA9EKkC8h2Nohzfti1khqGAEgWpM6RjSVhNUA1Mnm5HMt oUhTP/in5zmQz5PnhfVArTSUNG01xLGGY6rcTC0v7a4bKG/zeoEod6G+qDmX5THPca0/ aVMA== X-Gm-Message-State: ALoCoQkQKGWqCeuRHXgB/6x5KERqcdUK9M1ptigHItxOWpy4c3JYXZVtnrC2Y7gYrsNemt3lcg98 X-Received: by 10.194.192.33 with SMTP id hd1mr16344319wjc.96.1437656494753; Thu, 23 Jul 2015 06:01:34 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by smtp.gmail.com with ESMTPSA id dl10sm7420984wjb.42.2015.07.23.06.01.32 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 23 Jul 2015 06:01:33 -0700 (PDT) From: Thomas Monjalon To: "Tahhan, Maryam" Date: Thu, 23 Jul 2015 15:00:21 +0200 Message-ID: <1798990.EYfMvRFpM3@xps13> Organization: 6WIND User-Agent: KMail/4.14.8 (Linux/4.0.4-2-ARCH; KDE/4.14.8; x86_64; ; ) In-Reply-To: <86228AFD5BCD8E4EBFD2B90117B5E81E10E67623@SHSMSX103.ccr.corp.intel.com> References: <1437395309-197026-1-git-send-email-maryam.tahhan@intel.com> <6A0DE07E22DDAD4C9103DF62FEBC0909CFB94D@shsmsx102.ccr.corp.intel.com> <86228AFD5BCD8E4EBFD2B90117B5E81E10E67623@SHSMSX103.ccr.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org, "Nemeth, Balazs" Subject: Re: [dpdk-dev] [PATCH v2 1/1] ixgbe: Fix phy errors in stats->ierrors X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Jul 2015 13:01:35 -0000 > > > Fixes: f6bf669b990004dc69231476d9fcf0b80574e568. Bug fix to remove > > > (rxnfgpc - hw_stats->gprc) which does not account for phy errors. > > > hw_stats->gprc is the Number of good (non-erred) Rx packets (from the > > > network) that pass L2 filtering and has a legal length as defined by > > > LongPacketEnable. While rxnfgpc is the Number of good (non-erred with > > legal > > > length) Rx packets (from the network) regardless of packet filtering and > > receive > > > enablement. Thus hw_stats->gprc can be > rxnfgpc and this calculation > > should > > > be removed from the calculation of ierrors. > > > Validated with testpmd by sending packets to the interface without > > forwarding > > > enabled - packets should be dropped and the error counters incremented. > > > > > > v2: > > > - specified the commit that this bug fix fixes. > > > > > > Signed-off-by: Maryam Tahhan > > Acked-by: Wenzhuo Lu > Tested-by: Marvin Liu Applied, thanks