From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f51.google.com (mail-wm0-f51.google.com [74.125.82.51]) by dpdk.org (Postfix) with ESMTP id 9A49C9E3 for ; Thu, 9 Jun 2016 17:01:16 +0200 (CEST) Received: by mail-wm0-f51.google.com with SMTP id n184so229456267wmn.1 for ; Thu, 09 Jun 2016 08:01:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=P2BshU36pn1WNESc3Vz0g8HzcS/MUoVJxDQYAIrqj8w=; b=GJLySWRAP4i17AeNweuLj8j7bAY+dWSXTM5snOzP79ZjCzCP6YVoyPq6XGq/fbsyv4 iJF/w4nRdAUAL4iIWLEmljMmNHYfBLHfS5vR/XoclEN+hB+KAk+HQtr1QwgGyEKrQlyT YbB3vilm8ppmmHyuWAZoIs7Euwu8Ox/AWIGlCFRys9PHW8W1xAlXaVasHnMYaWEqoQ1E 32RXgM1VDopIhAgd3jA4kDq9E0ATMJU6cboyTStOT6Phe2KHB0ToP4RpBPiZ6BMJk9SH DMUP77patGFS/VH8nstkA3JwkUow8MWyioUWgNmyh3lPms+Y/y9n/633D292Q4IBJ2zp 6udA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=P2BshU36pn1WNESc3Vz0g8HzcS/MUoVJxDQYAIrqj8w=; b=fXiaXBesMR2KivfG1RoQpZDyXaoseSxKBh5+uf/rX4VR2Rm/bIaOxJjTGPWmtxJ/lY b0N1uYoipOFZipW4iAVrkA/EN3T3riDcqULPHTxaoKC32XqcsM3pS/gxGuQW5SiDSMBi OnTPk5/OVCkaSRmXD2RuhK1vrgydPlSNvO9NkVwJJ2iSY0UhoC0ZlOkuWHaRfUAJbtzG QCd0in5p1ak7PobYDdGVdZyZvnnTgZUO1E+1q1rQRR/3KaF8uOAMhAVJvxhi947YABzg udm2jqOTqY9A7TchRPf5e5XAwjF63d48EtAAWrnXoBWCoOGBfWMEaelJmrNrnDVbLMnU TTpQ== X-Gm-Message-State: ALyK8tKHMxQikx/zgNbrKoyLd9EHYM+EGZM/jbBO8/QOAcT2+uT28LP/5jWaAymk5EZm574R X-Received: by 10.194.216.33 with SMTP id on1mr735917wjc.153.1465484476342; Thu, 09 Jun 2016 08:01:16 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id q189sm8098105wmd.19.2016.06.09.08.01.15 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 09 Jun 2016 08:01:15 -0700 (PDT) From: Thomas Monjalon To: David Marchand Cc: dev@dpdk.org Date: Thu, 09 Jun 2016 17:01:14 +0200 Message-ID: <1799099.25AIKSsmQj@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: References: <1465481396-23968-1-git-send-email-thomas.monjalon@6wind.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] log: deprecate history dump X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Jun 2016 15:01:16 -0000 2016-06-09 16:45, David Marchand: > On Thu, Jun 9, 2016 at 4:09 PM, Thomas Monjalon > wrote: > > The log history uses rte_mempool. In order to remove the mempool > > dependency in EAL (and improve the build), this feature is deprecated. > > The ABI is kept but the behaviour is now voided because it seems this > > function was not used. The history can be read from syslog. > > It does look like it is not really used. > I am for this change unless someone complains. > > Comments below. All your comments will be addressed in a v2. Thanks > - Since you are looking at this, what keeps us from removing the > dependency on librte_ring ? Please see this first small cleanup: http://dpdk.org/ml/archives/dev/2016-June/040798.html > I would say it was mainly because of mempool. > Maybe ivshmem ? Yes CONFIG_RTE_LIBRTE_IVSHMEM brings dependencies to rte_ring and rte_ivshmem. This "feature" also pollute the memory allocator and makes rework harder. That's why I would be in favor of removing CONFIG_RTE_LIBRTE_IVSHMEM. Otherwise, as an alternative proposal, the file lib/librte_eal/linuxapp/eal/eal_ivshmem.c could be moved outside of EAL. Probably that lib/librte_ivshmem/ would be a good place. The tricky operation would be to remove ivshmem init from eal: #ifdef RTE_LIBRTE_IVSHMEM if (rte_eal_ivshmem_init() < 0) rte_panic("Cannot init IVSHMEM\n"); #endif if (rte_eal_memory_init() < 0) rte_panic("Cannot init memory\n"); /* the directories are locked during eal_hugepage_info_init */ eal_hugedirs_unlock(); if (rte_eal_memzone_init() < 0) rte_panic("Cannot init memzone\n"); if (rte_eal_tailqs_init() < 0) rte_panic("Cannot init tail queues for objects\n"); #ifdef RTE_LIBRTE_IVSHMEM if (rte_eal_ivshmem_obj_init() < 0) rte_panic("Cannot init IVSHMEM objects\n"); #endif