DPDK patches and discussions
 help / color / mirror / Atom feed
From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: zhiyong.yang@intel.com, dev@dpdk.org
Cc: stable@dpdk.org, tiwei.bie@intel.com, lei.a.yao@intel.com,
	ferruh.yigit@intel.com
Subject: Re: [dpdk-dev] [PATCH v2] net/virtio: fix add pointer checking for rxvq
Date: Thu, 24 May 2018 14:33:05 +0200	[thread overview]
Message-ID: <179a5942-25cc-57d1-6277-3bf551fbd20d@redhat.com> (raw)
In-Reply-To: <20180524155101.40911-1-zhiyong.yang@intel.com>



On 05/24/2018 05:51 PM, zhiyong.yang@intel.com wrote:
> For virtio-user server mode, one use case comes across segmentation fault.
> step 1: Launch vhost side as client firstly.
> step 2: launch virtio-user side as server.
> 
> The cause is: after registering virtio_interrupt_handler into
> eal-intr-thread, two threads (main thread and eal-intr-thread) have
> sync issues, so add rxvq pointer checking in function virtio_notify_peers
> to decide if the code can continue.
> 
> Fixes: bd8f50a45d0f ("net/virtio-user: support server mode")
> Cc: stable@dpdk.org
> Cc: maxime.coquelin@redhat.com
> Cc: tiwei.bie@intel.com
> Cc: lei.a.yao@intel.com
> Cc: ferruh.yigit@intel.com
> 
> Signed-off-by: Zhiyong Yang <zhiyong.yang@intel.com>
> Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
> ---
> 
> Change in V2:
> change title prefix from net/virtio-user to net/virtio.
> 
>   drivers/net/virtio/virtio_ethdev.c | 3 +++
>   1 file changed, 3 insertions(+)

Applied to dpdk-next-virtio/master.

Thanks,
Maxime

      reply	other threads:[~2018-05-24 12:33 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-24 13:04 [dpdk-dev] [PATCH] net/virtio-user: " zhiyong.yang
2018-05-24  7:39 ` Maxime Coquelin
2018-05-24 15:51 ` [dpdk-dev] [PATCH v2] net/virtio: " zhiyong.yang
2018-05-24 12:33   ` Maxime Coquelin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=179a5942-25cc-57d1-6277-3bf551fbd20d@redhat.com \
    --to=maxime.coquelin@redhat.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=lei.a.yao@intel.com \
    --cc=stable@dpdk.org \
    --cc=tiwei.bie@intel.com \
    --cc=zhiyong.yang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).