From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 201A51D623 for ; Fri, 15 Jun 2018 16:57:07 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Jun 2018 07:57:06 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,227,1526367600"; d="scan'208";a="49612012" Received: from irsmsx153.ger.corp.intel.com ([163.33.192.75]) by orsmga008.jf.intel.com with ESMTP; 15 Jun 2018 07:57:06 -0700 Received: from irsmsx103.ger.corp.intel.com ([169.254.3.136]) by IRSMSX153.ger.corp.intel.com ([169.254.9.60]) with mapi id 14.03.0319.002; Fri, 15 Jun 2018 15:57:05 +0100 From: "Laatz, Kevin" To: "Dumitrescu, Cristian" , "dev@dpdk.org" CC: "Singh, Jasvinder" Thread-Topic: [PATCH] examples/ip_pipeline: add link show to the cli Thread-Index: AQHT/0YpIGrbqJPCOEWTgr+owCb9iqRWgn+AgArsCOA= Date: Fri, 15 Jun 2018 14:57:04 +0000 Message-ID: <17B8B96B619B7A459C5ACA628B274952BFF8E8@IRSMSX103.ger.corp.intel.com> References: <20180608163053.37891-1-kevin.laatz@intel.com> <3EB4FA525960D640B5BDFFD6A3D891268E757604@IRSMSX108.ger.corp.intel.com> In-Reply-To: <3EB4FA525960D640B5BDFFD6A3D891268E757604@IRSMSX108.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMDM5YjJiMDAtZWRlZS00YzcyLTkwNzAtYTdiZjNjMWUzY2RlIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiaUpkSGdJOFpHOVFxMlZUVlpGZDZTK2NLNElTSG5qVjhIaGd5MWNPSk5HajU1VCtvV05BTnNmREErbEdldjdabCJ9 x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] examples/ip_pipeline: add link show to the cli X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Jun 2018 14:57:08 -0000 Hi Cristian, > > + > > + link_list =3D links_get(); >=20 > We don't need this function, the lined list of links is a global public o= bject, > please access it directly. link_list is declared as a static struct in link.c so it is not accessible = from cli.c I can either leave this function in to pass the pointer to the cli.c or mov= e the declaration to link.h.=20 Do you have a preference? > > > > +struct link_list * > > +links_get(void) > > +{ > > + return &link_list; > > +} > > + >=20 > Function to be removed, used linked list of links directly (see comment > above). See above comment=20 Thanks, Kevin