From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 53139A0542; Tue, 31 May 2022 12:47:49 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 33064400EF; Tue, 31 May 2022 12:47:49 +0200 (CEST) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2074.outbound.protection.outlook.com [40.107.243.74]) by mails.dpdk.org (Postfix) with ESMTP id 51526400D6 for ; Tue, 31 May 2022 12:47:48 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=j/Sr+xS+vQ37kcSuZ6tZBVXHf2D+c2yywSKYO60VD9GbSG8vkVa7pnNfwfOlLlwE/n2UYzLGYtYze1YOX/XeS1UCr4o88sLKfg0y/YJPF5bw2y+80UmBuTGS9fjtQaFSzFx/Pf3POr/57k3+qVkV0N/eXqSHGUJxtEcTL+YlbXGD+XGo183cG+8c5cLAg8WETlS66ks5Y8KynSSPnTMDfMpK/GABtCX4G3/io1P4XiQIZ3uYgFV5GgKlNlsLrKl1DzAw21rhIowohE6ykLq1fcdHqrg6uadikBEWAwrbh+Zdc39kDBvwykkUUBVtXLIJ11ly2sf/SeGBFk15q/meiQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8zXpM2chEklsdpYOWQh/H79Scm7i0sxXjtbVXJ02Z9g=; b=Ic4miPImhLF96S1kzhZ49IcwGdNKFTPMy05WCANCpDMePY0arKp00cNwkBOrdbzJBzKYu/mA2p6lgzImUujQVH0RoE7K4eH3Tjv14//mRw8z2ehxKyL1tcM9vLjw7KRX4UqBkm+m2tfI9CyBJoxB9EHON8NW7QrPQeZakNXKxY6oC///GbT/WxbMFj2xqEHuggueqg+BhOoc8gcCydRfyEdLd8rDG2tfHLWVT2DefsnCz3k5C/h+kRM25UydTW2sW9K+wL//0CFBjQQA58R0mu7dziMKbilSGCuWl8d7uYT8hjaqsMHLJtArj8tklOtJeIBW6EwOGw+3NikJJtdW0A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8zXpM2chEklsdpYOWQh/H79Scm7i0sxXjtbVXJ02Z9g=; b=RpBQtlsE4KC4a2YsYsO8WW5RY7ZBnS+7YKK9OL+mTZ0d4/HXZOZdgxsTTwFbsYKcMzgNxmKjnsh8U1VAUObpdxNyrLiHbOiN+hkpUZ+Px6E7OECts/6FIRfuFs/Teh8tqWDvrBDrExiiCHS3AseIktOtj4597eQl8MiunZhF7KJvouO/9LDT2kZtT7eJYD1yegwTPof8T1z819PucSkmkSxqwNCaMi4MxooI0mZe403kw1bz9EhvQ8s+I3W5vC5zCwStnfXp/BuZiC2MnQTcb408nSDzPgDRAcjzOu1bOEauoZRAafSlHJNR7ic7OLLZ4u0isrzybHhWt8YkFhXuMw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from CO6PR12MB5459.namprd12.prod.outlook.com (2603:10b6:303:13b::16) by BL0PR12MB2497.namprd12.prod.outlook.com (2603:10b6:207:4c::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.15; Tue, 31 May 2022 10:47:46 +0000 Received: from CO6PR12MB5459.namprd12.prod.outlook.com ([fe80::34ef:8717:3038:667]) by CO6PR12MB5459.namprd12.prod.outlook.com ([fe80::34ef:8717:3038:667%3]) with mapi id 15.20.5314.012; Tue, 31 May 2022 10:47:46 +0000 Content-Type: multipart/alternative; boundary="------------EUWRkVBdnRHXDiahT2cJ07N0" Message-ID: <17ab2cdb-11f2-f643-a511-ec446a8a0cfb@nvidia.com> Date: Tue, 31 May 2022 18:47:38 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [RFC 1/2] ethdev: port flags for pre-configuration flow hints Content-Language: en-US To: Thomas Monjalon Cc: Ori Kam , Ferruh Yigit , Andrew Rybchenko , dev@dpdk.org References: <7384952.EvYhyI6sBW@thomas> From: Jack Min In-Reply-To: <7384952.EvYhyI6sBW@thomas> X-ClientProxiedBy: HK0PR01CA0066.apcprd01.prod.exchangelabs.com (2603:1096:203:a6::30) To CO6PR12MB5459.namprd12.prod.outlook.com (2603:10b6:303:13b::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 3ee21570-8fd5-4bc6-f6e2-08da42f2ff1b X-MS-TrafficTypeDiagnostic: BL0PR12MB2497:EE_ X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: mYLBXWnjK9ANvtbopRul5iKxyt1mh7rAIemFT31+iiv26aT2qE9D7eXMVLiqWVQr4N31G4YJvE8MjgePmyvhTjgW8WuFr8b+3fIDVtHCVouCAJfKnq9XTCbCgdW6klMzKE9nNd/fC/cGlcT/JExvMK2UHwcOriDI+PV68tTkRbzyXOXMDcBkPqU6osLtKojMDcVN71XbFP5U8HWvhMtUIu4jsv0b6jyf5m9B7o7fmjuF3cHL/RYRBx3B0QT0D0Qq3I3SFk9GOT6UcEnoICOj6c0uJ/gmn74/MWR86S4zMqR7om0CT67DIbsbLVhrY3cSr9NUR9NWj18JuqphgsSomLmmmN8GIY4MAr9IsdXTOL3tKbTe3h4npjzyN6boRyT7KYlnPH8LpnrPeNSkHm4329+1NyfeTsZ6DfpfHZmmJ8newNqduD69lqortoWJVRZ22eVJJ89d9r4zZmzDL2ekYsE47TbGXStVyI2rETB/rSmA5w5u/KW60d0jPQU7j+q2byb16GNXW9sNVJv/4gvIf1s/u0mybbq7KMhqIQDX6hb2KUjE9LnOKUpprzUuMCSRoCH99dO01dnaed6l+KH94FDe7X7ZUU1gLfND2BxLT65u3djvBPyK3YztjHqT7tUKLPUauCdXjlrXRFneC1I2JfnKa40x3NhOPNgRrT4afigB9XCR8xWt0gxgntuUjw6KOpfAjGFcV1KAD5rXQBktiLLTJ9ELpa8f5X5YjgHHV3c= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR12MB5459.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(86362001)(6666004)(26005)(508600001)(4326008)(8676002)(6512007)(53546011)(33964004)(6916009)(5660300002)(6486002)(316002)(66556008)(36756003)(54906003)(83380400001)(31686004)(66476007)(8936002)(2906002)(186003)(2616005)(38100700002)(66946007)(31696002)(6506007)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UklCbDBGaS9lQ3FWQ0pwVXFQaldKTWxRVDFQczVFM2w1VU9ZWTdOUWYrSkpX?= =?utf-8?B?eDM5M0ppRzBmS1FKTkRPVVlubk9rMTNLSWxCWjBSZGlHdW5pYkh0Tmx2eXBE?= =?utf-8?B?aTRSNlhBTlZvbnNTUWFoQ2lETnYzUWsxYlFKSDE2QkdReHdCUU55UkdKZmJv?= =?utf-8?B?MC9vMzhCWnJnU0JpNHNzVXVPZ0t4QWwzNmx6MFhPdW81MEJXb0VKNTE0VXJU?= =?utf-8?B?QlA2eHFvM00weDVQVmFrcGxMN3JEdHFCeURyaGFGMkNCcnhJYzlmNDJaSm11?= =?utf-8?B?R3RDeDlqaDQzWlYwRCtIRVFGeDJtWTJsaGd5NUlQeXUzcmxZR1FlZ2tCbU5K?= =?utf-8?B?WFYxQzZjK2FTaFpKN1VtZFNVM1AzSnZvVmJFRDJBYkd2V28yVmswMHZMQmNj?= =?utf-8?B?UXFYSmpSanduZ3I0R1pUNE9rNXNOQWNGNXNWSEZtY3ZHZyt1TzBMam1KNVp2?= =?utf-8?B?TlFET1RRU29DaDBmeDJwd3EyRmFybEUwZzFTelg0TVhNb0xRaVlPT3BsSUVh?= =?utf-8?B?K3lDMm9YTDZCdDlFaUwzckVOQzEveUszTkYwaTRMRTNxV0pRSkYyR3dYdUlO?= =?utf-8?B?b1FYZDNLMEVCUTdlNzk5S1MwNUNDWHg1enluWER1M0NIcHFJRE1qN3o3bDBy?= =?utf-8?B?VmhNS3BFeXhwR295UlFGbDBPRFg2RFRjUm1QRFpFVE9KMmNiaWpoSzNOTWcw?= =?utf-8?B?UG5QWFZWNUFQdVVEQkZ1K2ZGZlpjSHovcHJJVHFSempWZWlRVEdYazd3cG03?= =?utf-8?B?RHJ6cVdCUDN5Q0FLQnpGYktCdkxZSCtWZEp4TjR5UkhGS1EwV21GVEZIMmM0?= =?utf-8?B?cjVtZ2NRNmg0WnY2cWlXeHphUFVsQ1pzQ2gvVmhRalRHd1V2TG1YdFdOT0JF?= =?utf-8?B?cU9oU25KbWZqbFlyTldCeTl5aFg2cXN6eTg4MDlPZ2lZTEptNGpsM0lsQm9l?= =?utf-8?B?SFdsTXhOZTJLdFAyek1KcmJDOGtQaHBKZ25YKzNUQXF6M3VQMGNFY3laaUIr?= =?utf-8?B?QThGelBicms0d1JFQXpNNjRRa2ZhamVBbTFCV0prZkEzN2ZVZlkzV2xHVlN3?= =?utf-8?B?TjlaSTd6TFppMFhKeERWbkp4ZC9lbVRuV0JoN1Q0ZjFQWEd4MjRtdG1tZmpn?= =?utf-8?B?cElNMURKUXhHWVk2dHhKb3ZRY2NKeTRCOEE1NWlQdXp4cVBkU1EwVjloQUZU?= =?utf-8?B?YUFkQU85Zk1LVkFpWDBFYklhaVlvK1dCNnk3NlVyN2p5US93YlVoZVdkUVRM?= =?utf-8?B?N2M1c2x4V3M2NHZlbXVsU0M1YWl5QVFWQzRjaU1ZTDdwYmpkQjgyTExYZ0VU?= =?utf-8?B?NktYU1lsWkhCMmdhaldIODBsa3NlK3N0V0hzMGgyK1BYNzJTM1dZYzVneWUz?= =?utf-8?B?aVJqc0ZzZVozU1pZZXpqN1F4c2FEOEJ5WDFiMkJPbldXZGd2bEtCOWlvbDBx?= =?utf-8?B?alhibURhUG9hVDFlYkZ4WE1QanAvWTNIa0xjLytWektmVjRQZUphdnVuOHRz?= =?utf-8?B?NUN6UXFueGRDK1UzTVZuelc5Q1NrMEU4VndZSSswc3VGMWZLak1TazBMdEFM?= =?utf-8?B?U05wYndmNzhzbW5XeVRwSkRIL0g2MFMzWkU3OHlGVDFJeFI2Tnh6RGd1ZlR5?= =?utf-8?B?aVdTUWd1RHZQK2hZL2ZZekdvN3hUQUJ0aDFUOUxvb3hlVnpVNTl4Sk1oVG5n?= =?utf-8?B?TWx5R3pTZWR0YzVGQkcwV3RJTlFrMDJsN0xTeEZYa3VkeHpidDUyYWMyZW1O?= =?utf-8?B?UUllQ05rYzB5SmtONUNMdWp1MGNEK2Q3NWV1Ry9HbFhSekptQmdJY0I2WmM0?= =?utf-8?B?YnE5cmpybFhCTU1pMzZML3VOclRwYWdBWHA0RjBaOEdIZnBiZWlIdEd0anJt?= =?utf-8?B?ZnBoejNaU0RQOFpYSTdBOWdaYzUzczAxQzc2U3BSNmVtR1hFaDA3b1lNcE5t?= =?utf-8?B?ajFsTXg2MGxCNnNoM2ovZ1NublVKdk5UZ051Smk1V1M0NUsyTy85cHd0NHJM?= =?utf-8?B?dGprYzBWTVBJS3VUdkZFbE5tcEFkTWJUZUhjVm8xMklTYWR0M2VwQkROMmpq?= =?utf-8?B?TVBWYnZNdEFLV2NVRnlQekVMUWJuWE9UcGFKMGQ2RFQ3NHNzd3lDMTFkdmNK?= =?utf-8?B?d2RPeDlFclZnWVZKeE56bE92NUluYVpNOVEwZU8xY3N3aTQ3N1V4cWdXd1Z3?= =?utf-8?B?bHhpZmNwS1RqTDJGWVM0ajZrRFJMb1lvWGNPWGV6T0dQT0I2dUYwVmZRWGtl?= =?utf-8?B?Mkx1eTkwOHhDUDVaTXNWS3hrcldFbkFyQWFjSC83ZXdObEFweHE3U0tFRjJj?= =?utf-8?B?eDJSZXRaT0QwY01QWEZaVnllM2NycVBuR1FWSnpXOS9NVFBTSVJSQT09?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3ee21570-8fd5-4bc6-f6e2-08da42f2ff1b X-MS-Exchange-CrossTenant-AuthSource: CO6PR12MB5459.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 May 2022 10:47:46.0118 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: T1LYhJgBtVzbknPDKkgt/yzwxgFtg/zkuf4GqSPydvWqc3iqcOczAf/Zaeb62n3i/7rL+huuVRpab0Ti7CizcA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR12MB2497 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --------------EUWRkVBdnRHXDiahT2cJ07N0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 5/31/22 00:46, Thomas Monjalon wrote: > We were waiting for a v2 of this patch. Hey Thomas, Thank you for the comments. Yes, I'll send v2. > More comments below. I'll update the patch in v2 accordingly. > > 07/04/2022 07:30, Xiaoyu Min: >> The data-path focused flow rule management can manage flow rules in more >> optimized way then tranditional one by using hits provided by > hits -> hints > >> application in initialization phase. >> >> In addition to the current hints we have in port attr, more hints could >> be proivded by application about it's behaviour. > it's -> its > >> One example is how the application do with the same flow: > flow -> flow rule ? > >> A. create/destroy flow on same queue but query flow on different queue >> or queue-less way (i.e, counter query) >> B. All flow operations will be exactly on the same queue, by which PMD >> could be in more optimized way then A because resource could be >> isolated and access based on queue, without lock for example. >> >> This patch add flag about above situation and could be extanded to cover > extended > >> more situations. >> >> Signed-off-by: Xiaoyu Min >> --- >> +/** >> + * The flags of rte flow port >> + */ >> +enum rte_flow_port_flag { > Don't use enum for bit flags. > >> + /** >> + * All flow operations for one specified flow will _strictlly_ happen > I guess you mean "for a given flow rule" > > strictlly -> _strictly_ > > > --------------EUWRkVBdnRHXDiahT2cJ07N0 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit
On 5/31/22 00:46, Thomas Monjalon wrote:
We were waiting for a v2 of this patch.

Hey Thomas,

Thank you for the comments.

Yes, I'll send v2.

More comments below.
I'll update the patch in v2 accordingly.

07/04/2022 07:30, Xiaoyu Min:

The data-path focused flow rule management can manage flow rules in more
optimized way then tranditional one by using hits provided by

hits -> hints


application in initialization phase.

In addition to the current hints we have in port attr, more hints could
be proivded by application about it's behaviour.

it's -> its


One example is how the application do with the same flow:

flow -> flow rule ?


A. create/destroy flow on same queue but query flow on different queue
   or queue-less way (i.e, counter query)
B. All flow operations will be exactly on the same queue, by which PMD
   could be in more optimized way then A because resource could be
   isolated and access based on queue, without lock for example.

This patch add flag about above situation and could be extanded to cover

extended


more situations.

Signed-off-by: Xiaoyu Min <jackmin@nvidia.com>
---
+/**
+ * The flags of rte flow port
+ */
+enum rte_flow_port_flag {

Don't use enum for bit flags.


+	/**
+	 * All flow operations for one specified flow will _strictlly_ happen

I guess you mean "for a given flow rule"

strictlly -> _strictly_
--------------EUWRkVBdnRHXDiahT2cJ07N0--