From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BA539A0524; Fri, 14 May 2021 11:09:46 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3C14140042; Fri, 14 May 2021 11:09:46 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mails.dpdk.org (Postfix) with ESMTP id 6787140041 for ; Fri, 14 May 2021 11:09:44 +0200 (CEST) IronPort-SDR: c6QQXerkyPkEIKrBxUbiF/wQRV0xxunxpR8I5M3Whvdonlh/AbAlRIb8XcxgxBkXX5yrpBVNKf 7BUrrgqPVvPg== X-IronPort-AV: E=McAfee;i="6200,9189,9983"; a="187556633" X-IronPort-AV: E=Sophos;i="5.82,299,1613462400"; d="scan'208";a="187556633" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 May 2021 02:09:43 -0700 IronPort-SDR: 6bhBaW54uyyiTkoRDlFlg/3FKJBlN7+/yIT8ciLjTTrsEGPOCNeFRYMCqk49mVc3UkcUo3JhRP Ik7Ks+BSqGiw== X-IronPort-AV: E=Sophos;i="5.82,299,1613462400"; d="scan'208";a="457073037" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.241.112]) ([10.213.241.112]) by fmsmga004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 May 2021 02:09:41 -0700 To: Maxime Coquelin , Thomas Monjalon Cc: Kevin Traynor , Chenbo Xia , dev , Pei Zhang , David Marchand References: <20210513122826.49910-1-chenbo.xia@intel.com> <5e9026cf-6d29-8dd4-b41b-9334f48256fa@intel.com> From: Ferruh Yigit X-User: ferruhy Message-ID: <17be3129-4c4b-4be1-75f5-672d36a819ed@intel.com> Date: Fri, 14 May 2021 10:09:37 +0100 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] vhost: fix wrong IOTLB initialization X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 5/14/2021 9:18 AM, David Marchand wrote: > On Thu, May 13, 2021 at 5:04 PM Ferruh Yigit wrote: >>> If you choose to revert, we can ask Red Hat QA to test RC3 without >>> further delay. Please let us know when you consider the options. >>> >> >> If the patch is not good to go as it is I suggest reverting it, as far as I know >> Chenbo will be off for Friday & Monday, so it doesn't leave much time to >> update/test a new version. > > Yes, reverting is the safer, and the author proposed the same. > ack. Chenbo mentioned this is an optimization, so it should be OK to revert. Thomas, Can you revert the patch [1] in the main repo, or do you prefer a patch for it? [1] 968bbc7e2e50 ("vhost: avoid IOTLB mempool allocation while IOMMU disabled")