From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id B2DF941DB5;
	Thu,  2 Mar 2023 10:21:19 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 98A0440E2D;
	Thu,  2 Mar 2023 10:21:19 +0100 (CET)
Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187])
 by mails.dpdk.org (Postfix) with ESMTP id 69A7440E09
 for <dev@dpdk.org>; Thu,  2 Mar 2023 10:21:18 +0100 (CET)
Received: from dggpeml500024.china.huawei.com (unknown [172.30.72.53])
 by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4PS5Dg6NqvzrSKL;
 Thu,  2 Mar 2023 17:20:35 +0800 (CST)
Received: from [10.67.100.224] (10.67.100.224) by
 dggpeml500024.china.huawei.com (7.185.36.10) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2507.21; Thu, 2 Mar 2023 17:21:15 +0800
Subject: Re: [EXT] [PATCH 4/9] cryptodev: fix segment fault when parse input
 args
To: Akhil Goyal <gakhil@marvell.com>, "thomas@monjalon.net"
 <thomas@monjalon.net>, "ferruh.yigit@amd.com" <ferruh.yigit@amd.com>, Fan
 Zhang <fanzhang.oss@gmail.com>, Declan Doherty <declan.doherty@intel.com>,
 Pablo de Lara <pablo.de.lara.guarch@intel.com>, Fiona Trahe
 <fiona.trahe@intel.com>
CC: "dev@dpdk.org" <dev@dpdk.org>
References: <20230302075012.32423-1-fengchengwen@huawei.com>
 <20230302075012.32423-5-fengchengwen@huawei.com>
 <CO6PR18MB4484ADD74BD52D6638E57C2BD8B29@CO6PR18MB4484.namprd18.prod.outlook.com>
From: fengchengwen <fengchengwen@huawei.com>
Message-ID: <17ccc623-9ea2-e3dc-48b0-d84de575132a@huawei.com>
Date: Thu, 2 Mar 2023 17:21:15 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.11.0
MIME-Version: 1.0
In-Reply-To: <CO6PR18MB4484ADD74BD52D6638E57C2BD8B29@CO6PR18MB4484.namprd18.prod.outlook.com>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-Originating-IP: [10.67.100.224]
X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To
 dggpeml500024.china.huawei.com (7.185.36.10)
X-CFilter-Loop: Reflected
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On 2023/3/2 16:11, Akhil Goyal wrote:
>> The rte_kvargs_process() was used to parse KV pairs, it also supports
>> to parse 'only keys' (e.g. socket_id) type. And the callback function
>> parameter 'value' is NULL when parsed 'only keys'.
>>
>> This patch fixes segment fault when parse input args with 'only keys'
>> (e.g. socket_id,max_nb_queue_pairs).
>>
>> Fixes: 9e6edea41805 ("cryptodev: add APIs to assist PMD initialisation")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Chengwen Feng <fengchengwen@huawei.com>
> Acked-by: Akhil Goyal <gakhil@marvell.com>
> 
> I would say, you can squash your 4/9 and 5/9 patch in a single commit.
> As you are doing the same thing in both the patches.

The cause of the problem is the same but the symptom is different, so I split two commit.

It's okay to squash.

> .
>