From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CD9A0A0562; Wed, 14 Apr 2021 16:22:58 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4371F161AB9; Wed, 14 Apr 2021 16:22:58 +0200 (CEST) Received: from new2-smtp.messagingengine.com (new2-smtp.messagingengine.com [66.111.4.224]) by mails.dpdk.org (Postfix) with ESMTP id 947414013F for ; Wed, 14 Apr 2021 16:22:57 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailnew.nyi.internal (Postfix) with ESMTP id F0F98580596; Wed, 14 Apr 2021 10:22:55 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Wed, 14 Apr 2021 10:22:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm3; bh= 1qM+aDLGC2DDt3x7fsPDQEXRjE+ufhHg9tlVJxxEmxc=; b=BjjsRKcWA0PTgMDs 1H6XZxHcu58p6ARv4s0bKexmYWF2cznSXN4/0ivlnXe9aUYs5EoQlvNwu1j4u0Zr hSSTesSiCTHkP+OUmdBJcNh6su07rdIsE6maHOJp59GKci11ydnjUaniGW5L2KFl EEhjOS5/DDJ5O4TWPV7bu1FAMiBG5IKrq17EykHQm28+D4IvtrN7XiVonWV8W+G1 6PXM+eRFwBagCMW3+T5Vdn/n0zTwMFL+9zPqHcawVFSXqWRiY2he8BUu/ksNGmAp esAsW3cWTYMDQd7QWZkduqBd72AZG8rqsNHjmlX0LUFxJQSlMR1FGq22YqZtpGVw 314LYw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=1qM+aDLGC2DDt3x7fsPDQEXRjE+ufhHg9tlVJxxEm xc=; b=hse85j8zhC/nIrCWoR/Yvb8bumpY+E6D/GLo5+k0KXRlRB5L4eWUhAPZf G/3AFMtBmjGQVzxB/D35CN8hDVWdXxOHr0avhOe/2pMkUYDok2nle+UbeSseZf6M 3AW4Q+bXnITgHQbdI6laOrK8u0n04GgWeaDUv/lrT3/ApZztvhM49puoN2kRSNIo CyXvUcf6nWqe2ayoj+/a3eq7NmSsPuMgAmgDIdwfFfu6Gg2u0/J3n/2qHaW0z4xv 5v3i7XbbZUXY2BNmQTJ/Fhr60w9x+yZcOB+L1cXh5PCqHVjKAa1wX8nzE8O+WhM7 uYpy30F6ZWSPlJOvR5/1BLIcYUDsQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudeluddgjeeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 3B0C8108005B; Wed, 14 Apr 2021 10:22:53 -0400 (EDT) From: Thomas Monjalon To: Akhil Goyal Cc: Jerin Jacob Kollanukkaran , "dev@dpdk.org" , "mdr@ashroe.eu" , "david.marchand@redhat.com" , "abhinandan.gujjar@intel.com" , "hemant.agrawal@nxp.com" , "nipun.gupta@nxp.com" , "sachin.saxena@oss.nxp.com" , Anoob Joseph , "matan@nvidia.com" , "roy.fan.zhang@intel.com" , "g.singh@nxp.com" , "erik.g.carrillo@intel.com" , "jay.jayatheerthan@intel.com" , Pavan Nikhilesh Bhagavatula , "harry.van.haaren@intel.com" , Shijith Thotton Date: Wed, 14 Apr 2021 16:22:51 +0200 Message-ID: <1801425.bUevQpG58e@thomas> In-Reply-To: References: <561328fb16b18404a30a2401c6bfb3a7f373a0f4.1618309291.git.sthotton@marvell.com> <2242749.yNUvgHzJfl@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [EXT] Re: [PATCH v9 4/4] devtools: add exception for reserved fields X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 14/04/2021 16:16, Akhil Goyal: > Hi Thomas, > > > 14/04/2021 14:20, gakhil@marvell.com: > > > From: Akhil Goyal > > > > > > Certain structures are added with reserved fields > > > to address any future enhancements to retain ABI > > > compatibility. > > > However, ABI script will still report error as it > > > is not aware of reserved fields. Hence, adding a > > > generic exception for reserved fields. > > > > > > Signed-off-by: Akhil Goyal > > > --- > > > > > > devtools/libabigail.abignore | 4 ++++ > > > 1 file changed, 4 insertions(+) > > > > > > diff --git a/devtools/libabigail.abignore b/devtools/libabigail.abignore > > > index 46a5a6af5..a9d284f76 100644 > > > --- a/devtools/libabigail.abignore > > > +++ b/devtools/libabigail.abignore > > > @@ -25,3 +25,7 @@ > > > > > > [suppress_type] > > > > > > name = rte_eventdev > > > has_data_member_inserted_between = {offset_after(attached), end} > > > > > > + > > > +; Ignore changes in reserved fields > > > +[suppress_variable] > > > + name_regexp = reserved > > > > If we do that as first patch of this series, > > we don't need the exception on rte_eventdev, right? > > It will still be required, as we have 2 issues > 1. Reserved_ptr[4] to reserved[3] > 2. Additional member ca_enqueue added > > So we need both. If this patch is required, it should not be the last one.