* [dpdk-dev] [PATCH] qat: change optimization flag for Intel QuickAssist Technology
@ 2016-05-10 9:24 Arek Kusztal
2016-05-10 9:56 ` Jain, Deepak K
2016-05-13 8:17 ` Thomas Monjalon
0 siblings, 2 replies; 6+ messages in thread
From: Arek Kusztal @ 2016-05-10 9:24 UTC (permalink / raw)
To: dev; +Cc: fiona.trahe, john.griffin, deepak.k.jain, Arkadiusz Kusztal
From: Arkadiusz Kusztal <arkadiuszx.kusztal@intel.com>
Changed to -O3 optimization flag in Intel QuickAssist Technology Makefile
Signed-off-by: Arkadiusz Kusztal <arkadiuszx.kusztal@intel.com>
---
drivers/crypto/qat/Makefile | 1 +
drivers/crypto/qat/qat_adf/qat_algs_build_desc.c | 8 +++++---
2 files changed, 6 insertions(+), 3 deletions(-)
diff --git a/drivers/crypto/qat/Makefile b/drivers/crypto/qat/Makefile
index 258c2d5..ee72a61 100644
--- a/drivers/crypto/qat/Makefile
+++ b/drivers/crypto/qat/Makefile
@@ -38,6 +38,7 @@ LIBABIVER := 1
# build flags
CFLAGS += $(WERROR_FLAGS)
+CFLAGS += -O3
# external library include paths
CFLAGS += -I$(SRCDIR)/qat_adf
diff --git a/drivers/crypto/qat/qat_adf/qat_algs_build_desc.c b/drivers/crypto/qat/qat_adf/qat_algs_build_desc.c
index bcccdf4..a5210d2 100644
--- a/drivers/crypto/qat/qat_adf/qat_algs_build_desc.c
+++ b/drivers/crypto/qat/qat_adf/qat_algs_build_desc.c
@@ -616,10 +616,12 @@ int qat_alg_aead_session_create_content_desc_auth(struct qat_session *cdesc,
* Write (the length of AAD) into bytes 16-19 of state2
* in big-endian format. This field is 8 bytes
*/
- *(uint32_t *)&(hash->sha.state1[
+ uint32_t *aad_len = (uint32_t *)&hash->sha.state1[
ICP_QAT_HW_GALOIS_128_STATE1_SZ +
- ICP_QAT_HW_GALOIS_H_SZ]) =
- rte_bswap32(add_auth_data_length);
+ ICP_QAT_HW_GALOIS_H_SZ];
+
+ *aad_len = rte_bswap32(add_auth_data_length);
+
proto = ICP_QAT_FW_LA_GCM_PROTO;
} else if (cdesc->qat_hash_alg == ICP_QAT_HW_AUTH_ALGO_SNOW_3G_UIA2) {
proto = ICP_QAT_FW_LA_SNOW_3G_PROTO;
--
2.1.0
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH] qat: change optimization flag for Intel QuickAssist Technology
2016-05-10 9:24 [dpdk-dev] [PATCH] qat: change optimization flag for Intel QuickAssist Technology Arek Kusztal
@ 2016-05-10 9:56 ` Jain, Deepak K
2016-05-13 8:17 ` Thomas Monjalon
1 sibling, 0 replies; 6+ messages in thread
From: Jain, Deepak K @ 2016-05-10 9:56 UTC (permalink / raw)
To: Kusztal, ArkadiuszX, dev; +Cc: Trahe, Fiona, Griffin, John
Acked-by: Deepak Kumar JAIN <deepak.k.jain@intel.com>
-----Original Message-----
From: Kusztal, ArkadiuszX
Sent: Tuesday, May 10, 2016 10:24 AM
To: dev@dpdk.org
Cc: Trahe, Fiona <fiona.trahe@intel.com>; Griffin, John <john.griffin@intel.com>; Jain, Deepak K <deepak.k.jain@intel.com>; Kusztal, ArkadiuszX <arkadiuszx.kusztal@intel.com>
Subject: [PATCH] qat: change optimization flag for Intel QuickAssist Technology
From: Arkadiusz Kusztal <arkadiuszx.kusztal@intel.com>
Changed to -O3 optimization flag in Intel QuickAssist Technology Makefile
Signed-off-by: Arkadiusz Kusztal <arkadiuszx.kusztal@intel.com>
---
drivers/crypto/qat/Makefile | 1 +
drivers/crypto/qat/qat_adf/qat_algs_build_desc.c | 8 +++++---
2 files changed, 6 insertions(+), 3 deletions(-)
diff --git a/drivers/crypto/qat/Makefile b/drivers/crypto/qat/Makefile index 258c2d5..ee72a61 100644
--- a/drivers/crypto/qat/Makefile
+++ b/drivers/crypto/qat/Makefile
@@ -38,6 +38,7 @@ LIBABIVER := 1
# build flags
CFLAGS += $(WERROR_FLAGS)
+CFLAGS += -O3
# external library include paths
CFLAGS += -I$(SRCDIR)/qat_adf
diff --git a/drivers/crypto/qat/qat_adf/qat_algs_build_desc.c b/drivers/crypto/qat/qat_adf/qat_algs_build_desc.c
index bcccdf4..a5210d2 100644
--- a/drivers/crypto/qat/qat_adf/qat_algs_build_desc.c
+++ b/drivers/crypto/qat/qat_adf/qat_algs_build_desc.c
@@ -616,10 +616,12 @@ int qat_alg_aead_session_create_content_desc_auth(struct qat_session *cdesc,
* Write (the length of AAD) into bytes 16-19 of state2
* in big-endian format. This field is 8 bytes
*/
- *(uint32_t *)&(hash->sha.state1[
+ uint32_t *aad_len = (uint32_t *)&hash->sha.state1[
ICP_QAT_HW_GALOIS_128_STATE1_SZ +
- ICP_QAT_HW_GALOIS_H_SZ]) =
- rte_bswap32(add_auth_data_length);
+ ICP_QAT_HW_GALOIS_H_SZ];
+
+ *aad_len = rte_bswap32(add_auth_data_length);
+
proto = ICP_QAT_FW_LA_GCM_PROTO;
} else if (cdesc->qat_hash_alg == ICP_QAT_HW_AUTH_ALGO_SNOW_3G_UIA2) {
proto = ICP_QAT_FW_LA_SNOW_3G_PROTO;
--
2.1.0
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH] qat: change optimization flag for Intel QuickAssist Technology
2016-05-10 9:24 [dpdk-dev] [PATCH] qat: change optimization flag for Intel QuickAssist Technology Arek Kusztal
2016-05-10 9:56 ` Jain, Deepak K
@ 2016-05-13 8:17 ` Thomas Monjalon
2016-05-13 8:24 ` Jain, Deepak K
1 sibling, 1 reply; 6+ messages in thread
From: Thomas Monjalon @ 2016-05-13 8:17 UTC (permalink / raw)
To: Arek Kusztal; +Cc: dev, fiona.trahe, john.griffin, deepak.k.jain
2016-05-10 10:24, Arek Kusztal:
> From: Arkadiusz Kusztal <arkadiuszx.kusztal@intel.com>
>
> Changed to -O3 optimization flag in Intel QuickAssist Technology Makefile
There is another change below. Should it be a separate patch?
> --- a/drivers/crypto/qat/qat_adf/qat_algs_build_desc.c
> +++ b/drivers/crypto/qat/qat_adf/qat_algs_build_desc.c
> @@ -616,10 +616,12 @@ int qat_alg_aead_session_create_content_desc_auth(struct qat_session *cdesc,
> * Write (the length of AAD) into bytes 16-19 of state2
> * in big-endian format. This field is 8 bytes
> */
> - *(uint32_t *)&(hash->sha.state1[
> + uint32_t *aad_len = (uint32_t *)&hash->sha.state1[
> ICP_QAT_HW_GALOIS_128_STATE1_SZ +
> - ICP_QAT_HW_GALOIS_H_SZ]) =
> - rte_bswap32(add_auth_data_length);
> + ICP_QAT_HW_GALOIS_H_SZ];
> +
> + *aad_len = rte_bswap32(add_auth_data_length);
> +
> proto = ICP_QAT_FW_LA_GCM_PROTO;
> } else if (cdesc->qat_hash_alg == ICP_QAT_HW_AUTH_ALGO_SNOW_3G_UIA2) {
> proto = ICP_QAT_FW_LA_SNOW_3G_PROTO;
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH] qat: change optimization flag for Intel QuickAssist Technology
2016-05-13 8:17 ` Thomas Monjalon
@ 2016-05-13 8:24 ` Jain, Deepak K
2016-05-31 11:29 ` De Lara Guarch, Pablo
0 siblings, 1 reply; 6+ messages in thread
From: Jain, Deepak K @ 2016-05-13 8:24 UTC (permalink / raw)
To: Thomas Monjalon, Kusztal, ArkadiuszX; +Cc: dev, Trahe, Fiona, Griffin, John
Hi Thomas,
This change was made to fix the compilation issues arising when optimization flag was changed. Hence its related to same optimization flag patch.
Do you want us to separate the Makefile and .c file change?
Regards,
Deepak
-----Original Message-----
From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
Sent: Friday, May 13, 2016 9:18 AM
To: Kusztal, ArkadiuszX <arkadiuszx.kusztal@intel.com>
Cc: dev@dpdk.org; Trahe, Fiona <fiona.trahe@intel.com>; Griffin, John <john.griffin@intel.com>; Jain, Deepak K <deepak.k.jain@intel.com>
Subject: Re: [dpdk-dev] [PATCH] qat: change optimization flag for Intel QuickAssist Technology
2016-05-10 10:24, Arek Kusztal:
> From: Arkadiusz Kusztal <arkadiuszx.kusztal@intel.com>
>
> Changed to -O3 optimization flag in Intel QuickAssist Technology Makefile
There is another change below. Should it be a separate patch?
> --- a/drivers/crypto/qat/qat_adf/qat_algs_build_desc.c
> +++ b/drivers/crypto/qat/qat_adf/qat_algs_build_desc.c
> @@ -616,10 +616,12 @@ int qat_alg_aead_session_create_content_desc_auth(struct qat_session *cdesc,
> * Write (the length of AAD) into bytes 16-19 of state2
> * in big-endian format. This field is 8 bytes
> */
> - *(uint32_t *)&(hash->sha.state1[
> + uint32_t *aad_len = (uint32_t *)&hash->sha.state1[
> ICP_QAT_HW_GALOIS_128_STATE1_SZ +
> - ICP_QAT_HW_GALOIS_H_SZ]) =
> - rte_bswap32(add_auth_data_length);
> + ICP_QAT_HW_GALOIS_H_SZ];
> +
> + *aad_len = rte_bswap32(add_auth_data_length);
> +
> proto = ICP_QAT_FW_LA_GCM_PROTO;
> } else if (cdesc->qat_hash_alg == ICP_QAT_HW_AUTH_ALGO_SNOW_3G_UIA2) {
> proto = ICP_QAT_FW_LA_SNOW_3G_PROTO;
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH] qat: change optimization flag for Intel QuickAssist Technology
2016-05-13 8:24 ` Jain, Deepak K
@ 2016-05-31 11:29 ` De Lara Guarch, Pablo
2016-06-07 14:56 ` Thomas Monjalon
0 siblings, 1 reply; 6+ messages in thread
From: De Lara Guarch, Pablo @ 2016-05-31 11:29 UTC (permalink / raw)
To: Jain, Deepak K, Thomas Monjalon, Kusztal, ArkadiuszX
Cc: dev, Trahe, Fiona, Griffin, John
Hi Deepak/Arek,
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Jain, Deepak K
> Sent: Friday, May 13, 2016 9:25 AM
> To: Thomas Monjalon; Kusztal, ArkadiuszX
> Cc: dev@dpdk.org; Trahe, Fiona; Griffin, John
> Subject: Re: [dpdk-dev] [PATCH] qat: change optimization flag for Intel
> QuickAssist Technology
>
> Hi Thomas,
>
> This change was made to fix the compilation issues arising when optimization
> flag was changed. Hence its related to same optimization flag patch.
> Do you want us to separate the Makefile and .c file change?
>
I think you need to explain the change in the .c file and separate it to another patch, if it is not related to the Makefile change (and if it is related, consider creating a patchset, maybe).
Thanks,
Pablo
> Regards,
> Deepak
>
> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> Sent: Friday, May 13, 2016 9:18 AM
> To: Kusztal, ArkadiuszX <arkadiuszx.kusztal@intel.com>
> Cc: dev@dpdk.org; Trahe, Fiona <fiona.trahe@intel.com>; Griffin, John
> <john.griffin@intel.com>; Jain, Deepak K <deepak.k.jain@intel.com>
> Subject: Re: [dpdk-dev] [PATCH] qat: change optimization flag for Intel
> QuickAssist Technology
>
> 2016-05-10 10:24, Arek Kusztal:
> > From: Arkadiusz Kusztal <arkadiuszx.kusztal@intel.com>
> >
> > Changed to -O3 optimization flag in Intel QuickAssist Technology Makefile
>
> There is another change below. Should it be a separate patch?
>
> > --- a/drivers/crypto/qat/qat_adf/qat_algs_build_desc.c
> > +++ b/drivers/crypto/qat/qat_adf/qat_algs_build_desc.c
> > @@ -616,10 +616,12 @@ int
> qat_alg_aead_session_create_content_desc_auth(struct qat_session *cdesc,
> > * Write (the length of AAD) into bytes 16-19 of state2
> > * in big-endian format. This field is 8 bytes
> > */
> > - *(uint32_t *)&(hash->sha.state1[
> > + uint32_t *aad_len = (uint32_t *)&hash->sha.state1[
> >
> ICP_QAT_HW_GALOIS_128_STATE1_SZ +
> > - ICP_QAT_HW_GALOIS_H_SZ]) =
> > - rte_bswap32(add_auth_data_length);
> > + ICP_QAT_HW_GALOIS_H_SZ];
> > +
> > + *aad_len = rte_bswap32(add_auth_data_length);
> > +
> > proto = ICP_QAT_FW_LA_GCM_PROTO;
> > } else if (cdesc->qat_hash_alg ==
> ICP_QAT_HW_AUTH_ALGO_SNOW_3G_UIA2) {
> > proto = ICP_QAT_FW_LA_SNOW_3G_PROTO;
> >
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH] qat: change optimization flag for Intel QuickAssist Technology
2016-05-31 11:29 ` De Lara Guarch, Pablo
@ 2016-06-07 14:56 ` Thomas Monjalon
0 siblings, 0 replies; 6+ messages in thread
From: Thomas Monjalon @ 2016-06-07 14:56 UTC (permalink / raw)
To: Jain, Deepak K, Kusztal, ArkadiuszX
Cc: De Lara Guarch, Pablo, dev, Trahe, Fiona, Griffin, John
2016-05-31 11:29, De Lara Guarch, Pablo:
> Hi Deepak/Arek,
>
> > Hi Thomas,
> >
> > This change was made to fix the compilation issues arising when optimization
> > flag was changed. Hence its related to same optimization flag patch.
> > Do you want us to separate the Makefile and .c file change?
>
> I think you need to explain the change in the .c file and separate it to another patch, if it is not related to the Makefile change (and if it is related, consider creating a patchset, maybe).
Yes, or at least, explain the change in the commit message.
Thanks
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-06-07 14:56 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-05-10 9:24 [dpdk-dev] [PATCH] qat: change optimization flag for Intel QuickAssist Technology Arek Kusztal
2016-05-10 9:56 ` Jain, Deepak K
2016-05-13 8:17 ` Thomas Monjalon
2016-05-13 8:24 ` Jain, Deepak K
2016-05-31 11:29 ` De Lara Guarch, Pablo
2016-06-07 14:56 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).