From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 81242A0A0E; Tue, 11 May 2021 14:10:53 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2983E40140; Tue, 11 May 2021 14:10:53 +0200 (CEST) Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) by mails.dpdk.org (Postfix) with ESMTP id 763864003E for ; Tue, 11 May 2021 14:10:51 +0200 (CEST) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id 4C830FDA; Tue, 11 May 2021 08:10:50 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Tue, 11 May 2021 08:10:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= hZQb20AReaRquPfa8KJkACtXGSrEddNFqd+AV/8S0Xw=; b=AjidvuRY7R5QSgit LfpE4Cya/Unuen+r2rPU1Cdd6I3jo3/1t1kN1Ikky0baE0vwfnPyMs06040ggRM2 ym7+10NC7tPaxuZHDNwU5JcVIX5r+kXncX9VpHyM/ZyOxL6vd9qU4p/xPGa/iTE1 0z5uLDFu82tYKtwyjtyB9bDRCYSCL4ZsgnOWovWPunZNkdnOoB6AU62r02uoW5AN NfLq4WxiBn6T/5jGkps/sFNKlVM9BaQN0RS1nhza67Es7jkXvHRXBIEprN740NES LSpHt8xeJU7UFVVHKHGFkyCnTpbVtNIPWgE8wXQliG6EZ5e/YCEn/qJQO6xd9BNB A6Bi8w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=hZQb20AReaRquPfa8KJkACtXGSrEddNFqd+AV/8S0 Xw=; b=hzERObM8N6xcGdA9dOjvuwIyX/dgecVTC/Ez4NlNk8gzQmRW10IA3/YGL xjBxcSK0mms8bhv7bn3OiIdRKlwjtPAHJn2B/vHQGUKMwgUYFgpcHoPydSS6Ny/o Qvv49ceg82xq7BJlpmGgNmhJ1es6dks+kh9C2surfzvhDSspSn3QaUPqLzP+gboB 1oaBIZLDaY8tMjjsYNgyebg0ik8puxSMIJhGzOKJwg0Qtjgi7xvpwtXt8VKXJZHT nCGu8DWXBJpQo1pYbdeZspOj4Nfd/F7vw42VwBB8d9zOGzmkqzVn3A+o7dJqKA5X TJn5Qgxcxxn+P3I7TFse8IhY4PLIQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvdehtddghedtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 11 May 2021 08:10:48 -0400 (EDT) From: Thomas Monjalon To: Bruce Richardson Cc: dev@dpdk.org, andrew.rybchenko@oktetlabs.ru, ferruh.yigit@intel.com, David Marchand Date: Tue, 11 May 2021 14:10:47 +0200 Message-ID: <1803102.QjYkUBZ0BM@thomas> In-Reply-To: References: <20210409124334.24479-1-david.marchand@redhat.com> <20210511100927.824319-1-thomas@monjalon.net> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3] log: register with standardized names X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 11/05/2021 13:59, Bruce Richardson: > On Tue, May 11, 2021 at 12:09:27PM +0200, Thomas Monjalon wrote: > > --- a/drivers/meson.build > > +++ b/drivers/meson.build > > @@ -59,6 +59,11 @@ foreach subpath:subdirs > > drivers += driver_path[1] > > else > > class = subpath > > + endif > > + > > + log_prefix = 'pmd.' + class > > + > > + if drivers.length() == 0 > > subdir(class) > > endif > > > > Minor nit - rather than splitting the existing block here, I suggest > setting log_prefix = '' at the start of the loop, and leaving the existing > else as-is. Then after the "subdir(class)" just check if log_prefix == > '' and then set it to the default. I think it might be easier to read that > way. [See suggested change below (untested)] > > /Bruce > > diff --git a/drivers/meson.build b/drivers/meson.build > index 0052247a5..9d518d361 100644 > --- a/drivers/meson.build > +++ b/drivers/meson.build > @@ -51,6 +51,7 @@ endif > foreach subpath:subdirs > drivers = [] > std_deps = [] > + log_prefix = '' > > # subpath can be either "class" or "class/driver" > if subpath.contains('/') > @@ -62,6 +63,10 @@ foreach subpath:subdirs > subdir(class) > endif > > + if log_prefix == '': > + log_prefix = 'pmd.' + class > + endif > + OK with this change, I'll send a v4. Nit: please remove useless huge context when replying :)