From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7D7E9A00E6 for ; Mon, 5 Aug 2019 23:22:14 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B54BE1B9C9; Mon, 5 Aug 2019 23:22:13 +0200 (CEST) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id E6CFF1B9B3 for ; Mon, 5 Aug 2019 23:22:11 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 755F9213CA; Mon, 5 Aug 2019 17:22:11 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Mon, 05 Aug 2019 17:22:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=duBjFWirxbVZTgc698jMKgps6im6IeYSQ/rQYqr1yWY=; b=p2A+AAfzKisb AhBD8K06A75KLf/sJyPGwMClLayUdHwsZ0rHsVIFGprrNXg1P3b93NnDAXbsPJXB dg9uEDJlrZicFCpX0HCEVLSOSD+BquGIi6/xy8tIT1KRnS5Yn6ZPAO6c7Po+ti7p orcA2oT7SJxmqTe/KoAjvzGbXXTJ4Z4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=duBjFWirxbVZTgc698jMKgps6im6IeYSQ/rQYqr1y WY=; b=K6MfkaqJ4EMqkRylr6KuNK0QonttP7gHl5Y8t18+rdAl/P0Pv7jdKoO25 UclXi2QiAR22iCt3cLYzvM8s9juq3aUNnB+r+kPdbrtofOX2oCliSIjW/JbLVO77 +W+FI1NxnjfkQIlNfj1cWQLWjFz+SpJT5p5WPif/oagxAYG0Ce03i6/2uyvC9KyX dUq3SOgzH77pAy1QI/Gvh0xxr4wKLc6dQARVFYec2emBe8ywPFKLkV18nA/WKFvv 7sAnXS5EYD99jNrIxBCwW+5nocTYOWwVKszMDw2lWI9gXQi4tU10F38+PgVS08+r bxdFDDJBh4FNDjOBjOknFnFtDyn8A== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduvddruddtkedgudekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukf hppeelfedriedrudegledruddugeenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhm rghssehmohhnjhgrlhhonhdrnhgvthenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (114.149.6.93.rev.sfr.net [93.6.149.114]) by mail.messagingengine.com (Postfix) with ESMTPA id 059B838008C; Mon, 5 Aug 2019 17:22:09 -0400 (EDT) From: Thomas Monjalon To: Vamsi Krishna Attunuru Cc: dev@dpdk.org, Jerin Jacob Kollanukkaran , Nithin Kumar Dabilpuram Date: Mon, 05 Aug 2019 23:22:07 +0200 Message-ID: <1803759.MThDSsQNQm@xps> In-Reply-To: References: <20190802042006.14507-1-vattunuru@marvell.com> <20190802065716.20654-1-vattunuru@marvell.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3 1/1] common/octeontx2: fix unaligned mbox memory accesses X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 02/08/2019 11:55, Jerin Jacob Kollanukkaran: > > From: Vamsi Attunuru > > > > Octeontx2 PMD's mailbox client uses device memory to send messages to > > mailbox server in the admin function Linux kernel driver. > > The device memory used for the mailbox communication needs to be > > qualified as volatile memory type to avoid unaligned device memory > > accesses because of compiler's memory access coalescing. > > > > This patch modifies the mailbox request and responses as volatile type which > > were non-volatile earlier and accessed from unaligned memory addresses > > which resulted in bus errors on Fedora 30 with gcc 9.1.1. > > > > Fixes: 2b71657c8660 ("common/octeontx2: add mbox request and response > > definition") > > > > Signed-off-by: Vamsi Attunuru > > Signed-off-by: Nithin Dabilpuram > > Acked-by: Jerin Jacob > > Thomas, > > Could you merge this patch for rc4. It fixes the bus error with Fedora 30 with gcc 9.1.1. Applied, thanks