From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5E90143BBF; Sat, 24 Feb 2024 11:52:02 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EC989402C8; Sat, 24 Feb 2024 11:52:01 +0100 (CET) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by mails.dpdk.org (Postfix) with ESMTP id 1C1F3402A8 for ; Sat, 24 Feb 2024 11:52:00 +0100 (CET) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id F09395C0061; Sat, 24 Feb 2024 05:51:56 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Sat, 24 Feb 2024 05:51:57 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm1; t=1708771916; x=1708858316; bh=9pLAJVu+pW+DrR37MbUsIu3E11gy6jT17Yt9kcs0PM4=; b= 3C2dCqGqLyMDq1LSDti1PUUXfjLNEnuCu7ktHVTh+WMfynmdkfvu0yoI+/f15963 kDrm5nRU5W1Vn+28m72BFFhJAXW18AOQFQd/XOp5Ri1mc9xTHY/GESWTstyNyUIf 0jJ3UU3hTbWCrvq6AR+kIAjX1XHGf1aJQa9Oxa5iKcgZSHWQwWytihY0ln6mVQEj 7cKNXOOSn0pFmlVX/28QnkZi4h+PHRQR7OxYzFpuvo5m+NfsAIlFp1lq1JSkCwJe GX2rYcYcAEXO8M+XnmeowudZc4F8nCBfm0O4f8BvbM/REAwEaGvTrmY0wVsdBTmr AVZhXo4ZlIpnKcLNXHDOBw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1708771916; x= 1708858316; bh=9pLAJVu+pW+DrR37MbUsIu3E11gy6jT17Yt9kcs0PM4=; b=p yzUkQgoEIenrCmSCjW/QJsVaGLlKy10ZagxL4512t8k+peAC6B7VD6G8GlrXyz9i TK8GpWbaqTaO0yk4mPz1YXbpPHbOx9SG04x2vXl58uzlQ6ZUnOE8bWk9QuP18V2v 2nsgyA06zIKNxu13tL8210qii7J2usQIpDlNz0i6NthVx5nMmNsdwQ9yNd66hPbg TWionDmpETF4rKwtXaqnVgJaFypc1w+qetRz/dyJ+FdEsLgdbMcViSAfkg3ebTZd 8qTNaCfauXMm87JWFwXQiaDnV9gA4Gm4EcHkYZVcfwZjX5yVl1jYGGYVIUbU3feH 0yBP650LQ5uw3w8ZscYIg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrfeekgddvtdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvfevufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnheptdejieeifeehtdffgfdvleetueeffeehueejgfeuteeftddtieek gfekudehtdfgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 24 Feb 2024 05:51:49 -0500 (EST) From: Thomas Monjalon To: Tyler Retzlaff Cc: dev@dpdk.org, Ajit Khaparde , Andrew Boyer , Andrew Rybchenko , Bruce Richardson , Chenbo Xia , Chengwen Feng , Dariusz Sosnowski , David Christensen , Hyong Youb Kim , Jerin Jacob , Jie Hai , Jingjing Wu , John Daley , Kevin Laatz , Kiran Kumar K , Konstantin Ananyev , Maciej Czekaj , Matan Azrad , Maxime Coquelin , Nithin Dabilpuram , Ori Kam , Ruifeng Wang , Satha Rao , Somnath Kotur , Suanming Mou , Sunil Kumar Kori , Viacheslav Ovsiienko , Yisen Zhuang , Yuying Zhang , mb@smartsharesystems.com Subject: Re: [PATCH v5 01/22] eal: provide macro to expand marker extensions Date: Sat, 24 Feb 2024 11:51:46 +0100 Message-ID: <1803928.TLkxdtWsSY@thomas> In-Reply-To: <1708762927-14126-2-git-send-email-roretzla@linux.microsoft.com> References: <1706657173-26166-1-git-send-email-roretzla@linux.microsoft.com> <1708762927-14126-1-git-send-email-roretzla@linux.microsoft.com> <1708762927-14126-2-git-send-email-roretzla@linux.microsoft.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 24/02/2024 09:21, Tyler Retzlaff: > RTE_MARKER typedefs are a GCC extension unsupported by MSVC. Provide a > new macro __rte_marker(type, name) that may be used to expand RTE_MARKER > empty in struct definitions when building with MSVC. I don't think we need to define a new marker macro. I propose to simply not define them with MSVC, triggering a compilation error. So we keep the old markers for applications which were not using MSVC anyway. And inside DPDK libraries and drivers, we remove their usages.