DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: matan@nvidia.com, Viacheslav Ovsiienko <viacheslavo@nvidia.com>,
	Gregory Etelson <getelson@nvidia.com>
Cc: dev@dpdk.org, rasland@nvidia.com,
	Shahaf Shuler <shahafs@nvidia.com>,
	Xueming Li <xuemingl@mellanox.com>
Subject: Re: [dpdk-dev] [PATCH 1/2] drivers/net/mlx5: fix representor interrupts handler
Date: Wed, 04 Nov 2020 19:25:27 +0100
Message-ID: <1803959.hXEH78AfbF@thomas> (raw)
In-Reply-To: <20201028095935.27855-1-getelson@nvidia.com>

28/10/2020 10:59, Gregory Etelson:
> Representor is a port in DPDK that is connected to a VF in such a way
> that assuming there are no offload flows, each packet that is sent
> from the VF will be received by the corresponding representor. While
> each packet that is sent to a representor will be received by the VF.
> This is very useful in case of SRIOV mode, where the first packet that
> is sent by the VF will be received by the DPDK application which will
> decide if this flow should be offloaded to the E-Switch.
> 
> Representor shares interrupts handler with host PF over the PCI
> address. Therefore after PF completes it's interrupts handler

it's -> its

> initialization no additional actions required for representor.

comma missing after "initialization"

> Fixes: 26c08b979d26 ("net/mlx5: add port representor awareness")
> 
> Signed-off-by: Gregory Etelson <getelson@nvidia.com>
> Acked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
> ---
> --- a/drivers/net/mlx5/mlx5_rxq.c
> +++ b/drivers/net/mlx5/mlx5_rxq.c
> +	/**
> +	 * representor shares dev->intr_handle with PF
> +	 */

The style in mlx5 is to start comments with a capital letter
and to end with a period.
Moreover, it does not have to be a doxygen-style comment,
and can be on one line.

Matan, Slava, please check such details in reviews.



  parent reply	other threads:[~2020-11-04 18:25 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-28  9:59 Gregory Etelson
2020-10-28  9:59 ` [dpdk-dev] [PATCH 2/2] examples/l3fwd-power: fix check_ptype query Gregory Etelson
2020-11-04 18:25 ` Thomas Monjalon [this message]
2020-11-17 18:49 ` [dpdk-dev] [PATCH v2 1/2] " Gregory Etelson
2020-11-17 18:49   ` [dpdk-dev] [PATCH v2 2/2] drivers/net/mlx5: fix representor interrupts handler Gregory Etelson
2020-11-22 17:05     ` Thomas Monjalon
2020-11-22 17:03   ` [dpdk-dev] [PATCH v2 1/2] examples/l3fwd-power: fix check_ptype query Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1803959.hXEH78AfbF@thomas \
    --to=thomas@monjalon.net \
    --cc=dev@dpdk.org \
    --cc=getelson@nvidia.com \
    --cc=matan@nvidia.com \
    --cc=rasland@nvidia.com \
    --cc=shahafs@nvidia.com \
    --cc=viacheslavo@nvidia.com \
    --cc=xuemingl@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git