From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 61576A04B1; Wed, 4 Nov 2020 19:25:36 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9BC7D1D9E; Wed, 4 Nov 2020 19:25:34 +0100 (CET) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id CCC6D100C for ; Wed, 4 Nov 2020 19:25:31 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id 759365C01AA; Wed, 4 Nov 2020 13:25:30 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Wed, 04 Nov 2020 13:25:30 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= 70NG7LEiuqxWXyTmSbmwmgDtMtYeF5sc99yYnGgsXU0=; b=KXYI/Kw6mdDCw8Y2 iDoGvB1/FQrvQ2nBuI3rerrGQ7Tj1YLGLWhLssDlTVE3WW17Fk/Yw1soxE/ybiWh RInbhT9fge+4J+wiVR6OMq09yIQ4f1CfrU9tTcJ27+GylI5M9Hp0mweAe4aZMBWp 05+VUPXNmwAR5n0gJaYuzN/0HU4jLTPB2xZIa2ypGQDt2CVDRJ9AfEEFZ4/Pjl9Y SDIR5qTSYP5tHm0hUzm0IOHm1ZtXw9xbztQ5+L2WkKz7GJCfO5tdBH6ZkeHVoQh5 sy3a7PySEfywizPp83YJPROeajMln/NG+H+czENu2gH5rN6+TKL7BxI4VKjJKMRu Tmu8zw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=70NG7LEiuqxWXyTmSbmwmgDtMtYeF5sc99yYnGgsX U0=; b=gk5Uy9gRCUrWAyDijlsP4oik0RqTA5HQgaOyVTJFwEPE3AzOVFbW+b3pT OHtlFrMsAjovwm8XxQ3FEnTX/qld0vwaxjLyLWtLzKux0ZO4sFWAXzD04fQXibIW 78zHaQm2tHH5cX0XNOioODDFbJqk7yxhoHAujNUSzjEc4RN0Qp48gCXk7ntV3e2B pgM/Y9gYcfdlRbLV5GCE0z/FA7GDif+ND3an0eJ3Q9I2YmIyKnBSBEC02l/astqh yezHVJQ6wugDtBhNdkmLJwHzilfDsP3LN7B1LOG+huUb5P3tXpOzicaMR/zzU1Mj 0LhxUy+AxX1LdhgNzULp0OS6RB4RQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedruddthedguddufecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdej ueeiiedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrh fuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgr lhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 4CFCC328037B; Wed, 4 Nov 2020 13:25:29 -0500 (EST) From: Thomas Monjalon To: matan@nvidia.com, Viacheslav Ovsiienko , Gregory Etelson Cc: dev@dpdk.org, rasland@nvidia.com, Shahaf Shuler , Xueming Li Date: Wed, 04 Nov 2020 19:25:27 +0100 Message-ID: <1803959.hXEH78AfbF@thomas> In-Reply-To: <20201028095935.27855-1-getelson@nvidia.com> References: <20201028095935.27855-1-getelson@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 1/2] drivers/net/mlx5: fix representor interrupts handler X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 28/10/2020 10:59, Gregory Etelson: > Representor is a port in DPDK that is connected to a VF in such a way > that assuming there are no offload flows, each packet that is sent > from the VF will be received by the corresponding representor. While > each packet that is sent to a representor will be received by the VF. > This is very useful in case of SRIOV mode, where the first packet that > is sent by the VF will be received by the DPDK application which will > decide if this flow should be offloaded to the E-Switch. > > Representor shares interrupts handler with host PF over the PCI > address. Therefore after PF completes it's interrupts handler it's -> its > initialization no additional actions required for representor. comma missing after "initialization" > Fixes: 26c08b979d26 ("net/mlx5: add port representor awareness") > > Signed-off-by: Gregory Etelson > Acked-by: Viacheslav Ovsiienko > --- > --- a/drivers/net/mlx5/mlx5_rxq.c > +++ b/drivers/net/mlx5/mlx5_rxq.c > + /** > + * representor shares dev->intr_handle with PF > + */ The style in mlx5 is to start comments with a capital letter and to end with a period. Moreover, it does not have to be a doxygen-style comment, and can be on one line. Matan, Slava, please check such details in reviews.