DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] ixgbevf: fix link status for PF up/down events
Date: Mon, 22 Jun 2015 12:17:46 +0200	[thread overview]
Message-ID: <1804687.NP6EMIYIdi@xps13> (raw)
In-Reply-To: <1434465528-12907-1-git-send-email-sergio.gonzalez.monroy@intel.com>

2015-06-16 15:38, Sergio Gonzalez Monroy:
> Current ixgbe VF base driver only really read the status register when:
>  - get_link_status is true
>  - link reset
>  - mailbox timeout.
> 
> We only set get_link_status to true when we start the PF/VF, so
> following calls to ixgbe_dev_link_update will just keep the old link
> status unless the link has been reset.
> 
> Because of this behaviour, when the link status of the PF changes after
> the VF has been initialized, we do not read the current status register
> from the nic and instead we just keep the old link status.
> 
> Fix the problem by setting this field to true before calling
> ixgbe_check_link function from base driver. We don't need to check after
> this call for get_link_status anymore, so remove it.
> 
> Signed-off-by: Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>

Applied, thanks

      reply	other threads:[~2015-06-22 10:18 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-16 14:38 Sergio Gonzalez Monroy
2015-06-22 10:17 ` Thomas Monjalon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1804687.NP6EMIYIdi@xps13 \
    --to=thomas.monjalon@6wind.com \
    --cc=dev@dpdk.org \
    --cc=sergio.gonzalez.monroy@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).