From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D227AA0561; Thu, 18 Mar 2021 11:45:50 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8DC1D406B4; Thu, 18 Mar 2021 11:45:50 +0100 (CET) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by mails.dpdk.org (Postfix) with ESMTP id D6B4C40698; Thu, 18 Mar 2021 11:45:49 +0100 (CET) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 4BF1B5C0172; Thu, 18 Mar 2021 06:45:49 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Thu, 18 Mar 2021 06:45:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm3; bh= WztwlezuPoNZ+U10Xd01pBFfZzpA/si+zOa9QK3sDmw=; b=of4PnbCSujRjnMBu rHMbk+KBbgRpQReCTDp4Fiu+xtp69dXUoT9P/Dk7aeU1GF0qb0vvaklBkGZ9oAuf b6mdclPXK1aycZaVJSjpwcbr5GzqHTG0W1g7K8Sh2MZm5Tbca14hYNYw1aPCciL6 JOsWhpOaTz2o67sIlGxklEHDA5Y1oCuFudryn7DcfkCK+LlEYfV5z8xzu/wpobXM TNLB1ShbBE8bPNJS8lNBOitTDqKXbks06gzw7rAEnq3rDnVgaoWonC9qL6GRSdvW /j021pMhEA5hHMEUOne2aVX3efCAkEqnAWqImHATHb/hsVQpkkxpE2FQz/ZPinO/ L+vx3g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=WztwlezuPoNZ+U10Xd01pBFfZzpA/si+zOa9QK3sD mw=; b=FN/1abXK8YCxOZJnlZZNCCYxEhwzL+LL8LP4HAbp/m90ax6ouASvhfsIv 99m0ihaf7vW4zqvhOIgwP2voaaOVc9grP067/AQhZ0H3dTx0yZGzfAeQk5BYNx9S WJ2+D7KTWGI4ssyM95eRcCIIUfb6yhjXTKin25ZlB33HE/D+NZurYf2cS9ET0d2A BRf6e3r1rktw4dfu+sCiHuydw8PeKPrznyDDUhJtsdmcWOM1X+x4nQVayqeIQGjw +csJ3aKqvNHYNh7xBy/R/3baq5TewMIKSKOy1HvT66F98dWnhzJszU2O7tz3rVJb EvkayePJkpgm8xz8Xph15ZVZRRsQw== X-ME-Sender: <xms:XC9TYEKyqT3uWHYP97Z7b-JZkN9G2x1FKzYOzL5ZNpp_jPrvcNcHsw> <xme:XC9TYGKdYsRdB9WCWAJ95mA2egQe0wfc_tCgtdhIvIyGImJNbPs3AQQp_IRl67uKz EHh69z-1O5L-K_Y1w> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudefiedgvddtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: <xmx:XC9TYOGPMLKcN_d-d7DyNrk5DfLyPJJ6OyNaQc63pyAfzZUSsOltoA> <xmx:XC9TYDleguLn6c9yH-FUUzv7BJrwFtk3wb7-oXh6DDuiYUi0LjO2BQ> <xmx:XC9TYDJBYJ6OjCzwItc_pynbeKQ4K5qv6l5oTHIr6O1B_laphjtGpA> <xmx:XS9TYFVwS3iZGkxGctz3_iGmlMlFvkTz0vZtRFQErE7yOvG_3E1Kuw> Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id B04B31080063; Thu, 18 Mar 2021 06:45:47 -0400 (EDT) From: Thomas Monjalon <thomas@monjalon.net> To: Slava Ovsiienko <viacheslavo@nvidia.com> Cc: "dev@dpdk.org" <dev@dpdk.org>, "dmitry.kozliuk@gmail.com" <dmitry.kozliuk@gmail.com>, "stable@dpdk.org" <stable@dpdk.org>, Tal Shnaiderman <talshn@nvidia.com>, Narcisa Vasile <navasile@linux.microsoft.com>, Ranjit Menon <ranjit.menon@intel.com>, John Alexander <john.alexander@datapath.co.uk>, Pallavi Kadam <pallavi.kadam@intel.com> Date: Thu, 18 Mar 2021 11:45:45 +0100 Message-ID: <1804735.jvUaWJhmuk@thomas> In-Reply-To: <DM6PR12MB3753A0C29DECBE67ACD6484DDF699@DM6PR12MB3753.namprd12.prod.outlook.com> References: <20210316231153.724029-1-thomas@monjalon.net> <DM6PR12MB3753A0C29DECBE67ACD6484DDF699@DM6PR12MB3753.namprd12.prod.outlook.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] bus/pci: fix Windows kernel driver categories X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> 18/03/2021 09:36, Slava Ovsiienko: > From: Thomas Monjalon > > In Windows probing, the value RTE_PCI_KDRV_NONE was used instead of > > RTE_PCI_KDRV_UNKNOWN (mlx case), and RTE_PCI_KDRV_NIC_UIO > > (FreeBSD) was re-used instead of having a new RTE_PCI_KDRV_NET_UIO for > > Windows NetUIO. > > As far as I understand - under Windows there is always some kernel driver > backing the device, hence, RTE_PCI_KDRV_NONE is not an option and > RTE_PCI_KDRV_UNKNOWN is more appropriate. I would add this extra > explanation in commit message. The reason is that NONE is not appropriate because there *is* a kernel driver backing the device in mlx case. And it is aligning with Linux. I will improve the message and comments.