From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B5CA6427F3; Tue, 21 Mar 2023 09:14:21 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 14434410EE; Tue, 21 Mar 2023 09:14:21 +0100 (CET) Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by mails.dpdk.org (Postfix) with ESMTP id 0A79D40A7A; Tue, 21 Mar 2023 09:14:19 +0100 (CET) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id DCCC4320095C; Tue, 21 Mar 2023 04:14:14 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Tue, 21 Mar 2023 04:14:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm2; t= 1679386454; x=1679472854; bh=0QFRvCRE4aOf/wuVGSV1xFFsN4JtZqyzEyb mxE6i9TM=; b=ichSrvtr/81sp+9AafIxAyh2sbLCiPu07luzy1hiDIUVE5mxY0d NtqC6gRbX00yTtovSP0h/9MMeXnjuATHo5CtI+gFYoFocbz/bO7i7YEHV6B6xJMm 2GgVXyGtPpro5YMa4e7ZierzoXZcPA4z1b5xvy7e8i8mWPONhS6hkaBu5sy/w48M UqSoJaoghZ0V/Of1W7/Ll9oqeWriMCRsvmLk9OgIJeZkoMifwUn0REKKIWn6eb5N f2I+VE/o6Yr5KeIgm3p1HZbc+qUUtOSTp2Avry6eYDSW74vDmZMsDKrugYitKwUb yCsHmMoZEhNLplIO0j2c1Hl1Bk7tyAn57Gg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1679386454; x=1679472854; bh=0QFRvCRE4aOf/wuVGSV1xFFsN4JtZqyzEyb mxE6i9TM=; b=nqsLOD1+C2gfW1+vevFkCpm+QgCQsgx1TFbGWM6bjDiG0TK08oX gjB49IM6QcM8ScjJZS4GznsiQ3tpIb4gmDyaldE7UchcIb1nqDtMM/2z7Iw/Q5DE AFLGxA8MTRWjhaKAa6V/94Jwkx3ShhhehJBNsotx5Nq+Cr66v/iK5DoV4NpG0C0h P8qxfalXmPYN7svPLJSJmVThQfqRoTYXyTTBLFjHVdfYCG1urE4aAzSSo09k9mbr dG7rdi3PlpxfEOQ488Z3OTkf8mSXUlBMi5BEcB//lrVdB01cICV/74IeZXPzEuGV jKQleb1Y5yZnt/RgRrApp6HmaWfMvAsPEbQ== X-ME-Sender: <xms:VmcZZFm28smk5B_MjOTEb6YCx1A2V8AJXdlLH2b_4onpGSFD54EXMA> <xme:VmcZZA22LZxxPTqu54cS-xDkXUrZb30xHtGUprzpGuHxh734nL4yAYx1tx6Z-ejuI 9m3tGpSAzt2h9Ktrw> X-ME-Received: <xmr:VmcZZLqJYqLvi64nkbPNUh5mdcUCb-x7J1IanS03In2X0Bf0_ioHSWKFuFEK7J8QTBBQLn2Wa9or9BWCPv80WaBpOw> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvdefledgudduhecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvfevufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhho mhgrshcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqne cuggftrfgrthhtvghrnheptdejieeifeehtdffgfdvleetueeffeehueejgfeuteeftddt ieekgfekudehtdfgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilh hfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: <xmx:VmcZZFksDTRpUYaJED75PuRLpkDnZyInI3bnzNkuQEMkiyRcQonZEA> <xmx:VmcZZD2cw0uRjPT2VIxglaJRTvz7fQzqwQSsFAUO5XB7cu6hZiH7vQ> <xmx:VmcZZEvwym_i59l0pLbb19suTVVzV_KEmx_yJElCmXZhmzeayqiidg> <xmx:VmcZZD8-nc-EwVZyYKoAKxEWVjFWc0SVbEZlYrlRjbUXF0PyUPG0kg> Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 21 Mar 2023 04:14:13 -0400 (EDT) From: Thomas Monjalon <thomas@monjalon.net> To: "Huang, Wei" <wei.huang@intel.com> Cc: "dev@dpdk.org" <dev@dpdk.org>, "david.marchand@redhat.com" <david.marchand@redhat.com>, "stable@dpdk.org" <stable@dpdk.org>, "Xu, Rosen" <rosen.xu@intel.com>, "Zhang, Tianfei" <tianfei.zhang@intel.com>, "Zhang, Qi Z" <qi.z.zhang@intel.com> Subject: Re: [PATCH v1] raw/ifpga: remove virtual device unplug operation Date: Tue, 21 Mar 2023 09:14:11 +0100 Message-ID: <18059490.sWSEgdgrri@thomas> In-Reply-To: <DM6PR11MB3530F55C64732307A7B9F563EF819@DM6PR11MB3530.namprd11.prod.outlook.com> References: <20230316204445.360330-1-wei.huang@intel.com> <6411222.K2JlShyGXD@thomas> <DM6PR11MB3530F55C64732307A7B9F563EF819@DM6PR11MB3530.namprd11.prod.outlook.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org 21/03/2023 01:11, Huang, Wei: > From: Thomas Monjalon <thomas@monjalon.net> > > 16/03/2023 21:44, Wei Huang: > > > VDEV bus has implemented cleanup() function to perform cleanup for > > > devices on the bus during eal_cleanup(), so there is no need for ifpga > > > driver to record virtual devices and unplug them. > > > > Why no need? > > If the application wants to explicitly remove a device, what happens? > > > > > EAL will output an error information "Cannot find plugged device (%s)". It does not look what we expect.