From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id BE2BA4C9F for ; Wed, 3 Apr 2019 00:32:58 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id B4647210FD; Tue, 2 Apr 2019 18:32:57 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Tue, 02 Apr 2019 18:32:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=NUrc/ZKVSf4TW/LFQH5ajQRWRXKrN2d30GjUs4oID0U=; b=ZxW5rKvnvUpV 2v9fK4T3V56qFRWDtnbPUjKg0yLMU6It5PpkuZz1yKpWOhuLPoD3gnMnc5rwvsP1 luMC7XShdYOQQ4CHkZ+oLm2vbcCW08OwqsJBTHruVdwzYgli54HP7ycgsGZVL1Xr lmVxNeZn1P0RtnH1LnCIRxndvdx5/sY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=NUrc/ZKVSf4TW/LFQH5ajQRWRXKrN2d30GjUs4oID 0U=; b=p2qEMCii28Jq9PayvGyKEfeh27abqEnUTir0fBVG4YBBT6O3Gdbu2tgk6 i6H/q6ZeeoQqB5J2ff4JbXTdw2RHFNC2m79BEnMDY7rLtsfiYeQ69qUqoLF2txgS 0u9VK7h6hQ6wpGQ0qRXWX7LjdIQdpwkD5tTV88wNkhW7U3Ci1YHUzoK3f8bqGfLJ nVduH3syeP3NoJ53+Oey+sjchEryZIW+ak+0JuhDUskXX8IUhNKJtf8xaewhb/o2 NZKtR1oaP0ZHMinXW3MhW7E4fFavOnNV20Efhl0j8V58zr+n95lSMDPVHz3lJQgn stLijzHG3lAgxm5DJEFnhdUWmfpCg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrtddugddutdculddtuddrgedutddrtddtmd cutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdp uffrtefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivg hnthhsucdlqddutddtmdenucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvden ucfhrhhomhepvfhhohhmrghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrg hlohhnrdhnvghtqeenucfkphepjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhep mhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsth gvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id C4727E43A3; Tue, 2 Apr 2019 18:32:55 -0400 (EDT) From: Thomas Monjalon To: Anand Rawat Cc: dev@dpdk.org, pallavi.kadam@intel.com, ranjit.menon@intel.com, jeffrey.b.shaw@intel.com, bruce.richardson@intel.com Date: Wed, 03 Apr 2019 00:32:54 +0200 Message-ID: <1807347.878X5vHor5@xps> In-Reply-To: References: <20190306041634.12976-1-anand.rawat@intel.com> <9537388.5AKJxibmNW@xps> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v8 03/10] eal: add new rte_os.h header to build system X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Apr 2019 22:32:59 -0000 03/04/2019 00:11, Anand Rawat: > On 4/2/2019 1:47 PM, Thomas Monjalon wrote: > > 02/04/2019 21:56, Thomas Monjalon: > >> 02/04/2019 05:54, Anand Rawat: > >>> Added rte_os.h files to support OS specific functionality. > >>> Updated build system to contain OS headers in the include > >>> path. > >>> > >>> Signed-off-by: Anand Rawat > >>> Reviewed-by: Pallavi Kadam > >>> --- > >>> --- a/meson.build > >>> +++ b/meson.build > >>> -global_inc = include_directories('.', 'config', 'lib/librte_eal/common/include') > >>> +global_inc = include_directories('.', 'config', > >>> + 'lib/librte_eal/common/include', > >>> + 'lib/librte_eal/@0@/eal/include'.format(host_machine.system())) > >> > >> After having worked on rte_kni_common.h which is only in Linux, > >> I think we should add rte_os.h in meson file of each OS: > >> - lib/librte_eal/linux/eal/meson.build > >> - lib/librte_eal/freebsd/eal/meson.build > >> - lib/librte_eal/windows/eal/meson.build > > > > I confirm: > > "global_inc" is used in "includes" variable but not in "headers" variable, > > so rte_os.h is not installed as other files in "headers". > > We must fill "env_headers" which is pulled by: > > headers = common_headers + env_headers > > > > I will fix it before merging in master if you agree. > > > Agreed, env_headers need to be updated for rte_os.h. > I have tested the same and will incorporating the changes in v9. > Please update this patch with your fix. No need for a v9. Once it will be in master, new changes must be submitted in a separate patch. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id B3515A0679 for ; Wed, 3 Apr 2019 00:33:01 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B00E854AE; Wed, 3 Apr 2019 00:33:00 +0200 (CEST) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id BE2BA4C9F for ; Wed, 3 Apr 2019 00:32:58 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id B4647210FD; Tue, 2 Apr 2019 18:32:57 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Tue, 02 Apr 2019 18:32:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=NUrc/ZKVSf4TW/LFQH5ajQRWRXKrN2d30GjUs4oID0U=; b=ZxW5rKvnvUpV 2v9fK4T3V56qFRWDtnbPUjKg0yLMU6It5PpkuZz1yKpWOhuLPoD3gnMnc5rwvsP1 luMC7XShdYOQQ4CHkZ+oLm2vbcCW08OwqsJBTHruVdwzYgli54HP7ycgsGZVL1Xr lmVxNeZn1P0RtnH1LnCIRxndvdx5/sY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=NUrc/ZKVSf4TW/LFQH5ajQRWRXKrN2d30GjUs4oID 0U=; b=p2qEMCii28Jq9PayvGyKEfeh27abqEnUTir0fBVG4YBBT6O3Gdbu2tgk6 i6H/q6ZeeoQqB5J2ff4JbXTdw2RHFNC2m79BEnMDY7rLtsfiYeQ69qUqoLF2txgS 0u9VK7h6hQ6wpGQ0qRXWX7LjdIQdpwkD5tTV88wNkhW7U3Ci1YHUzoK3f8bqGfLJ nVduH3syeP3NoJ53+Oey+sjchEryZIW+ak+0JuhDUskXX8IUhNKJtf8xaewhb/o2 NZKtR1oaP0ZHMinXW3MhW7E4fFavOnNV20Efhl0j8V58zr+n95lSMDPVHz3lJQgn stLijzHG3lAgxm5DJEFnhdUWmfpCg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrtddugddutdculddtuddrgedutddrtddtmd cutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdp uffrtefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivg hnthhsucdlqddutddtmdenucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvden ucfhrhhomhepvfhhohhmrghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrg hlohhnrdhnvghtqeenucfkphepjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhep mhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsth gvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id C4727E43A3; Tue, 2 Apr 2019 18:32:55 -0400 (EDT) From: Thomas Monjalon To: Anand Rawat Cc: dev@dpdk.org, pallavi.kadam@intel.com, ranjit.menon@intel.com, jeffrey.b.shaw@intel.com, bruce.richardson@intel.com Date: Wed, 03 Apr 2019 00:32:54 +0200 Message-ID: <1807347.878X5vHor5@xps> In-Reply-To: References: <20190306041634.12976-1-anand.rawat@intel.com> <9537388.5AKJxibmNW@xps> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v8 03/10] eal: add new rte_os.h header to build system X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190402223254.YcWZA_ssO-qjzBaQXB7BaOGZTqD8-HfBxUAtgim6Ew0@z> 03/04/2019 00:11, Anand Rawat: > On 4/2/2019 1:47 PM, Thomas Monjalon wrote: > > 02/04/2019 21:56, Thomas Monjalon: > >> 02/04/2019 05:54, Anand Rawat: > >>> Added rte_os.h files to support OS specific functionality. > >>> Updated build system to contain OS headers in the include > >>> path. > >>> > >>> Signed-off-by: Anand Rawat > >>> Reviewed-by: Pallavi Kadam > >>> --- > >>> --- a/meson.build > >>> +++ b/meson.build > >>> -global_inc = include_directories('.', 'config', 'lib/librte_eal/common/include') > >>> +global_inc = include_directories('.', 'config', > >>> + 'lib/librte_eal/common/include', > >>> + 'lib/librte_eal/@0@/eal/include'.format(host_machine.system())) > >> > >> After having worked on rte_kni_common.h which is only in Linux, > >> I think we should add rte_os.h in meson file of each OS: > >> - lib/librte_eal/linux/eal/meson.build > >> - lib/librte_eal/freebsd/eal/meson.build > >> - lib/librte_eal/windows/eal/meson.build > > > > I confirm: > > "global_inc" is used in "includes" variable but not in "headers" variable, > > so rte_os.h is not installed as other files in "headers". > > We must fill "env_headers" which is pulled by: > > headers = common_headers + env_headers > > > > I will fix it before merging in master if you agree. > > > Agreed, env_headers need to be updated for rte_os.h. > I have tested the same and will incorporating the changes in v9. > Please update this patch with your fix. No need for a v9. Once it will be in master, new changes must be submitted in a separate patch.