From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 88833A034D;
	Thu,  6 Jan 2022 10:48:40 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 1AEE2410E6;
	Thu,  6 Jan 2022 10:48:40 +0100 (CET)
Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com
 [64.147.123.20]) by mails.dpdk.org (Postfix) with ESMTP id 490CB40E03
 for <dev@dpdk.org>; Thu,  6 Jan 2022 10:48:38 +0100 (CET)
Received: from compute3.internal (compute3.nyi.internal [10.202.2.43])
 by mailout.west.internal (Postfix) with ESMTP id E1C983201D70;
 Thu,  6 Jan 2022 04:48:35 -0500 (EST)
Received: from mailfrontend1 ([10.202.2.162])
 by compute3.internal (MEProxy); Thu, 06 Jan 2022 04:48:36 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding:content-type; s=fm3; bh=
 X8xLa05rBn5MdjijTgHrmqLs0UtyXygcY44VD60Jo/c=; b=KduyBSWtsnO6pKOe
 Y2idKztXGiqdDb0nfxCRo0dRqBglk4zmn4qNkk3CyhQjyPCr65OR0lejPLB1boXP
 R5hAQfkyWgssdZw0McURAjHhXipDsYxEu3nMQ+0CxjIa2hEYgMV1/e/VcNuHSyew
 bccaFkW0m0gwkZWOkWIsjnh1NRdjk1DXueS5t8CqC0KXen0wvXLeNetuxeT7uBdz
 dUYFAU57NlwOcoAVw/JeDMqQBsVz6obITColPb/JMm3Vph7DgV4ETscKShBXm9Or
 HVJes+vtPSqyynh9KXPbDHVSzcs8iAX8LvKa3Ig/y/A6apI7IjPp99a965DbN2YS
 wklLdQ==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
 :x-sasl-enc; s=fm1; bh=X8xLa05rBn5MdjijTgHrmqLs0UtyXygcY44VD60Jo
 /c=; b=Sr/mISKJxhQQ0fx82lwLeNFHJNRBai+NBRl9OjNKI3Vjz6ZZAKnEAlWDb
 YmWg/kKOgiC8zPlzq47XR4UjGEEfG6wPTeFin6iK04AZFlOBJ4rXgzUotTLogOxD
 5PZWffz4P1qSRtZWyyv6Nt3/dTm6+cGPpzuKPJ+GliIQK+adWEx6DiwONpUOpMR1
 mqoirASlfD93aeFDtCkvc53RKtnydl03IXllXAUv8QLxat2GdPGGSJWU3L/v1T8l
 v7gxiX2AObX+A3VrZ+Wqk1I7Wg79GJ6ytxXCJ9a7A2ZrZGX89h9sDeVmSeBGRndc
 lryTOoHCo7ynzuCVpTUK/qb+dQP1Q==
X-ME-Sender: <xms:8rrWYZngp8_VB1WLAkUnwHkEnRjwpGcj3FfN-HehVQ5iwPd3YUDfLA>
 <xme:8rrWYU0zRkGTBoO4DIJsQ-oTQNjoYUzxiMlz0JzGvotrXJp1js4Oke8skEBv0UScp
 Yk6983SfdCG7MdZEw>
X-ME-Received: <xmr:8rrWYfpdV-WHLdscc_cJHjoVtUqoxgOcyZuZ1Nk8xsGXVNM8GntvJgXnn5ZRYsQJXQP4ITcR2zjDyWbL0nVdZRmIPw>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddrudefledgtdejucetufdoteggodetrfdotf
 fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
 uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
 cujfgurhephffvufffkfgjfhgggfgtsehtqhertddttddunecuhfhrohhmpefvhhhomhgr
 shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg
 ftrfgrthhtvghrnhepfeegffeihfeftedthfdvgfetkeffffdukeevtdevtddvgfevuedu
 veegvdeggedtnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh
 homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth
X-ME-Proxy: <xmx:8rrWYZkL_de6uuSf8rMO8swm6_ia4gx6iyvuleJwbTJ5m7IZMQpioA>
 <xmx:8rrWYX0qeeqaUkspbOy8ZS35jaL96IXVIcxkroCnOwwfHSnjPodQvg>
 <xmx:8rrWYYsB5sPMeiKyF46n_YNK7q3gxRJRzJadPovm2ZYoy7Hah4z-Pg>
 <xmx:87rWYQ-RRtGSRxLyC9mMaQ44gL52wA6oFPpD89R6Q1_kh3Ylwu14WQ>
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu,
 6 Jan 2022 04:48:34 -0500 (EST)
From: Thomas Monjalon <thomas@monjalon.net>
To: Morten =?ISO-8859-1?Q?Br=F8rup?= <mb@smartsharesystems.com>
Cc: Bruce Richardson <bruce.richardson@intel.com>, dev@dpdk.org
Subject: Re: [PATCH 3/3] build: support disabling drivers with meson
Date: Thu, 06 Jan 2022 10:48:32 +0100
Message-ID: <1807554.CQOukoFCf9@thomas>
In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35D86DDF@smartserver.smartshare.dk>
References: <20190925145531.52705-1-bruce.richardson@intel.com>
 <20190925145531.52705-4-bruce.richardson@intel.com>
 <98CBD80474FA8B44BF855DF32C47DC35D86DDF@smartserver.smartshare.dk>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="iso-8859-1"
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

06/01/2022 09:23, Morten Br=F8rup:
> > From: Bruce Richardson [mailto:bruce.richardson@intel.com]
> > Sent: Wednesday, 25 September 2019 16.56
> >=20
> > Add support for a new build option to turn off certain drivers. Any
> > other
> > drivers which depend on the one being disabled will also be disabled
> > with a
> > suitable debug message.
> >=20
> > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
>=20
> Hi Bruce,
>=20
> I was trying something along the lines of:
>=20
> meson configure -Ddisable_drivers=3Dnet/* -Denable_drivers=3Dnet/i40e
>=20
> But it seems that enable_drivers does not override disable_drivers. Ninja=
 says:

It is the opposite logic. "disable" overrides "enable":

        if not enable_drivers.contains(drv_path)
            build =3D false
            reason =3D 'not in enabled drivers build config'
        elif disable_drivers.contains(drv_path)
            if always_enable.contains(drv_path)
                message('Driver @0@ cannot be disabled, not disabling.'.for=
mat(drv_path))
            else
                build =3D false
                reason =3D 'explicitly disabled via build config'
            endif
        endif

In this case, you don't need to disable everything because of this:

if enable_drivers.length() =3D=3D 0
    enable_drivers =3D run_command(list_dir_globs, '*/*', check: true).stdo=
ut().split()
endif