From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Keunhong Lee <dlrmsghd@gmail.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] Bugs in newest patches
Date: Thu, 06 Nov 2014 22:05:26 +0100 [thread overview]
Message-ID: <1808251.0PKkz7l9rY@xps13> (raw)
In-Reply-To: <CAKBXKmBUgTBWvMnQEfE_nms7p9v32edwa2V2oVuwZrx+ZRhPrA@mail.gmail.com>
Hi,
2014-11-07 05:21, Keunhong Lee:
> I just pulled new patches from the master branch, and found that it doesn't
> work with C++.
>
> in lib/librte_eal/common/include/generic/rte_cycles.h
> +#ifdef __cplusplus
> +extern "C" {
> +#endif
It's already included in lib/librte_eal/common/include/arch/x86/rte_cycles.h
which includes lib/librte_eal/common/include/generic/rte_cycles.h.
You shouldn't include the generic header directly.
--
Thomas
next prev parent reply other threads:[~2014-11-06 20:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-06 20:21 Keunhong Lee
2014-11-06 21:05 ` Thomas Monjalon [this message]
2014-11-07 1:26 ` Keunhong Lee
2014-11-07 6:14 ` David Marchand
2014-11-07 6:26 ` [dpdk-dev] [PATCH] eal: fix C++ compilation issue after headers rework David Marchand
2014-11-07 11:21 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1808251.0PKkz7l9rY@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=dlrmsghd@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).