From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 62EFAA034F; Thu, 25 Feb 2021 14:14:54 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 12BC01608A3; Thu, 25 Feb 2021 14:14:54 +0100 (CET) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by mails.dpdk.org (Postfix) with ESMTP id 45E8B16088D for ; Thu, 25 Feb 2021 14:14:53 +0100 (CET) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id C47905C0165; Thu, 25 Feb 2021 08:14:50 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Thu, 25 Feb 2021 08:14:50 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm3; bh= ZlcgWUyrcwAWvmyRSZJDwJ7xv9vuAjFPrI0Zdz1kE4U=; b=BKJb3i5GHc/4/5ir IjzHLqztg8jarxA837oPLNv7npq5KKiOPJYj43cyS1pCXZJ02RZA1ycBAhUD9T6p 1KrKHE7Trz2RrzHLS86uTZpDvqeh21Pr/X4EXneYK6BpetoGz+/Dx8eKfMcq10ug jKcM+b3XD85q5/XYw/Qh30phcWX1qzAst/zx4dOkZjzcc7lQ5MSGr7hWPjvMgauZ 7Tgu7J2oz63FYsh79XFr0x/KGOIrLjC3OZpSGbBm7uErISiXnuXPyPlVxuO1hYFi rOShmGTV8l5Uc+ISlW3P9buXmr8LhythjEm8XWNq9ceP3qQXdmHzln7C8SLo+FSa 2gj9xA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=ZlcgWUyrcwAWvmyRSZJDwJ7xv9vuAjFPrI0Zdz1kE 4U=; b=hZVvPNmL4lf+rd5TEuPztESgYiHfQOkDW+CUDfy8Np/a/n5IS+oiSV7Xo SPVlQsfOX//lRpItTxdYgRsRoh1Vi771XEW5gHlLNd/s2KrGQFyYGdqYHhPGsdOf 2qfPp9uhScCIZ1+YhxaFlbHlRvg4B+dMqSUe+NV8SLUTGAg5/XigmIEEC3PjHJ/R uz/FrgP68xGCt5+slgBFWVkdsBMSoPtgCv23QK/FiNJ9nYPl4Z/JThGpfSxeRun9 WE1HIoqPqcNrpk7yjhSNlQfUjUukBQv6BkuLQ+B2DYt5E07gbHMQmGvZ4ZQem4y1 RUH2KhPOETYeF6CEBUc8+JCzWpBOA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrkeelgdehtdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho nhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 7C9B71080057; Thu, 25 Feb 2021 08:14:49 -0500 (EST) From: Thomas Monjalon To: Bruce Richardson Cc: David Marchand , dev@dpdk.org, ferruh.yigit@intel.com Date: Thu, 25 Feb 2021 14:14:47 +0100 Message-ID: <1808852.sgu2SuoUMR@thomas> In-Reply-To: <20210225120553.GB1546@bricha3-MOBL.ger.corp.intel.com> References: <20210225111457.32540-1-david.marchand@redhat.com> <5625752.shjfW9zSB4@thomas> <20210225120553.GB1546@bricha3-MOBL.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] devtools: catch symbol duplicates in version map X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 25/02/2021 13:05, Bruce Richardson: > On Thu, Feb 25, 2021 at 01:01:10PM +0100, Thomas Monjalon wrote: > > 25/02/2021 12:57, Bruce Richardson: > > > On Thu, Feb 25, 2021 at 12:41:16PM +0100, Thomas Monjalon wrote: > > > > 25/02/2021 12:14, David Marchand: > > > > > Add a check on versioned symbol duplicates in map files. > > > > > > > > > > Signed-off-by: David Marchand > > > > > --- > > > > > This check could be added to buildtools/check-symbols.sh so that > > > > > regular developers catch the issue when building their changes... > > > > > Opinions? > > > > > > > > In general I am against adding developer tools in the build process, > > > > because it could cause more issues for normal users. > > > > > > > Is this really likely to cause issues for normal users? > > > > Yes because some users will have a different shell, > > or other weird setup we don't think about yet. > > > I think it unlikely, but ok. You would be surprised. I'm going to send a fix for running buildtools/check-symbols.sh on busybox. > Now that meson (from version 0.53 onwards) has a "filesystem" module, with > an "exists" function, we can perhaps look to introduce a "developer mode" > build again, based off the presence of the .git folder. Alternatively, we > could make "developer mode" a regular meson option rather than trying to be > too smart about it. [Or combine both and have developer mode option with > "enabled"/"disabled"/"auto-detect" values] Yes, a developer mode is a good idea.