From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wi0-f182.google.com (mail-wi0-f182.google.com
 [209.85.212.182]) by dpdk.org (Postfix) with ESMTP id 8002EC390
 for <dev@dpdk.org>; Mon, 22 Jun 2015 18:55:11 +0200 (CEST)
Received: by wibdq8 with SMTP id dq8so81383515wib.1
 for <dev@dpdk.org>; Mon, 22 Jun 2015 09:55:11 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=EKuJbozRY3S3vtYxezp2uwRlmDWdl8RccSbAwWolrTk=;
 b=F1iFcmlJ3Eh6CwSzTM3dGjEhfsMIjLHxYorFwCp06zTxR23Yf9X+BfmpLMj4zD4rgF
 0WwFZYrflsNe5PlG20T1ASVVFGql50s6d2DU1l3UHh2r4wuI/3KJ4E3Y34V3PaGEQytv
 p/lFs4RWlZsszGk1fWNXdWWj62uIgy8vsifWqCT32E+4eIxAn22lfMkhzJJa42nkZsf5
 9RVAV1ukqYXK2CMuvHNMxtzloGPHkgFXsamfNe5alsPqZ1AeLNMHRw9hIZc4FO0Am8GR
 2lC3T37BqzB8dUEgfY70Pg+j7DDbFlZWjTFn3/YF3HC7mKJcEA3vfi8blbxOrIcohDFN
 pjTw==
X-Gm-Message-State: ALoCoQk+laOJfliOQ7LuthnGGayakLotq2V0meD4TqXsh+PHZroqDJphd9mst0Nj1M5kpX70Lv05
X-Received: by 10.180.75.78 with SMTP id a14mr34528207wiw.68.1434992111412;
 Mon, 22 Jun 2015 09:55:11 -0700 (PDT)
Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136])
 by mx.google.com with ESMTPSA id fx7sm31375070wjb.10.2015.06.22.09.55.10
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Mon, 22 Jun 2015 09:55:10 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Jan Blunck <jblunck@infradead.org>
Date: Mon, 22 Jun 2015 18:54:09 +0200
Message-ID: <1809202.Avhj2kXmbc@xps13>
Organization: 6WIND
User-Agent: KMail/4.14.8 (Linux/4.0.4-2-ARCH; KDE/4.14.8; x86_64; ; )
In-Reply-To: <556C29DF.2050602@6wind.com>
References: <1432895688-1728-1-git-send-email-jblunck@infradead.org>
 <1433151038-630-1-git-send-email-jblunck@infradead.org>
 <556C29DF.2050602@6wind.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] log: Properly reset log_history_size in
	rte_log_dump_history()
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 22 Jun 2015 16:55:11 -0000

2015-06-01 11:46, Olivier MATZ:
> On 06/01/2015 11:30 AM, Jan Blunck wrote:
> > In rte_log_dump_history() the log_history list is reinitialized without
> > resetting the log_history_size. In the next call to rte_log_add_in_history()
> > the log_history_size > RTE_LOG_HISTORY and the code unconditionally tries
> > to remove the first entry:
> > 
> > Program received signal SIGSEGV, Segmentation fault.
> > rte_log_add_in_history (
> >     buf=buf@entry=0x7f02035cd000 "DATAPLANE: 9:dp0s7 link RTM_NEWLINK [dp0s7] <UP,BROADCAST,RUNNING,MULTICAST,LOWER_UP>\nCAST,LOWER_UP>\n", size=size@entry=86)
> >     at /usr/src/packages/BUILD/lib/librte_eal/common/eal_common_log.c:122
> > 
> > Signed-off-by: Jan Blunck <jblunck@infradead.org>
> 
> Acked-by: Olivier Matz <olivier.matz@6wind.com>

Applied, thanks

Note: this is a good example of patch title renaming.
As it is a fix, it should start with "fix".
And in general, function name is not a good candidate for a short title.
It becomes:
	log: fix crash after dump
shorter and clearer ;)