From: Thomas Monjalon <thomas@monjalon.net>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: Xiaoyun Li <xiaoyun.li@intel.com>,
beilei.xing@intel.com, qi.z.zhang@intel.com, dev@dpdk.org,
zhiyong.yang@intel.com,
Bruce Richardson <bruce.richardson@intel.com>
Subject: Re: [dpdk-dev] [PATCH v6] net/i40e: add interface to use latest vec path
Date: Mon, 17 Sep 2018 16:37:20 +0200 [thread overview]
Message-ID: <1809280.mxVWNlHP3Y@xps> (raw)
In-Reply-To: <5f583daf-cd66-e675-667f-dc7dabbae97b@intel.com>
17/09/2018 16:14, Ferruh Yigit:
> On 9/17/2018 10:58 AM, Xiaoyun Li wrote:
> > @@ -1078,6 +1078,9 @@ struct i40e_adapter {
> > uint64_t pctypes_tbl[I40E_FLOW_TYPE_MAX] __rte_cache_min_aligned;
> > uint64_t flow_types_mask;
> > uint64_t pctypes_mask;
> > +
> > + /* For devargs */
> > + bool use_latest_vec;
>
> For this one checkpatch is giving following warning:
>
> CHECK:BOOL_MEMBER: Avoid using bool structure members because of possible
> alignment issues - see: https://lkml.org/lkml/2017/11/21/384
>
> The comment in the link seems valid. What do you think using a basic storage
> type for the variable, like uint8_t?
>
>
> And overall is there any objection to follow this new convention?
I agree with avoiding bool in structs.
next prev parent reply other threads:[~2018-09-17 14:37 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-30 2:16 [dpdk-dev] [PATCH] net/i40e: add interface to choose latest vector path Xiaoyun Li
2018-08-31 11:24 ` [dpdk-dev] [PATCH v2] " Xiaoyun Li
2018-09-04 11:39 ` [dpdk-dev] [PATCH v3] " Xiaoyun Li
2018-09-05 12:21 ` Zhang, Qi Z
2018-09-07 9:23 ` Li, Xiaoyun
2018-09-10 10:17 ` [dpdk-dev] [PATCH v4] " Xiaoyun Li
2018-09-12 7:45 ` Zhang, Qi Z
2018-09-12 7:50 ` Zhang, Qi Z
2018-09-12 10:12 ` [dpdk-dev] [PATCH v5] " Xiaoyun Li
2018-09-13 1:38 ` Zhang, Qi Z
2018-09-13 13:27 ` Ferruh Yigit
2018-09-17 7:12 ` Li, Xiaoyun
2018-09-17 9:58 ` [dpdk-dev] [PATCH v6] net/i40e: add interface to use latest vec path Xiaoyun Li
2018-09-17 14:14 ` Ferruh Yigit
2018-09-17 14:37 ` Thomas Monjalon [this message]
2018-09-18 1:28 ` Li, Xiaoyun
2018-09-18 2:22 ` [dpdk-dev] [PATCH v7] " Xiaoyun Li
2018-09-18 13:01 ` Ferruh Yigit
2018-09-18 13:52 ` Zhang, Qi Z
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1809280.mxVWNlHP3Y@xps \
--to=thomas@monjalon.net \
--cc=beilei.xing@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=qi.z.zhang@intel.com \
--cc=xiaoyun.li@intel.com \
--cc=zhiyong.yang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).