From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) by dpdk.org (Postfix) with ESMTP id 1BB0D1B069 for ; Mon, 17 Sep 2018 16:37:25 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 97E684A3; Mon, 17 Sep 2018 10:37:23 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Mon, 17 Sep 2018 10:37:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=Ala/5sXneDeEXguLQ4fGXaClWf NyAcNCkLnOWTv32PM=; b=Sspay8Oaid7FAiBUA+rgM8GJdDA41leKjf5xwsrDjm yV/oRpDswQ+ZZ0RB2NFfTItR6MooGth2vFYR2HGKHIViW0seJCkMRWzcSWFuRzWg XvUF+Y+TzyEkwZuXcvpC8n83FWyjVxBCkdle+B6cQK/9tm6L5Utq3SOblN+U2wqG g= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=Ala/5s XneDeEXguLQ4fGXaClWfNyAcNCkLnOWTv32PM=; b=WKhMvs+6U1tjo2EvoudFZZ EPisJzklBv/ls06bdwIiwj1ed7WN9a0/j0MYZq03nWoTOnKoru50Qw7LRSvM6oaY lWWwB3qnhfmCvdLLaQShmBmp2zSzHVQX9p1oJhZzW4aAlR+1oVZp9l1fbKUics4m 0yvhv6+eR53kkUoqUtx6TwfpC4+ShDCAyKi2xhTv7oYjxUheXVg23cQiv6xrGIWi RnLhESaxOHKqFBYlmpXBW/KJVHeDIrbGe69kNQuigd6dDCmWNAOKfqfUPx26JmmI AKbAGKY90mpQGOHW3Jhw0sjCpyK+a0OaX3tS33gafrZC5/yATO7q74jt4kWXXsNw == X-ME-Proxy: X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id E4CC4102A0; Mon, 17 Sep 2018 10:37:21 -0400 (EDT) From: Thomas Monjalon To: Ferruh Yigit Cc: Xiaoyun Li , beilei.xing@intel.com, qi.z.zhang@intel.com, dev@dpdk.org, zhiyong.yang@intel.com, Bruce Richardson Date: Mon, 17 Sep 2018 16:37:20 +0200 Message-ID: <1809280.mxVWNlHP3Y@xps> In-Reply-To: <5f583daf-cd66-e675-667f-dc7dabbae97b@intel.com> References: <1535595399-430873-1-git-send-email-xiaoyun.li@intel.com> <20180917095807.14421-1-xiaoyun.li@intel.com> <5f583daf-cd66-e675-667f-dc7dabbae97b@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v6] net/i40e: add interface to use latest vec path X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Sep 2018 14:37:25 -0000 17/09/2018 16:14, Ferruh Yigit: > On 9/17/2018 10:58 AM, Xiaoyun Li wrote: > > @@ -1078,6 +1078,9 @@ struct i40e_adapter { > > uint64_t pctypes_tbl[I40E_FLOW_TYPE_MAX] __rte_cache_min_aligned; > > uint64_t flow_types_mask; > > uint64_t pctypes_mask; > > + > > + /* For devargs */ > > + bool use_latest_vec; > > For this one checkpatch is giving following warning: > > CHECK:BOOL_MEMBER: Avoid using bool structure members because of possible > alignment issues - see: https://lkml.org/lkml/2017/11/21/384 > > The comment in the link seems valid. What do you think using a basic storage > type for the variable, like uint8_t? > > > And overall is there any objection to follow this new convention? I agree with avoiding bool in structs.