Re: [dpdk-dev] [PATCH v2] ixgbe: fix segmentation fault when start secondary process

[Thomas Monjalon <thomas.monjalon@6wind.com>]

2014-12-19 09:28, Thomas Monjalon:
> 2014-12-19 14:59, Michael Qiu:
> > EAL:   probe driver: 8086:10fb rte_ixgbe_pmd
> > EAL:   PCI memory mapped at 0x7f18c2a00000
> > EAL:   PCI memory mapped at 0x7f18c2a80000
> > Segmentation fault (core dumped)
> > 
> > This is introduced by commit: 46bc9d75
> > 	ixgbe: fix multi-process support
> > When start primary process with command line:
> > ./app/test/test -n 1 -c ffff -m 64
> > then start the second one:
> > ./app/test/test -n 1 --proc-type=secondary --file-prefix=rte
> > This segment-fault will occur.
> > 
> > Root cause is test app on primary process only starts device, but
> > the queue need initialized by manually command line.
> > So the tx queue is still NULL when secondary process startup.
> > 
> > Reported-by: Yong Liu <yong.liu@intel.com>
> > Signed-off-by: Michael Qiu <michael.qiu@intel.com>
> > ---
> > v2 --> v1:
> > 	Log clean up
> 
> Clean-up failed: no need of \n in PMD_INIT_LOG ;)
> 
> > +			PMD_INIT_LOG(INFO, "No TX queues configured yet. "
> > +					   "Using default TX function\n");

Applied with above change. 

Thanks
-- 
Thomas