From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f54.google.com (mail-wg0-f54.google.com [74.125.82.54]) by dpdk.org (Postfix) with ESMTP id 600C058E4 for ; Fri, 19 Dec 2014 23:41:00 +0100 (CET) Received: by mail-wg0-f54.google.com with SMTP id l2so2494833wgh.27 for ; Fri, 19 Dec 2014 14:41:00 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=Yb/xKmJCRHW3i9S45AiZZBrrhjac5HikT3h7peNJlEQ=; b=Bif+TslwJeEW8WVmMQR1iiCBr4Foz+hmUni8VTgIud5ITW/bPhhi86dKbD89jyriNH DUivfYMN7et5VK1Cf1HO0YRM6LnAngPdYGIwFK+87WIZBv13S1YsKRiltGA1z3wSAU8f lawDNuT+VRANrNFGr3kI2cCE0Y5bG5j5rGWWciDyzAsCmzvs1OqGQWprLPHqd0fIfnQV FV5z12ce1laxTLEz4g2TPWsfDUXI/Z92LlBOqRXVTqSV3a9b1bMFqKigN8NqnB6ZQqJI bJz0ZHeRafZxVK6VmpN/+NZzGGHik5YmE8Rz2H+tvT2qwxZVzAEFiZ0uwB04qTJMu+cF BRbA== X-Gm-Message-State: ALoCoQliuijipChQNYqYtSyBR3EYrIX3NNlDwxmdtG+U0uuk/13K1ZON3Ppk6Po+gGdi35Io9O9X X-Received: by 10.180.20.242 with SMTP id q18mr9637406wie.80.1419028860188; Fri, 19 Dec 2014 14:41:00 -0800 (PST) Received: from xps13.localnet (117.114.118.80.rev.sfr.net. [80.118.114.117]) by mx.google.com with ESMTPSA id cq1sm13606157wjc.33.2014.12.19.14.40.58 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 19 Dec 2014 14:40:59 -0800 (PST) From: Thomas Monjalon To: Michael Qiu Date: Fri, 19 Dec 2014 23:40:33 +0100 Message-ID: <1810907.O11zm5mpBE@xps13> Organization: 6WIND User-Agent: KMail/4.14.3 (Linux/3.17.4-1-ARCH; KDE/4.14.3; x86_64; ; ) In-Reply-To: <13515017.Dz1pkeJq4x@xps13> References: <1418897809-14674-1-git-send-email-michael.qiu@intel.com> <1418972358-17130-1-git-send-email-michael.qiu@intel.com> <13515017.Dz1pkeJq4x@xps13> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2] ixgbe: fix segmentation fault when start secondary process X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Dec 2014 22:41:00 -0000 2014-12-19 09:28, Thomas Monjalon: > 2014-12-19 14:59, Michael Qiu: > > EAL: probe driver: 8086:10fb rte_ixgbe_pmd > > EAL: PCI memory mapped at 0x7f18c2a00000 > > EAL: PCI memory mapped at 0x7f18c2a80000 > > Segmentation fault (core dumped) > > > > This is introduced by commit: 46bc9d75 > > ixgbe: fix multi-process support > > When start primary process with command line: > > ./app/test/test -n 1 -c ffff -m 64 > > then start the second one: > > ./app/test/test -n 1 --proc-type=secondary --file-prefix=rte > > This segment-fault will occur. > > > > Root cause is test app on primary process only starts device, but > > the queue need initialized by manually command line. > > So the tx queue is still NULL when secondary process startup. > > > > Reported-by: Yong Liu > > Signed-off-by: Michael Qiu > > --- > > v2 --> v1: > > Log clean up > > Clean-up failed: no need of \n in PMD_INIT_LOG ;) > > > + PMD_INIT_LOG(INFO, "No TX queues configured yet. " > > + "Using default TX function\n"); Applied with above change. Thanks -- Thomas