This patch changes MAC_TYPE_FILTER_SUP to MAC_TYPE_FILTER_SUP_EXT in flex filter handling function. It will remove NIC 82576 from flex filter support. Signed-off-by: Jingjing Wu <jingjing.wu@intel.com> --- lib/librte_pmd_e1000/igb_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_pmd_e1000/igb_ethdev.c b/lib/librte_pmd_e1000/igb_ethdev.c index 49843c1..79ad267 100644 --- a/lib/librte_pmd_e1000/igb_ethdev.c +++ b/lib/librte_pmd_e1000/igb_ethdev.c @@ -2908,7 +2908,7 @@ eth_igb_flex_filter_handle(struct rte_eth_dev *dev, struct rte_eth_flex_filter *filter; int ret = 0; - MAC_TYPE_FILTER_SUP(hw->mac.type); + MAC_TYPE_FILTER_SUP_EXT(hw->mac.type); if (filter_op == RTE_ETH_FILTER_NOP) return ret; -- 1.9.3
> -----Original Message-----
> From: Wu, Jingjing
> Sent: Thursday, March 26, 2015 12:53 PM
> To: dev@dpdk.org
> Cc: Wu, Jingjing; Liu, Yong
> Subject: [PATCH] e1000: modify mac type checking before flex filter is
> programmed
>
> This patch changes MAC_TYPE_FILTER_SUP to MAC_TYPE_FILTER_SUP_EXT in
> flex filter handling function. It will remove NIC 82576 from flex filter
> support.
>
> Signed-off-by: Jingjing Wu <jingjing.wu@intel.com>
> ---
> lib/librte_pmd_e1000/igb_ethdev.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/librte_pmd_e1000/igb_ethdev.c
> b/lib/librte_pmd_e1000/igb_ethdev.c
> index 49843c1..79ad267 100644
> --- a/lib/librte_pmd_e1000/igb_ethdev.c
> +++ b/lib/librte_pmd_e1000/igb_ethdev.c
> @@ -2908,7 +2908,7 @@ eth_igb_flex_filter_handle(struct rte_eth_dev *dev,
> struct rte_eth_flex_filter *filter;
> int ret = 0;
>
> - MAC_TYPE_FILTER_SUP(hw->mac.type);
> + MAC_TYPE_FILTER_SUP_EXT(hw->mac.type);
>
> if (filter_op == RTE_ETH_FILTER_NOP)
> return ret;
> --
> 1.9.3
Acked-by: Marvin Liu <yong.liu@intel.com>
2015-03-26 12:53, Jingjing Wu:
> This patch changes MAC_TYPE_FILTER_SUP to MAC_TYPE_FILTER_SUP_EXT in
> flex filter handling function. It will remove NIC 82576 from flex filter
> support.
Please, could you explain the goal of this change?
Is it a fix? an enhancement? Which behaviour is changed?
Hi,
It's a fix. Because we don't support flex filter in NIC 82576 in current e1000 pmd, So add a check here. Only i350 and 82580 support it. So The MAC_TYPE_FILTER_SUP_EXT is used to check whether the MAC type is i350 or 82580.
> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> Sent: Thursday, March 26, 2015 12:50 AM
> To: Wu, Jingjing
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] e1000: modify mac type checking before flex filter is
> programmed
>
> 2015-03-26 12:53, Jingjing Wu:
> > This patch changes MAC_TYPE_FILTER_SUP to MAC_TYPE_FILTER_SUP_EXT in
> > flex filter handling function. It will remove NIC 82576 from flex filter
> > support.
>
> Please, could you explain the goal of this change?
> Is it a fix? an enhancement? Which behaviour is changed?
2015-03-26 05:08, Liu, Yong:
> From: Wu, Jingjing
> > This patch changes MAC_TYPE_FILTER_SUP to MAC_TYPE_FILTER_SUP_EXT in
> > flex filter handling function. It will remove NIC 82576 from flex filter
> > support.
> >
> > Signed-off-by: Jingjing Wu <jingjing.wu@intel.com>
>
> Acked-by: Marvin Liu <yong.liu@intel.com>
Fixes: 231d43909a31 ("igb: migrate flex filter to new API")
Applied, thanks