From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 79329A059F;
	Fri, 10 Apr 2020 14:27:39 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 2C9B91D521;
	Fri, 10 Apr 2020 14:27:39 +0200 (CEST)
Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com
 [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id CDE501D51E
 for <dev@dpdk.org>; Fri, 10 Apr 2020 14:27:37 +0200 (CEST)
Received: from compute7.internal (compute7.nyi.internal [10.202.2.47])
 by mailout.nyi.internal (Postfix) with ESMTP id AE8555C0246;
 Fri, 10 Apr 2020 08:27:34 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
 by compute7.internal (MEProxy); Fri, 10 Apr 2020 08:27:34 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding:content-type; s=mesmtp;
 bh=KmzhR6kjvy8WdYQcqCNEaRvVw4tLZA1A5CKRsgEmz0c=; b=Rqd7GTp6CLTl
 FRqe9JiDc13IZ6bgqLTBPXjTVsi1mJXqTXPaVzkpzPfxJuZaRnrosxlvuWk88hV6
 N4kFQPzLZC2nx3rhxUSG5/hA/Cze8naSN+80Z0MLPjCAQSXSXNrRHTlG25TqueVI
 ayijdv4olXDNS6qX1cKSh7GtqVIvFsw=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
 :x-sasl-enc; s=fm2; bh=KmzhR6kjvy8WdYQcqCNEaRvVw4tLZA1A5CKRsgEmz
 0c=; b=Xfo/4tE4GrivvoZUSdgQn8bmha8Cqx0hd9HE9Mj9xeW3T2ztFoQM7ydaZ
 j4sxsTLEjHs8fGEYQZYvhabj6j84kwzDlEsLNbXsPP8DMdJNLr+r/yLUPVPfCXco
 f3tX9/WkdUoBC3aR6iSmp+uW9HH38WD3WBCAiQjrQE6nhnlGPYCgci5COju+R3pF
 JmliO9BUWFElG0GQz3+DQ1nIgAiNn2IVrCuwDn+CjgqgNLPqBGRUfT3mhA/RtabI
 XcWBwQc5+Ou3d3Zf4mQPirM4idhG0CTyJdbkvxL9HOb3CNXMlZPpsMPMCRCQGw6d
 Ab95nZlLYslTr4oXnkTo6tTE+AW8Q==
X-ME-Sender: <xms:NWaQXuP-04Jpt7w7KW1mz2giSMwegbwxfCOPLcPP5SmSd7o0ubFCRw>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrvddvgdehvdcutefuodetggdotefrodftvf
 curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu
 uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc
 fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs
 ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph
 epjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuihiivgeptdenucfrrghr
 rghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth
X-ME-Proxy: <xmx:NWaQXh4uFAw2622iskOtRmXH3JagjVF8B2VtFHhhapu2NUWtLOGM8g>
 <xmx:NWaQXpjGLk83O43jVUFn2CUAPlwkSvkfojtJvjy0tCSI0HAoG-V5cA>
 <xmx:NWaQXufUGLPpSTnDjG1UXtDIRK0_jfi_-7G29FmVtKOU4E9Dw2BAMQ>
 <xmx:NmaQXjeAuNz8NKUhUbNs8r7mWktYFOGFGwuurHGOE5dj-3Hwx-ERoA>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
 by mail.messagingengine.com (Postfix) with ESMTPA id 1287D328005D;
 Fri, 10 Apr 2020 08:27:32 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org, Lukasz Wojciechowski <l.wojciechow@partner.samsung.com>,
 Aaron Conole <aconole@redhat.com>, Ruifeng Wang <ruifeng.wang@arm.com>,
 David Marchand <david.marchand@redhat.com>, Gavin Hu <gavin.hu@arm.com>
Date: Fri, 10 Apr 2020 14:27:30 +0200
Message-ID: <1813726.1xdlsreqCQ@thomas>
In-Reply-To: <20200410104219.GE625@bricha3-MOBL.ger.corp.intel.com>
References: <20200409180332.592074-1-thomas@monjalon.net>
 <20200410102951.1398001-1-thomas@monjalon.net>
 <20200410104219.GE625@bricha3-MOBL.ger.corp.intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH v3] test: remove meson dependency on /proc
	file
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

10/04/2020 12:42, Bruce Richardson:
> On Fri, Apr 10, 2020 at 12:29:50PM +0200, Thomas Monjalon wrote:
> > --- a/app/test/meson.build
> > +++ b/app/test/meson.build
> >  has_hugepage = true
> >  if is_linux
> 
> Since you check for linux in the script, you can drop these two lines,

The issue is for Windows.
I am not sure how we will skip shell scripts
when adding Windows support for this application.
So there are two options now:
	a) remove Linux check before calling the script and ignore Windows support for now
	b) keep Linux check without knowing whether it will be useful for Windows support

We vote a?