From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f45.google.com (mail-wg0-f45.google.com [74.125.82.45]) by dpdk.org (Postfix) with ESMTP id 58DFA2E8F for ; Thu, 29 May 2014 11:59:07 +0200 (CEST) Received: by mail-wg0-f45.google.com with SMTP id m15so122213wgh.4 for ; Thu, 29 May 2014 02:59:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=4wrpyATd1Vrp3xqJSGABvshVAY3hQhCMLXo/DQTnaM0=; b=Km6+NBGGqm62pQ5KfXh7db3w6WZLXVgl/pRvkFFwTRkPoXRIbLQta8G4vjKTEbGIaf IygbJEcMR/iYMI23Ear7Dj0Xe0raL99UcP+sIYcCYds6ert6puvKb0d4UCbDmsqQflRR RZd7IgI/kITqJ8Un8/Aec5mWtLiTK9jv3DkJ2XNqMFKFcH1z9PjV9ZzBB8dJD3d+e9em VV3EGozjUxalViOkmCPu61Za46HdW33tBfsX5EOKUGNN3MTimBXHxwR1cZ54ModNjilv /BJiEr9zD5N2hMAeHRrYA9DLZUMm7vJJlNUqLWKL0zm59/CkaRpfCYwA3WTuPHaqOIvc PRaA== X-Gm-Message-State: ALoCoQnixnf0Ha4WdR7/PdyQZspn5DKyB5aI+c/smsGBqkEVz1UsbT7S0hEDKJ7a1gMihAjD+8VJ X-Received: by 10.194.79.36 with SMTP id g4mr8445243wjx.71.1401357558400; Thu, 29 May 2014 02:59:18 -0700 (PDT) Received: from xps13.localnet (108.26.90.92.rev.sfr.net. [92.90.26.108]) by mx.google.com with ESMTPSA id ej4sm14044892wib.4.2014.05.29.02.58.59 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 29 May 2014 02:59:17 -0700 (PDT) From: Thomas Monjalon To: "Liu, Jijiang" Date: Thu, 29 May 2014 11:58:51 +0200 Message-ID: <1815026.ZOX21DlnhJ@xps13> Organization: 6WIND User-Agent: KMail/4.13 (Linux/3.14.4-1-ARCH; KDE/4.13.0; x86_64; ; ) In-Reply-To: <1ED644BD7E0A5F4091CF203DAFB8E4CC01C77421@SHSMSX101.ccr.corp.intel.com> References: <1ED644BD7E0A5F4091CF203DAFB8E4CC01C77421@SHSMSX101.ccr.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org, "SMonderer@advaoptical.com" , "xen-devel@lists.xen.org" Subject: Re: [dpdk-dev] could not l2fwd in DOM0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 May 2014 09:59:07 -0000 Jijiang, I'm not sure to understand. Could you send a proper patch for this issue? Thanks -- Thomas 2014-05-17 07:48, Liu, Jijiang: > In Linux kernel versions < 3.14 , the vstart is kernel virtual address, the > API prototype below. int xen_create_contiguous_region(unsigned long vstart, > unsigned int order, unsigned int address_bits) > > In Linux kernel 3.14, the pstart is kernel physical address, the API > prototype below. int xen_create_contiguous_region(phys_addr_t pstart, > unsigned int order, unsigned int address_bits, > dma_addr_t *dma_handle) > > ,so the mm_data->block_info[i].vir_addr cannot pass to > xen_create_contiguous_region() directly for Linux kernel 3.14, the pstart > should be mm_data->block_info[i].pfn * PAGE_SIZE in the Dom0 Driver. > > #include > #include > #include > > #include > #include > @@ -309,6 +310,7 @@ dom0_prepare_memsegs(struct memory_info* meminfo, struct > dom0_mm_data uint64_t pfn, vstart, vaddr; > uint32_t i, num_block, size; > int idx; > + dma_addr_t dma_handle; > > /* Allocate 2M memory once */ > num_block = meminfo->size / 2; > @@ -344,7 +346,7 @@ dom0_prepare_memsegs(struct memory_info* meminfo, struct > dom0_mm_data * contiguous physical addresses, its maximum size is 2M. */ > if (xen_create_contiguous_region(mm_data->block_info[i].pfn > * PAGE_SIZE, - DOM0_CONTIG_NUM_ORDER, 0) > == 0) { + DOM0_CONTIG_NUM_ORDER, 0, > + &dma_handle) == 0) { > mm_data->block_info[i].exchange_flag = 1; > mm_data->block_info[i].mfn = > pfn_to_mfn(mm_data->block_info[i].pfn); > > Thanks > Frank Liu > > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Samuel Monderer > Sent: Wednesday, May 07, 2014 8:44 PM > To: Liu, Jijiang > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] could not l2fwd in DOM0 > > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Liu, Jijiang > > Sent: Wednesday, May 07, 2014 7:36 AM > > To: dev@dpdk.org > > Subject: Re: [dpdk-dev] could not l2fwd in DOM0 > > > > Hi, > > > > I have checked source codes of xen_create_contiguous_region function > > in kernel 3.14, and found the dma_handle cannot be NULL. > > > > int xen_create_contiguous_region(phys_addr_t pstart, unsigned int order, > > > > unsigned int address_bits, > > dma_addr_t *dma_handle) { > > > > unsigned long *in_frames = discontig_frames, out_frame; > > unsigned long flags; > > int success; > > unsigned long vstart = (unsigned long)phys_to_virt(pstart); > > > > ... > > > > *dma_handle = virt_to_machine(vstart).maddr; > > return success ? 0 : -ENOMEM; > > > > } > > > > Thanks > > Frank Liu > > Thanks Frank, > > I've changed the code as following but now the kernel module crashes. > > diff --git a/lib/librte_eal/linuxapp/xen_dom0/dom0_mm_misc.c > b/lib/librte_eal/linuxapp/xen index 87fa3e6..8addc21 100644 > --- a/lib/librte_eal/linuxapp/xen_dom0/dom0_mm_misc.c > +++ b/lib/librte_eal/linuxapp/xen_dom0/dom0_mm_misc.c > @@ -64,6 +64,7 @@ > #include > #include > #include > > #include > #include > @@ -309,6 +310,7 @@ dom0_prepare_memsegs(struct memory_info* meminfo, struct > dom0_mm_data uint64_t pfn, vstart, vaddr; > uint32_t i, num_block, size; > int idx; > + dma_addr_t dma_handle; > > /* Allocate 2M memory once */ > num_block = meminfo->size / 2; > @@ -344,7 +346,7 @@ dom0_prepare_memsegs(struct memory_info* meminfo, struct > dom0_mm_data * contiguous physical addresses, its maximum size is 2M. */ > if > (xen_create_contiguous_region(mm_data->block_info[i].vir_addr, > - DOM0_CONTIG_NUM_ORDER, 0) == 0) { > + DOM0_CONTIG_NUM_ORDER, 0, > + &dma_handle) == 0) { > mm_data->block_info[i].exchange_flag = 1; > mm_data->block_info[i].mfn = > pfn_to_mfn(mm_data->block_info[i].pfn); > > Samuel > > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Samuel Monderer > > Sent: Wednesday, April 30, 2014 1:54 AM > > To: dev@dpdk.org > > Cc: Shimon Zadok > > Subject: [dpdk-dev] could not l2fwd in DOM0 > > > > Hi, > > > > First I've encountered a compiling problem when compiling for DOM0 due > > to prototype change of the function xen_create_contiguous_region I > > made the following changes: > > > > diff --git a/lib/librte_eal/linuxapp/xen_dom0/dom0_mm_misc.c > > b/lib/librte_eal/linuxapp/xen index 87fa3e6..8addc21 100644 > > --- a/lib/librte_eal/linuxapp/xen_dom0/dom0_mm_misc.c > > +++ b/lib/librte_eal/linuxapp/xen_dom0/dom0_mm_misc.c > > @@ -64,6 +64,7 @@ > > > > #include > > #include > > #include > > > > +//#include > > > > #include > > #include > > > > @@ -309,6 +310,7 @@ dom0_prepare_memsegs(struct memory_info* meminfo, > > struct dom0_mm_data > > > > uint64_t pfn, vstart, vaddr; > > uint32_t i, num_block, size; > > int idx; > > > > + dma_addr_t *dma_handle = NULL; > > > > /* Allocate 2M memory once */ > > num_block = meminfo->size / 2; @@ -344,7 +346,7 @@ > > > > dom0_prepare_memsegs(struct memory_info* meminfo, struct dom0_mm_data > > > > * contiguous physical addresses, its maximum size is 2M. > > */ > > > > if > > (xen_create_contiguous_region(mm_data->block_info[i].vir_ > > addr, > > > > - DOM0_CONTIG_NUM_ORDER, 0) == 0) { > > + DOM0_CONTIG_NUM_ORDER, 0, > > + dma_handle) == 0) { > > > > mm_data->block_info[i].exchange_flag = 1; > > mm_data->block_info[i].mfn = > > > > pfn_to_mfn(mm_data->block_info[i].pfn); > > > > After that I tried to run l2fwd example and got a segmentation fault > > > > root@Smart:~/samuelm/dpdk/dpdk# modprobe uio > > root@Smart:~/samuelm/dpdk/dpdk# insmod ./x86_64-default-linuxapp- > > gcc/kmod/igb_uio.ko root@Smart:~/samuelm/dpdk/dpdk# insmod > > ./x86_64-default-linuxapp- gcc/kmod/rte_dom0_mm.ko > > root@Smart:~/samuelm/dpdk/dpdk# cd examples/l2fwd/build/ > > root@Smart:~/samuelm/dpdk/dpdk/examples/l2fwd/build# echo 2048 > > > /sys/kernel/mm/dom0-mm/memsize-mB/memsize > > root@Smart:~/samuelm/dpdk/dpdk/examples/l2fwd/build# ./l2fwd -c 3 -n 4 > > --xen-dom0 -- -q 1 -p 3 > > EAL: Detected lcore 0 as core 0 on socket 0 > > EAL: Detected lcore 1 as core 0 on socket 0 > > EAL: Setting up memory... > > Segmentation fault > > root@Smart:~/samuelm/dpdk/dpdk/examples/l2fwd/build# > > > > Has anyone already encountered this problem? > > > > Samuelm