From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <thomas.monjalon@6wind.com> Received: from mail-wi0-f180.google.com (mail-wi0-f180.google.com [209.85.212.180]) by dpdk.org (Postfix) with ESMTP id 344CBB62 for <dev@dpdk.org>; Mon, 27 Apr 2015 18:09:38 +0200 (CEST) Received: by wiun10 with SMTP id n10so95810219wiu.1 for <dev@dpdk.org>; Mon, 27 Apr 2015 09:09:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=rrFQQmRIJV+wMfZ8cpdZSmWrJGNFTRADMuriad3VwYw=; b=kZKlDr4qwiZnQH/1IV2MOs38bdMtgyYtpADTTRzuqSEj5cn0LbAAXyVgLYmmOdMbYX Vumm+ERxO+0PzWtKb1D3gEulFxIyontjZ40I9EwgZ8Mz3EDZQZqNKOrJwd3gQkBXl3hU /N5/N/KUpGei/+ODS+qziJQPntHEBeBf6jwFWLDyeIjHir7+tj6AIbViUiWwaJPP98Sp KOnL8StQJQwkgyKVeLCi+IR0umD4MxW9wrIn1n6euukR+D2aFbHghN/NsyyNgBFGojvm UN63y/VWz/fy3UaRa0+aFp7w2BbsRjCZ7+YqHp4tlh2BfyPg07p8Mip+XMGubUXViHiZ iNsQ== X-Gm-Message-State: ALoCoQn9I3IndHWfW9RNGRZ/tEsKGzW64hwRIaPClxXGY6YoQXcVNnf5Nku10TIS/5wiZhvzwi2P X-Received: by 10.180.101.3 with SMTP id fc3mr2625463wib.47.1430150978056; Mon, 27 Apr 2015 09:09:38 -0700 (PDT) Received: from xps13.localnet (6wind.net2.nerim.net. [213.41.180.237]) by mx.google.com with ESMTPSA id pm1sm11747422wjb.23.2015.04.27.09.09.36 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 27 Apr 2015 09:09:37 -0700 (PDT) From: Thomas Monjalon <thomas.monjalon@6wind.com> To: Venky Venkatesan <venky.venkatesan@intel.com>, Neil Horman <nhorman@tuxdriver.com> Date: Mon, 27 Apr 2015 18:08:55 +0200 Message-ID: <1815538.YzHUjUMMD8@xps13> Organization: 6WIND User-Agent: KMail/4.14.4 (Linux/3.18.4-1-ARCH; KDE/4.14.4; x86_64; ; ) In-Reply-To: <55352D47.8010906@intel.com> References: <1429539103-15885-1-git-send-email-thomas.monjalon@6wind.com> <20150420163348.GA19573@hmsreliant.think-freely.org> <55352D47.8010906@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [RFC PATCH] ethdev: remove old flow director API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Mon, 27 Apr 2015 16:09:38 -0000 2015-04-20 09:45, Venky Venkatesan: > On 04/20/2015 09:33 AM, Neil Horman wrote: > > On Mon, Apr 20, 2015 at 04:11:43PM +0200, Thomas Monjalon wrote: > >> It's time to remove this old API. > >> It seems some work is still needed to rely only on eth_ctrl API. > >> At least ixgbe, i40e and testpmd must be fixed. > >> Jingjing, do you think it's possible to remove all these structures > >> from rte_ethdev.h? > >> > >> Thanks > >> > > NAK. > > > > I'm certainly not opposed to removing the API's if they are truly no longer > > needed. But they have been codified as part of the ABI, so the deprecation > > schedule needs to be followed. Given what you've said above, it seems like that > > might be worthwhile anyway, as it will provide the needed runway to allow users > > to convert to the new API. > > > > Neil > +1 NAK. Agree with Neil. +1 Agree with you :) The goal of this RFC proposal is to see how to progress on API cleanup. There are actually 2 parts: 1/ The flow director functions of rte_ethdev.h were only used for enic in DPDK 2.0. We could set a deprecation notice to remove them in DPDK 2.2. 2/ Some associated structures are also used for rte_eth_conf. My question was to check how it would be relevant to remove this rte_fdir_conf.