From: Thomas Monjalon <thomas@monjalon.net>
To: Ferruh Yigit <ferruh.yigit@intel.com>, oulijun <oulijun@huawei.com>
Cc: dev@dpdk.org, linuxarm@openeuler.org,
Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>
Subject: Re: [dpdk-dev] [PATCH 1/3] doc: add FEC in NIC features
Date: Thu, 28 Jan 2021 10:14:01 +0100 [thread overview]
Message-ID: <1816265.QTXJ6IRgZW@thomas> (raw)
In-Reply-To: <ccf563a1-8ba0-fc2f-91a2-94381164d3c7@huawei.com>
28/01/2021 02:55, oulijun:
> >> +FEC
> >> +---
> >> +
> >> +Supports Forward error correction. Forward error correction (FEC) is
> >> a bit error correction mode.
> >> +It adds error correction information to data packets at the transmit
> >> end, and uses the error correction
> >> +information to correct the bit errors generated during data packet
> >> transmission at the receive end. This
> >> +improves signal quality but also brings a delay to signals. This
> >> function can be enabled or disabled as required.
> >> +
> >> +* **[implements] eth_dev_ops**: ``fec_get_capability``, ``fec_get``,
> >> ``fec_set``.
> >> +* **[provides] rte_eth_fec_capa**: ``speed:ETH_SPEED_NUM_*``,
> >> ``capa:RTE_ETH_FEC_MODE_TO_CAPA()``.
> >> +* **[related] API**: ``rte_eth_fec_get_capability()``,
> >> ``rte_eth_fec_get()``, ``rte_eth_fec_set()``.
> >> +
> >
> > Feature doc looks good, thanks for adding this.
> >
> > Can you add another patch in this series to update .ini files for hns3 &
> > cxgbe to advertise FEC feature?
> >
> ok. I will do it in next version.
I suppose updating drivers can be done in the same patch.
next prev parent reply other threads:[~2021-01-28 9:14 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-20 13:43 [dpdk-dev] [PATCH 0/3] update doc for hns3 Lijun Ou
2021-01-20 13:43 ` [dpdk-dev] [PATCH 1/3] doc: add FEC in NIC features Lijun Ou
2021-01-28 0:20 ` Ferruh Yigit
2021-01-28 0:21 ` Ferruh Yigit
2021-01-28 1:55 ` oulijun
2021-01-28 9:14 ` Thomas Monjalon [this message]
2021-01-20 13:43 ` [dpdk-dev] [PATCH 2/3] doc: update release notes for hns3 Lijun Ou
2021-01-28 0:25 ` Ferruh Yigit
2021-01-20 13:43 ` [dpdk-dev] [PATCH 3/3] doc: fix hns3 rst Lijun Ou
2021-01-28 12:43 ` [dpdk-dev] [PATCH v2 0/5] update doc for hns3 Lijun Ou
2021-01-28 12:43 ` [dpdk-dev] [PATCH v2 1/5] doc: add FEC in NIC features Lijun Ou
2021-01-28 12:43 ` [dpdk-dev] [PATCH v2 2/5] net/hns3: add FEC feature for hns3.ini Lijun Ou
2021-01-28 14:12 ` Thomas Monjalon
2021-01-29 1:13 ` oulijun
2021-01-29 8:46 ` Ferruh Yigit
2021-01-29 8:57 ` Thomas Monjalon
2021-01-29 9:10 ` oulijun
2021-01-28 12:43 ` [dpdk-dev] [PATCH v2 3/5] net/cxgbe: add FEC feature for cxgbe.ini Lijun Ou
2021-01-28 12:43 ` [dpdk-dev] [PATCH v2 4/5] doc: update release notes for hns3 Lijun Ou
2021-01-28 14:46 ` Ferruh Yigit
2021-01-29 1:28 ` oulijun
2021-01-29 8:48 ` Ferruh Yigit
2021-01-28 12:43 ` [dpdk-dev] [PATCH v2 5/5] doc: fix hns3 rst Lijun Ou
2021-01-29 9:22 ` [dpdk-dev] [PATCH v3 0/3] update doc for hns3 Lijun Ou
2021-01-29 9:22 ` [dpdk-dev] [PATCH v3 1/3] doc: add FEC in NIC features Lijun Ou
2021-01-29 9:22 ` [dpdk-dev] [PATCH v3 2/3] doc: update release notes for hns3 Lijun Ou
2021-01-29 9:22 ` [dpdk-dev] [PATCH v3 3/3] doc: fix hns3 rst Lijun Ou
2021-01-29 11:57 ` [dpdk-dev] [PATCH v3 0/3] update doc for hns3 Ferruh Yigit
2021-02-03 9:43 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1816265.QTXJ6IRgZW@thomas \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=linuxarm@openeuler.org \
--cc=oulijun@huawei.com \
--cc=rahul.lakkireddy@chelsio.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).