From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C81C1A0C47; Tue, 26 Oct 2021 12:25:44 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 43D9C410D5; Tue, 26 Oct 2021 12:25:44 +0200 (CEST) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by mails.dpdk.org (Postfix) with ESMTP id BCF17407FF for ; Tue, 26 Oct 2021 12:25:43 +0200 (CEST) Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 593285C0329; Tue, 26 Oct 2021 06:25:43 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Tue, 26 Oct 2021 06:25:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= afiq3FRT7SeXRKeDzT22uAEHVsbRkJ6MntDxtjabra8=; b=qJd3MJKISiNcAy9H MNTMGnvk2Q9x/eAxohE9wR3eilxNHDgNok9dw3wTu0qqWXf7rBH8wWsYq/yKwoqG B+n5wDvoRrWkkBh9P3a8AIJmrNuhHSfzQq3MbnS5A/WrwyRXK6ziG9Rp6pSAYSJb nJPDkyugUiXkrrrsmpOSx/fWjVmnN/LXjYrDAxFm4e5Qofuka/H1zSCe+yHGfSMT sVDO/22XX5k17k3GaSWssgEc21+bAn9hKkE8CT1Gb9GnWhaRbAHkLDulhIqqvQMI Lner0lpS3kjAv+KkYcchmqm4hc31TiA87HMRgZGusSJATakIshPf6RQaZqaplHE4 9lw++Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=afiq3FRT7SeXRKeDzT22uAEHVsbRkJ6MntDxtjabr a8=; b=GFId37BFPgijH+7334kEMxsjqrHdBnnYzaqG6YiqUdFsgQrfnHSEZjPb6 U9iCXdTPY8j3tRLa0jyWGCfeGmfnmaZVaNws4Bi5Dc0iexzm4iZp0z0iYiJXP/2e Sh5fLGzAwZ9UaZW23tLsE2W8ZRwNZigVuLU3DlPBvUE59n//zCsrEwX5VMszp4WZ 8VUbFJ4ucqhBouuoIA/up0oHltKclEP18oh+c/UTSHQxZPp+T1YoVTUITA1gHkMo WX9edzu24+RZgP4jjzerpibs/nvnKm7Lh6GnvVWIWtHIM1fkc205bRG+1n/dzLSE ok/tPWCEK5OgA/ic+GmASV39EklKw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrvdefkecutefuodetggdotefrodftvfcurf hrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecuuegr ihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjug hrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghsucfo ohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtffrrg htthgvrhhnpeffvdffjeeuteelfeeileduudeugfetjeelveefkeejfeeigeehteffvdek feegudenucffohhmrghinhepughpughkrdhorhhgnecuvehluhhsthgvrhfuihiivgeptd enucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgv th X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 26 Oct 2021 06:25:41 -0400 (EDT) From: Thomas Monjalon To: "Singh, Jasvinder" , "Liu, Yu Y" , "Singh, Jasvinder" , "Dumitrescu, Cristian" , "Liguzinski, WojciechX" Cc: "dev@dpdk.org" , "Ajmera, Megha" , "Liu, Yu Y" , "david.marchand@redhat.com" , john.mcnamara@intel.com Date: Tue, 26 Oct 2021 12:25:40 +0200 Message-ID: <1819018.PrXf9QjVv2@thomas> In-Reply-To: References: <20211020075002.3871469-1-wojciechx.liguzinski@intel.com> <2652393.2NFNvQLijv@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v18 0/5] Add PIE support for HQoS library X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 26/10/2021 12:20, Liguzinski, WojciechX: > Hi, > > V16 - My bad, probably I haven't copied it correctly when preparing cover letter > V17 - I understood Cristian's comment as to copy the Series ACK to next versions of patches, and not to "split it" for each one. If that was the correct way I had no knowledge about it. Yes you had to reproduce it in each patch. Otherwise who would do it to make it appear in patchwork and in the git history when merged? I understand you did not have that knowledge. For future, I hope the Intel team will better track features patches of newcomers so they don't miss something knew by others. John, I know knowledge sharing is not an easy task, we always have to improve :) > From: Thomas Monjalon > 26/10/2021 12:02, Dumitrescu, Cristian: > > From: Thomas Monjalon > > > 26/10/2021 10:24, Liu, Yu Y: > > > > Hi Thomas, > > > > > > > > Would you merge this patch as the series is acked by Cristian as below? > > > > > > > https://patchwork.dpdk.org/project/dpdk/cover/20211019081902.3514841 > > > - > > > 1-wojciechx.liguzinski@intel.com/ > > > > > > I didn't see any email from Cristian. > > > It seems you just added this ack silently at the bottom of the cover letter. > > > > > > 1/ an email from Cristian is far better 2/ when integrating ack, it > > > must be done in patches, not cover letter > > > > > > > Hi Thomas, > > > > I did ack this set in a previous version (V15) by replying with "Series-acked-by" on the cover letter email, which does not show in patchwork. Is there a better way to do this? > > No you did the right thing (I missed this email on v15). > But v16 did not show your ack. > And v17 added it only in the cover letter instead of reporting it in all patches. > > > > It would be good to have Jasvinder's ack as well on this series, as he is looking into some other aspects of the sched library. > > Yes > > >