From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 653B5A04B7; Wed, 14 Oct 2020 11:37:32 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4A3961DD89; Wed, 14 Oct 2020 11:37:31 +0200 (CEST) Received: from dal3relay196.mxroute.com (dal3relay196.mxroute.com [64.40.27.196]) by dpdk.org (Postfix) with ESMTP id 449281DD86 for ; Wed, 14 Oct 2020 11:37:29 +0200 (CEST) Received: from filter004.mxroute.com ([149.28.56.236] 149.28.56.236.vultr.com) (Authenticated sender: mN4UYu2MZsgR) by dal3relay196.mxroute.com (ZoneMTA) with ESMTPSA id 1752678a927000f106.001 for (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES128-GCM-SHA256); Wed, 14 Oct 2020 09:37:23 +0000 X-Zone-Loop: 5ad9af4474c58ab379dcf03157d967caf06cc35ac6f9 X-Originating-IP: [149.28.56.236] Received: from echo.mxrouting.net (echo.mxrouting.net [116.202.222.109]) by filter004.mxroute.com (Postfix) with ESMTPS id DD5DE3E9FF; Wed, 14 Oct 2020 09:37:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=ashroe.eu; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=MJQxtbq8KawCwWe3nmAPCkDnohrTOE/gyQeA/lOnZNo=; b=VUV2nOz6QTycyNwA5VGCnPXCGd fv0Cv+Yb4MRcw6ERXYkVLus/2jIWLer5FX86rCb75V3iOSfskomVl7JhR+jpfgS8I95x1EuOg8tsD y/VKgnkuwTaX3R1fe7QPQCUNxKU7aNpPFPwiygR+ty3F/Te2H/W+yVr5xLkiSyE57enQkXKyQx1nF f7B5u/qRnVREG+KoPi15d038drQHkXefVRpGC/rTpwKIyBgJGEDNJ1Z8OYBpxWJ4MZveqfAjMHAVJ DVEnf4JOvyg+iKIBpyZuq+7mbT83uYdWRcp3Jw9iEJ1LRCXlB5qrHZGt9yHs+mwrg6OALfWBub3Ii abitqSsA==; To: Conor Walsh , nhorman@tuxdriver.com, bruce.richardson@intel.com, thomas@monjalon.net, david.marchand@redhat.com Cc: dev@dpdk.org References: <20201012080829.3446-1-conor.walsh@intel.com> <20201012130348.3212-1-conor.walsh@intel.com> From: "Kinsella, Ray" Autocrypt: addr=mdr@ashroe.eu; keydata= mQINBFv8B3wBEAC+5ImcgbIvadt3axrTnt7Sxch3FsmWTTomXfB8YiuHT8KL8L/bFRQSL1f6 ASCHu3M89EjYazlY+vJUWLr0BhK5t/YI7bQzrOuYrl9K94vlLwzD19s/zB/g5YGGR5plJr0s JtJsFGEvF9LL3e+FKMRXveQxBB8A51nAHfwG0WSyx53d61DYz7lp4/Y4RagxaJoHp9lakn8j HV2N6rrnF+qt5ukj5SbbKWSzGg5HQF2t0QQ5tzWhCAKTfcPlnP0GymTBfNMGOReWivi3Qqzr S51Xo7hoGujUgNAM41sxpxmhx8xSwcQ5WzmxgAhJ/StNV9cb3HWIoE5StCwQ4uXOLplZNGnS uxNdegvKB95NHZjRVRChg/uMTGpg9PqYbTIFoPXjuk27sxZLRJRrueg4tLbb3HM39CJwSB++ YICcqf2N+GVD48STfcIlpp12/HI+EcDSThzfWFhaHDC0hyirHxJyHXjnZ8bUexI/5zATn/ux TpMbc/vicJxeN+qfaVqPkCbkS71cHKuPluM3jE8aNCIBNQY1/j87k5ELzg3qaesLo2n1krBH bKvFfAmQuUuJT84/IqfdVtrSCTabvDuNBDpYBV0dGbTwaRfE7i+LiJJclUr8lOvHUpJ4Y6a5 0cxEPxm498G12Z3NoY/mP5soItPIPtLR0rA0fage44zSPwp6cQARAQABtBxSYXkgS2luc2Vs bGEgPG1kckBhc2hyb2UuZXU+iQJUBBMBCAA+FiEEcDUDlKDJaDuJlfZfdJdaH/sCCpsFAlv8 B3wCGyMFCQlmAYAFCwkIBwIGFQoJCAsCBBYCAwECHgECF4AACgkQdJdaH/sCCptdtRAAl0oE msa+djBVYLIsax+0f8acidtWg2l9f7kc2hEjp9h9aZCpPchQvhhemtew/nKavik3RSnLTAyn B3C/0GNlmvI1l5PFROOgPZwz4xhJKGN7jOsRrbkJa23a8ly5UXwF3Vqnlny7D3z+7cu1qq/f VRK8qFyWkAb+xgqeZ/hTcbJUWtW+l5Zb+68WGEp8hB7TuJLEWb4+VKgHTpQ4vElYj8H3Z94a 04s2PJMbLIZSgmKDASnyrKY0CzTpPXx5rSJ1q+B1FCsfepHLqt3vKSALa3ld6bJ8fSJtDUJ7 JLiU8dFZrywgDIVme01jPbjJtUScW6jONLvhI8Z2sheR71UoKqGomMHNQpZ03ViVWBEALzEt TcjWgJFn8yAmxqM4nBnZ+hE3LbMo34KCHJD4eg18ojDt3s9VrDLa+V9fNxUHPSib9FD9UX/1 +nGfU/ZABmiTuUDM7WZdXri7HaMpzDRJUKI6b+/uunF8xH/h/MHW16VuMzgI5dkOKKv1LejD dT5mA4R+2zBS+GsM0oa2hUeX9E5WwjaDzXtVDg6kYq8YvEd+m0z3M4e6diFeLS77/sAOgaYL 92UcoKD+Beym/fVuC6/55a0e12ksTmgk5/ZoEdoNQLlVgd2INtvnO+0k5BJcn66ZjKn3GbEC VqFbrnv1GnA58nEInRCTzR1k26h9nmS5Ag0EW/wHfAEQAMth1vHr3fOZkVOPfod3M6DkQir5 xJvUW5EHgYUjYCPIa2qzgIVVuLDqZgSCCinyooG5dUJONVHj3nCbITCpJp4eB3PI84RPfDcC hf/V34N/Gx5mTeoymSZDBmXT8YtvV/uJvn+LvHLO4ZJdvq5ZxmDyxfXFmkm3/lLw0+rrNdK5 pt6OnVlCqEU9tcDBezjUwDtOahyV20XqxtUttN4kQWbDRkhT+HrA9WN9l2HX91yEYC+zmF1S OhBqRoTPLrR6g4sCWgFywqztpvZWhyIicJipnjac7qL/wRS+wrWfsYy6qWLIV80beN7yoa6v ccnuy4pu2uiuhk9/edtlmFE4dNdoRf7843CV9k1yRASTlmPkU59n0TJbw+okTa9fbbQgbIb1 pWsAuicRHyLUIUz4f6kPgdgty2FgTKuPuIzJd1s8s6p2aC1qo+Obm2gnBTduB+/n1Jw+vKpt 07d+CKEKu4CWwvZZ8ktJJLeofi4hMupTYiq+oMzqH+V1k6QgNm0Da489gXllU+3EFC6W1qKj tkvQzg2rYoWeYD1Qn8iXcO4Fpk6wzylclvatBMddVlQ6qrYeTmSbCsk+m2KVrz5vIyja0o5Y yfeN29s9emXnikmNfv/dA5fpi8XCANNnz3zOfA93DOB9DBf0TQ2/OrSPGjB3op7RCfoPBZ7u AjJ9dM7VABEBAAGJAjwEGAEIACYWIQRwNQOUoMloO4mV9l90l1of+wIKmwUCW/wHfAIbDAUJ CWYBgAAKCRB0l1of+wIKm3KlD/9w/LOG5rtgtCUWPl4B3pZvGpNym6XdK8cop9saOnE85zWf u+sKWCrxNgYkYP7aZrYMPwqDvilxhbTsIJl5HhPgpTO1b0i+c0n1Tij3EElj5UCg3q8mEc17 c+5jRrY3oz77g7E3oPftAjaq1ybbXjY4K32o3JHFR6I8wX3m9wJZJe1+Y+UVrrjY65gZFxcA thNVnWKErarVQGjeNgHV4N1uF3pIx3kT1N4GSnxhoz4Bki91kvkbBhUgYfNflGURfZT3wIKK +d50jd7kqRouXUCzTdzmDh7jnYrcEFM4nvyaYu0JjSS5R672d9SK5LVIfWmoUGzqD4AVmUW8 pcv461+PXchuS8+zpltR9zajl72Q3ymlT4BTAQOlCWkD0snBoKNUB5d2EXPNV13nA0qlm4U2 GpROfJMQXjV6fyYRvttKYfM5xYKgRgtP0z5lTAbsjg9WFKq0Fndh7kUlmHjuAIwKIV4Tzo75 QO2zC0/NTaTjmrtiXhP+vkC4pcrOGNsbHuaqvsc/ZZ0siXyYsqbctj/sCd8ka2r94u+c7o4l BGaAm+FtwAfEAkXHu4y5Phuv2IRR+x1wTey1U1RaEPgN8xq0LQ1OitX4t2mQwjdPihZQBCnZ wzOrkbzlJMNrMKJpEgulmxAHmYJKgvZHXZXtLJSejFjR0GdHJcL5rwVOMWB8cg== Message-ID: <181905ff-e0c5-86b0-4f85-07d717edd7bf@ashroe.eu> Date: Wed, 14 Oct 2020 10:37:19 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.12.1 MIME-Version: 1.0 In-Reply-To: <20201012130348.3212-1-conor.walsh@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-AuthUser: mdr@ashroe.eu Subject: Re: [dpdk-dev] [PATCH v6 0/4] devtools: abi breakage checks X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 12/10/2020 14:03, Conor Walsh wrote: > This patchset will help developers discover abi breakages more easily > before upstreaming their code. Currently checking that the DPDK ABI > has not changed before up-streaming code is not intuitive and the > process is time consuming. Currently contributors must use the > test-meson-builds.sh tool, alongside some environmental variables to > test their changes. Contributors in many cases are either unaware or > unable to do this themselves, leading to a potentially serious situation > where they are unknowingly up-streaming code that breaks the ABI. These > breakages are caught by Travis, but it would be more efficient if they > were caught locally before up-streaming. I would remove everything in the git log text before this line... > This patchset introduces changes > to test-meson-builds.sh, check-abi.sh and adds a new script > gen-abi-tarballs.sh. The changes to test-meson-builds.sh include UX UX changes = improvements > changes such as adding command line arguments and allowing the use of > relative paths. Reduced the number of abi checks to just two, one for both > x86_64 and ARM, the references for these tests can now be prebuilt and > downloaded by test-meson-builds.sh, these changes will allow the tests to > run much faster. check-abi.sh is updated to use the prebuilt references. > gen-abi-tarballs.sh is a new script to generate the prebuilt abi > references used by test-meson-builds.sh, these compressed archives can be > retrieved from either a local directory or a remote http location. > > --- > v6: Corrected a mistake in the doc patch > > v5: > - Patchset has been completely reworked following feedback > - Patchset is now part of test-meson-builds.sh not the meson build system > > v4: > - Reworked both Python scripts to use more native Python functions > and modules. > - Python scripts are now in line with how other Python scripts in > DPDK are structured. > > v3: > - Fix for bug which now allows meson < 0.48.0 to be used > - Various coding style changes throughout > - Minor bug fixes to the various meson.build files > > v2: Spelling mistake, corrected spelling of environmental > > Conor Walsh (4): > devtools: add generation of compressed abi dump archives > devtools: abi and UX changes for test-meson-builds.sh > devtools: change dump file not found to warning in check-abi.sh > doc: test-meson-builds.sh doc updates > > devtools/check-abi.sh | 3 +- > devtools/gen-abi-tarballs.sh | 48 ++++++++ > devtools/test-meson-builds.sh | 170 ++++++++++++++++++++++------ > doc/guides/contributing/patches.rst | 26 +++-- > 4 files changed, 201 insertions(+), 46 deletions(-) > create mode 100755 devtools/gen-abi-tarballs.sh >