From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Ciara Loftus <ciara.loftus@intel.com>
Cc: dev@dpdk.org, Yuanhan Liu <yuanhan.liu@linux.intel.com>,
mukawa@igel.co.jp
Subject: Re: [dpdk-dev] [PATCH] vhost: Fix retrieval of numa information in PMD
Date: Wed, 06 Apr 2016 18:45:52 +0200 [thread overview]
Message-ID: <1819068.kZbQtThe3g@xps13> (raw)
In-Reply-To: <20160406050345.GS3080@yliu-dev.sh.intel.com>
2016-04-06 13:03, Yuanhan Liu:
> On Tue, Apr 05, 2016 at 05:09:47PM +0100, Ciara Loftus wrote:
> > After some testing, it was found that retrieving numa information
> > about a vhost device via a call to get_mempolicy is more
> > accurate when performed during the new_device callback versus
> > the vring_state_changed callback, in particular upon initial boot
> > of the VM. Performing this check during new_device is also
> > potentially more efficient as this callback is only triggered once
> > during device initialisation, compared with vring_state_changed
> > which may be called multiple times depending on the number of
> > queues assigned to the device.
> >
> > Reorganise the code to perform this check and assign the correct
> > socket_id to the device during the new_device callback.
> >
> > Signed-off-by: Ciara Loftus <ciara.loftus@intel.com>
>
> Acked-by: Yuanhan Liu <yuanhan.liu@linux.intel.com>
Fixes: ee584e9710b9 ("vhost: add driver on top of the library")
Applied, thanks
next prev parent reply other threads:[~2016-04-06 16:47 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-05 16:09 Ciara Loftus
2016-04-06 5:03 ` Yuanhan Liu
2016-04-06 16:45 ` Thomas Monjalon [this message]
2016-04-06 5:32 ` Tan, Jianfeng
2016-04-06 5:44 ` Yuanhan Liu
2016-04-06 6:05 ` Tan, Jianfeng
2016-04-06 6:17 ` Yuanhan Liu
2016-04-06 6:32 ` Tan, Jianfeng
2016-04-06 6:49 ` Tetsuya Mukawa
2016-04-06 7:17 ` Yuanhan Liu
2016-04-06 7:28 ` Tetsuya Mukawa
2016-04-06 9:37 ` Loftus, Ciara
2016-04-06 16:09 ` Yuanhan Liu
2016-04-06 16:12 ` Thomas Monjalon
2016-04-06 16:43 ` Yuanhan Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1819068.kZbQtThe3g@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=ciara.loftus@intel.com \
--cc=dev@dpdk.org \
--cc=mukawa@igel.co.jp \
--cc=yuanhan.liu@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).