From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f49.google.com (mail-wm0-f49.google.com [74.125.82.49]) by dpdk.org (Postfix) with ESMTP id 4AF622C69 for ; Wed, 6 Apr 2016 18:47:31 +0200 (CEST) Received: by mail-wm0-f49.google.com with SMTP id f198so81806460wme.0 for ; Wed, 06 Apr 2016 09:47:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=Dy0SORMVkrXUFZ4RGnBwZ/rqbBo4rpcKUnqpOCdj7tk=; b=x4s0CMb41DmK98uBK4cE7hWaJd+qE67urlFcShgPOn6N5Z59kvlq7rvMEwLdlCtzWo ojIMZtsjuS7EoAjbeJI696J8QH99gD/WpC2DKfJl1Vi5LbIPU9/V+BD+YUJtDwQDjsch XmDru0wLAlTH1CHLgdnKroq11pmav3FKIDkQI/gg2Dk6oeEI+RXg7XE/c80g/GNiemFE sM0+bmpVSA9Cl00k3RZ6Ur7yys9GVDAvLgW9iVq5vPvGIFaq56dVZyTTtOHmuqUnc7Gi CJrzchJwx07YuMjDsoSqJ3qxgt6m04U6Na5vY19hBp6GKYdYy4S2I9QTNGirxB2nDT0V qrqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding; bh=Dy0SORMVkrXUFZ4RGnBwZ/rqbBo4rpcKUnqpOCdj7tk=; b=Ie6oCkgzNG5rgHJnSG8gDtS+8TKih6P/LBfrt66fF0tkN8KRLeZOX/TLdHl9MCVKrh U+Tp2FQVTqeOHHE1oD8lrwsbfEFbNm6bB27G9OE9xVR4Pu+NkLvnZ0OkU0DhV8p0V8Qh 1VFOgmDqYTNJ/263dNtnbp7Yb7BC6bRnPttLpP5nlfJ+KuGekUlahXYg7Ywlfiyy0nCP hmWmYXrDZjq5ZkjVn/gnwxYmiBG8YTpBNN6wsg9iiL8nJuI4mFJkKRhOHWKu1buJxnZX crV+w2OFx81DwIJmBrGguc0JtH79S1QvcvJFgEzStEqw/AWec8SJJD+np6Nphcr5gc11 BfsA== X-Gm-Message-State: AD7BkJJAvpML1686tRufiy6dto5o91YoN6117VPeFAsb4i+5A6JYRPQ5GyoonZqky4RwvWvr X-Received: by 10.194.190.201 with SMTP id gs9mr7664413wjc.133.1459961251125; Wed, 06 Apr 2016 09:47:31 -0700 (PDT) Received: from xps13.localnet (91.111.75.86.rev.sfr.net. [86.75.111.91]) by smtp.gmail.com with ESMTPSA id wr2sm4080990wjc.49.2016.04.06.09.47.30 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 06 Apr 2016 09:47:30 -0700 (PDT) From: Thomas Monjalon To: Ciara Loftus Cc: dev@dpdk.org, Yuanhan Liu , mukawa@igel.co.jp Date: Wed, 06 Apr 2016 18:45:52 +0200 Message-ID: <1819068.kZbQtThe3g@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <20160406050345.GS3080@yliu-dev.sh.intel.com> References: <1459872587-11655-1-git-send-email-ciara.loftus@intel.com> <20160406050345.GS3080@yliu-dev.sh.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] vhost: Fix retrieval of numa information in PMD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Apr 2016 16:47:31 -0000 2016-04-06 13:03, Yuanhan Liu: > On Tue, Apr 05, 2016 at 05:09:47PM +0100, Ciara Loftus wrote: > > After some testing, it was found that retrieving numa information > > about a vhost device via a call to get_mempolicy is more > > accurate when performed during the new_device callback versus > > the vring_state_changed callback, in particular upon initial boot > > of the VM. Performing this check during new_device is also > > potentially more efficient as this callback is only triggered once > > during device initialisation, compared with vring_state_changed > > which may be called multiple times depending on the number of > > queues assigned to the device. > > > > Reorganise the code to perform this check and assign the correct > > socket_id to the device during the new_device callback. > > > > Signed-off-by: Ciara Loftus > > Acked-by: Yuanhan Liu Fixes: ee584e9710b9 ("vhost: add driver on top of the library") Applied, thanks