From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6E67B41DF5; Mon, 6 Mar 2023 15:22:24 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5E91D40E50; Mon, 6 Mar 2023 15:22:24 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 3D99240A8A for ; Mon, 6 Mar 2023 15:22:22 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1678112541; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xlbhVvGHQRlrhDD8n6ZStuTG9G40mBYgZRKmPYaMI4g=; b=TtQszLAxQqgiqQe5EjPLRfGBYKHmnPAbi/CsnbkOZzFVAoElzImZUYmrBogI0g3ftXEfrN HNgiH/naXBEgM2oXAgDxa6EGEMBn3F0U3lTj85vKr9Fjat7Dj1Cu4zXZ4XdnEp0ufN4Dj4 EcW6xHLlc2sxMRMBepNUU1flX7pn7q0= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-454-nrz4n9nVMtaHMeB1e6amDw-1; Mon, 06 Mar 2023 09:22:18 -0500 X-MC-Unique: nrz4n9nVMtaHMeB1e6amDw-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 48AA5803520; Mon, 6 Mar 2023 14:22:18 +0000 (UTC) Received: from [10.39.208.18] (unknown [10.39.208.18]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6C409175AD; Mon, 6 Mar 2023 14:22:17 +0000 (UTC) Message-ID: <181baa4c-97fd-95a0-537b-f7f1643cf42e@redhat.com> Date: Mon, 6 Mar 2023 15:22:16 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v3] vhost: fix madvise arguments alignment To: Mike Pattrick , dev@dpdk.org Cc: david.marchand@redhat.com, chenbo.xia@intel.com References: <20230223043551.1108541-1-mkp@redhat.com> <20230301200228.1477189-1-mkp@redhat.com> From: Maxime Coquelin In-Reply-To: <20230301200228.1477189-1-mkp@redhat.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 3/1/23 21:02, Mike Pattrick wrote: > The arguments passed to madvise should be aligned to the alignment of > the backing memory. Now we keep track of each regions alignment and use > then when setting coredump preferences. To facilitate this, a new member > was added to rte_vhost_mem_region. A new function was added to easily > translate memory address back to region alignment. Unneeded calls to > madvise were reduced, as the cache removal case should already be > covered by the cache insertion case. The previously inline function > mem_set_dump was removed from a header file and made not inline. > > Fixes: 338ad77c9ed3 ("vhost: exclude VM hugepages from coredumps") > > Signed-off-by: Mike Pattrick > --- > Since v1: > - Corrected a cast for 32bit compiles > Since v2: > - Removed changes from rte_vhost.h > - Restored set_mem_dump in ioctl remove/evict functions > --- > lib/vhost/iotlb.c | 68 +++++++++++++++++++++++++++++++----------- > lib/vhost/iotlb.h | 5 ++-- > lib/vhost/vhost.h | 12 ++------ > lib/vhost/vhost_user.c | 68 ++++++++++++++++++++++++++++++++++-------- > 4 files changed, 110 insertions(+), 43 deletions(-) > Applied to dpdk-next-virtio/main. Thanks, Maxime