From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wi0-f180.google.com (mail-wi0-f180.google.com
 [209.85.212.180]) by dpdk.org (Postfix) with ESMTP id E59A5C45C
 for <dev@dpdk.org>; Mon, 27 Jul 2015 01:33:34 +0200 (CEST)
Received: by wibud3 with SMTP id ud3so93583343wib.0
 for <dev@dpdk.org>; Sun, 26 Jul 2015 16:33:34 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=HK2w8qsx/bLpnDQE6hUUxu094O5xGDknEsia8YLglvg=;
 b=eMdtdVl9jqpQwjWInJMEjJECt6mC0CtQP7YbkmwnCSy5nw5VG0oiK8wgJL6dX6/hjK
 BB5ybS8iW7EeQ2UfQwPNJI73DlApjVvNDM3QKeJtld3OfCtR6vHbrFFOcc8H4Z/PQDXx
 oX35mA75V+bkaVdo/KRMOy7U62jKjNEIW19K6NilbX1DgfGfR9do/tqW8xPErH+SVW5i
 b186IcFG7PevF4MY3XojalWrxIKacdyvkscsbJ8ubzN4Tgh58d2AqKjP2fJlHIUaNm58
 xHYxxl7AvINHuiTUhVIXpOvD/ITavr4iZF3SE46hkLGjqgQplmF3YqnHkalAPP49sxQW
 xxTQ==
X-Gm-Message-State: ALoCoQl96UaZPBi9JctKJdn//2YzhUlmjXvyDhSyGfqg4/IE0HG0sv3Avpytqbz7wQC6dX/909qp
X-Received: by 10.180.73.200 with SMTP id n8mr18750318wiv.94.1437953614708;
 Sun, 26 Jul 2015 16:33:34 -0700 (PDT)
Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136])
 by smtp.gmail.com with ESMTPSA id h9sm24766292wjx.20.2015.07.26.16.33.32
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Sun, 26 Jul 2015 16:33:33 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Ravi Kerur <rkerur@gmail.com>
Date: Mon, 27 Jul 2015 01:32:18 +0200
Message-ID: <18210927.c72O7E0spP@xps13>
Organization: 6WIND
User-Agent: KMail/4.14.8 (Linux/4.0.4-2-ARCH; KDE/4.14.8; x86_64; ; )
In-Reply-To: <1437852990-6096-2-git-send-email-rkerur@gmail.com>
References: <1437852868-6031-1-git-send-email-rkerur@gmail.com>
 <1437852990-6096-1-git-send-email-rkerur@gmail.com>
 <1437852990-6096-2-git-send-email-rkerur@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v9 2/3] Move common functions in eal_timer.c
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Sun, 26 Jul 2015 23:33:35 -0000

2015-07-25 12:36, Ravi Kerur:
> +static void
> +set_tsc_freq_fallback(void)
> +{
> +	RTE_LOG(WARNING, EAL, "WARNING: clock_gettime cannot use "
> +		"CLOCK_MONOTONIC_RAW and HPET is not available"

Not generic enough for BSD.
We can say "TSC frequency estimated roughly"

> +		" - clock timings may be less accurate.\n");
> +	/* assume that the sleep(1) will sleep for 1 second */
[...]
> +/**
> + * This function sets TSC frequency from sysctl

It is not the style of the file to start with "This function..."

> + * for BSD and from clock for Linux.
> + * Is a wrapper function for BSD which will
> + * internally call set_tsc_freq_from_sysctl.

This sentence is an implementation detail.