From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 20CA81B2F6 for ; Tue, 10 Oct 2017 18:17:06 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 98783206FC; Tue, 10 Oct 2017 12:17:05 -0400 (EDT) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Tue, 10 Oct 2017 12:17:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=hmfaoZDc8w3tE9m bnLrEe80PJLs1kogRZofmnmKjLqE=; b=TAlfZwIEaS8HAaLX1QHUSW4CkrFKANr BU3bw1JcCzDs1tfeoA6NRo7yOKGjM5o1rt5wnZsKyS0WEM1q+9ZR7fGc2ptnD+Tv v3DSbQhjX+qcrc6iu+mGh8fbGsJvdsjdzNnCHGps/FQPbXjKs7UNizYXaBAqFCiK pPLnaE67vPjk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s= fm1; bh=hmfaoZDc8w3tE9mbnLrEe80PJLs1kogRZofmnmKjLqE=; b=Hs9/ZYDV fvX22hqJ5WuRkw/SWpGx1gGVFqrM9E488X7bwyetmhYGQINNeIOoJND0S10mGpKO Q5GyHEZWe5H/016xfqt0Z+wP2A/2+Gj5c24UkU1W5m0T7aSdj0rQ/op9zk+1DLwt LgGP45R7wODFruSj6XykekWJWTmNXXsDAdNwXBQIKW5zITdLpyAfmsOaBYD/EayP cUWUdS9ww1NtG+yw1Gpd0nvcEn0Dg1eeMBSUV1zQvjmiYUE05gwm2OLiqdl/F6kc 3oMHemymOiLxKQ1fPKvebiJbP4f1LBNEhZN0zQzIWmlIo9og1jHZMrzBUf4uCTJ8 Kq+kRzSzv7fG3Q== X-ME-Sender: X-Sasl-enc: oR/WT/BDmm6/F4QT4c0CyLAXcnc6YdRMauE7JoDSdR9j 1507652225 Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 404542418B; Tue, 10 Oct 2017 12:17:05 -0400 (EDT) From: Thomas Monjalon To: santosh Cc: dev@dpdk.org, Shreyansh Jain , ferruh.yigit@intel.com, hemant.agrawal@nxp.com Date: Tue, 10 Oct 2017 18:17:04 +0200 Message-ID: <1821646.02OIGBtUFx@xps> In-Reply-To: <7387c315-fd0f-a5a2-fdd9-1ae9aed69e9b@caviumnetworks.com> References: <20171010070155.17412-1-shreyansh.jain@nxp.com> <2102754.igz1rhL23C@xps> <7387c315-fd0f-a5a2-fdd9-1ae9aed69e9b@caviumnetworks.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] bus/dpaa: fix memory allocation during bus scan X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Oct 2017 16:17:06 -0000 10/10/2017 16:05, santosh: > Hi Thomas, > > On Tuesday 10 October 2017 01:09 PM, Thomas Monjalon wrote: > > 10/10/2017 09:01, Shreyansh Jain: > >> Fixes: 5b22cf744689 ("bus/dpaa: introducing FMan configurations") > >> Fixes: 37f9b54bd3cf ("net/dpaa: support Tx and Rx queue setup") > > These lines should appear after the explanation. > > > >> Cc: shreyansh.jain@nxp.com > >> > >> With the IOVA auto detection changes, bus scan is performed before > >> memory initialization. DPAA bus scan must not use rte_malloc in > >> its path. > > If the scan has been broken by IOVA detection, you should reference > > IOVA in Fixes line, not DPAA. > > > hmm.. IOVA not breaking scanning!, Refer this [1]. It is breaking. A break is a behaviour or interface change. When moving init order, you break behaviour. I don't say it is bad. I say only it is the primary cause of this change. The Fixes: line is also a help when backporting patches. This patch needs to be backported only if IOVA patch is also backported. > We(me/hemant) has discussed about same on thread[1] and agreed to > do respective changes and remove rte_ memory dependency from code base > at scan time.. > > Thanks. > > [1] http://dpdk.org/dev/patchwork/patch/26764/ You already discussed about this issue, fine. Santosh, as you insist to talk again about it, one more comment: It is very good to have discussions on the mailing list. It would be perfect if all these informations were explicitly given in the commit messages. For instance, saying that the scan cannot use rte_malloc anymore is a valuable tip for other developpers.