From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-we0-f182.google.com (mail-we0-f182.google.com
 [74.125.82.182]) by dpdk.org (Postfix) with ESMTP id 0D16230D
 for <dev@dpdk.org>; Tue, 17 Jun 2014 11:25:16 +0200 (CEST)
Received: by mail-we0-f182.google.com with SMTP id q59so6786649wes.41
 for <dev@dpdk.org>; Tue, 17 Jun 2014 02:25:33 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=mkHcVgr0TMNuXppHsHuEpg/CHG4jYHhJiRy2c4NW7LI=;
 b=HrjxUOVGvEenaZ+T2GCp0FiUWInkPumHj8fEInA5z38UYF6g5wr7tms7HbpT1xLs3U
 +pcnLxS2e2lioo+AkMUHn+llWvNkzRCNm1pge6hxTfEbKZrTGySmu5C5CNZLh9Zg1HD3
 J6FYcyHvmkg/rk/ASfrZYr3cTuaOwJ9zJxC9fSOuc2z/B9Yt0HLd7kum3YS1a3x+6XAK
 O4NocLVxc/7riYnalOeEKHgctWgxG9EpXV+4sTep6HGlgLpeZfK25bUIq4QCe/sTMw5B
 0uk1B3Wdo7zz5ADDYWmfp6OJ26QfLkcuou2MLqrVA/fgITFWNS3N6RSbmw9EcPbJmVBr
 mwZw==
X-Gm-Message-State: ALoCoQmMuXDrghdPnHxpFlBfbUd+JfdeKjTX1P35cmEQyOs2LNKi/yroTAsf1fSovQ2dW6QIbhhb
X-Received: by 10.181.8.198 with SMTP id dm6mr34442804wid.30.1402997133072;
 Tue, 17 Jun 2014 02:25:33 -0700 (PDT)
Received: from xps13.localnet (guy78-3-82-239-227-177.fbx.proxad.net.
 [82.239.227.177])
 by mx.google.com with ESMTPSA id na4sm19106789wic.21.2014.06.17.02.25.31
 for <multiple recipients>
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Tue, 17 Jun 2014 02:25:32 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
Date: Tue, 17 Jun 2014 11:25:31 +0200
Message-ID: <18221367.CmmvaOYvmf@xps13>
Organization: 6WIND
User-Agent: KMail/4.13.1 (Linux/3.14.6-1-ARCH; KDE/4.13.1; x86_64; ; )
In-Reply-To: <2601191342CEEE43887BDE71AB9772580EFB75F6@IRSMSX105.ger.corp.intel.com>
References: <1402666663-10260-1-git-send-email-david.marchand@6wind.com>
 <539FFF5A.80307@6wind.com>
 <2601191342CEEE43887BDE71AB9772580EFB75F6@IRSMSX105.ger.corp.intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2 0/7] add mtu and flow control handlers
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 17 Jun 2014 09:25:17 -0000

2014-06-17 08:57, Ananyev, Konstantin:
> >> 3)  if ((mtu < 68) || (frame_size > dev_info.max_rx_pktlen))
> >> Can we add a new define for min allowable MTU (68) as it used in few places.
> 
> >RTE_IPV4_MIN_MTU then ?
> 
> Sounds good to me.
> 
> >I am not sure where this belongs, it could go in rte_ethdev.h.
> 
> Probably rte_ether.h?

As you konw, rte_ether.h is for ethernet definition
(and should be located in librte_net).
For RTE_IPV4_MIN_MTU, I think librte_net/rte_ip.h is more appropriate.

-- 
Thomas