From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) by dpdk.org (Postfix) with ESMTP id 94B452C28 for ; Thu, 7 Mar 2019 09:59:46 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 568BC3570; Thu, 7 Mar 2019 03:59:45 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Thu, 07 Mar 2019 03:59:45 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=hpOiP9SCgwgTYNnxl5iTuLv3DagRzfJifsAeUApp2qg=; b=AXW8sFL2ss4c YoSeuhBi5EZj+/iodD9qNGURKneK7LhCMiVdOmWb2/Mjk6e59A42e2CECfVVWm5r DDe6E0D+rMm1c85G2YTaILUP94zpVJYSIHVVwj89jw7H5kEcPpjobug40Vy5VvMP 3BKxa8COBsHUgpm2bSbL6LpHD6WhVx0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=hpOiP9SCgwgTYNnxl5iTuLv3DagRzfJifsAeUApp2 qg=; b=fWJGiiCIq1INqDa+KXaZRh7V6JUpafxBidQmkpYFUGrwO6dBi2wRpr4m8 unw5XZfG1yG9FZ3gB48SHMHwti1JgDtPe0bYOQQKXL5pgSGY3w2XOZZxAAX6iEUs ToWy+T+tjRsBaRNtpxx+AfeQvJvLsq7TCACDPakblP0JZJqZsH/gjcp2sZ2G+SmY sKMEheCrEFH8wF0GO2GL0Pep+UgYSffdv4W1hYmwljUPd/uQFmac4bpc8BX6+Y+j LViaOYykp4kbyyhRbBKzBn6jZD2FNVUAfgwvJQ9RBGlWIA8iib1U+hRxX4uHX0df FiqpB5EHl5VidUld2KY11M7QuedUA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedutddrfeejgdduvdekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukf hppeejjedrudefgedrvddtfedrudekgeenucfrrghrrghmpehmrghilhhfrhhomhepthhh ohhmrghssehmohhnjhgrlhhonhdrnhgvthenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id AC586E4481; Thu, 7 Mar 2019 03:59:43 -0500 (EST) From: Thomas Monjalon To: Anand Rawat Cc: dev@dpdk.org, "Richardson, Bruce" , "Kadam, Pallavi" , "Menon, Ranjit" , "Shaw, Jeffrey B" Date: Thu, 07 Mar 2019 09:59:42 +0100 Message-ID: <1823219.Mqzco52y5N@xps> In-Reply-To: <56df497b-5854-6693-8577-87413b647e5a@intel.com> References: <20190306041634.12976-1-anand.rawat@intel.com> <59AF69C657FD0841A61C55336867B5B072749EA4@IRSMSX103.ger.corp.intel.com> <56df497b-5854-6693-8577-87413b647e5a@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2 1/6] eal: eal stub to add windows support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Mar 2019 08:59:47 -0000 07/03/2019 02:04, Anand Rawat: > On 3/6/2019 3:52 AM, Richardson, Bruce wrote: > > From: Thomas Monjalon [mailto:thomas@monjalon.net] > >> 06/03/2019 12:20, Bruce Richardson: > >>> On Wed, Mar 06, 2019 at 11:03:24AM +0100, Thomas Monjalon wrote: > >>>> 06/03/2019 05:16, Anand Rawat: > >>>>> +if host_machine.system() != 'windows' > >>>>> + common_sources = files( > >>>> > >>>> The definitive solution should be to compile all common EAL files. > >>>> Please explain what are the issues in the common files. > >>>> I think we should not remove them and fix them one by one. > >>>> You could provide a separate patch to skip some files for making > >>>> helloworld working. > >>>> > >>> > >>> I believe that is exactly what this patch is trying to do - it's > >>> skipping the files unneeded to get helloworld working, and the > >>> intention is to fix them one by one and add them back in later. > >>> Perhaps this sort of change should be a separate (precursor) patch > >>> where the cover letter can call this out explicitly? > >>> > >>>>> -deps += 'kvargs' > >>>>> +if host_machine.system() != 'windows' > >>>>> + deps += 'kvargs' > >>>>> +endif > >>>> > >>>> Why kvargs is removed? > >>> > >>> Again, I believe these actions are to disable the parts of DPDK that > >>> are not needed to enable helloworld, allowing later patches to come in > >>> and fix them. > >> > >> They are workarounds to build helloworld. > >> It is good to have progress in the draft tree, but I see no point in > >> merging this in master. > >> I think we should separate patches which are doing definitive changes from > >> temporary workaround patches disabling some files. > >> It is not an issue to merge some patches for Windows which are not > >> compiling. > > Bruce is right, we only compile required header and source files in > order to avoid compatibility errors on windows. Without these > change helloworld on windows would fail to compile. Adding windows > specific implementations of the common headers and sources would > bloat up individual patches as well the number of patches. kvargs is > removed as a dependency to have minimum viable product for helloworld. > If required for lcore mask, it'll added back in v3. Please make separate patches for workarounds. I am interested to push some patches which are really required in master, but the workarounds should stay in the Windows draft repository.