From: Thomas Monjalon <thomas@monjalon.net>
To: Harman Kalra <hkalra@marvell.com>
Cc: Jerin Jacob <jerinj@marvell.com>,
Nithin Dabilpuram <ndabilpuram@marvell.com>,
Kiran Kumar K <kirankumark@marvell.com>,
dev@dpdk.org, olivier.matz@6wind.com, david.marchand@redhat.com
Subject: Re: [dpdk-dev] [PATCH] net/octeontx2: register dynamic mbuf timestamp field
Date: Tue, 03 Nov 2020 15:26:17 +0100 [thread overview]
Message-ID: <18233106.h1nHT6NZqv@thomas> (raw)
In-Reply-To: <4848304.ISYM4h8o7B@thomas>
+Cc David and Olivier to make them laugh or cry.
03/11/2020 15:24, Thomas Monjalon:
> 03/11/2020 15:16, Harman Kalra:
> > A crash is observed if dynamic mbuf timestamp field is
> > registered in dev_start, as in most of the applications
> > rte_eth_timesync_enable is called after dev_start due
> > to which timestamp field did not get registered.
>
> So you are not reading your emails?
>
> I was waiting for you, so I looked at the ugly code of octeontx2
> with Olivier and David, and we fixed it already.
>
> Not reading emails is wasting time of everybody.
> On the contrary, being available on IRC can speed up work.
>
>
> > Signed-off-by: Harman Kalra <hkalra@marvell.com>
> > --- a/drivers/net/octeontx2/otx2_ethdev.c
> > +++ b/drivers/net/octeontx2/otx2_ethdev.c
> > @@ -2219,16 +2219,6 @@ otx2_nix_dev_start(struct rte_eth_dev *eth_dev)
> > else
> > otx2_nix_timesync_disable(eth_dev);
> >
> > - if (dev->rx_offload_flags & NIX_RX_OFFLOAD_TSTAMP_F) {
> > - rc = rte_mbuf_dyn_rx_timestamp_register(
> > - &dev->tstamp.tstamp_dynfield_offset,
> > - &dev->tstamp.rx_tstamp_dynflag);
> > - if (rc != 0) {
> > - otx2_err("Failed to register Rx timestamp field/flag");
> > - return -rte_errno;
> > - }
> > - }
> > -
>
> This is wrong, you still need to register for the case
> of DEV_RX_OFFLOAD_TIMESTAMP without timesync.
>
> In my v5, it is moved below after VF special config.
>
> > /* Update VF about data off shifted by 8 bytes if PTP already
> > * enabled in PF owning this VF
> > */
>
next prev parent reply other threads:[~2020-11-03 14:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-03 14:16 Harman Kalra
2020-11-03 14:24 ` Thomas Monjalon
2020-11-03 14:26 ` Thomas Monjalon [this message]
2020-11-03 14:48 ` [dpdk-dev] [EXT] " Harman Kalra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18233106.h1nHT6NZqv@thomas \
--to=thomas@monjalon.net \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=hkalra@marvell.com \
--cc=jerinj@marvell.com \
--cc=kirankumark@marvell.com \
--cc=ndabilpuram@marvell.com \
--cc=olivier.matz@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).