From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D3E55A0521; Tue, 3 Nov 2020 15:26:25 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id BAB95CADA; Tue, 3 Nov 2020 15:26:24 +0100 (CET) Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) by dpdk.org (Postfix) with ESMTP id 29433CAD9 for ; Tue, 3 Nov 2020 15:26:23 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.west.internal (Postfix) with ESMTP id E51D7D0F; Tue, 3 Nov 2020 09:26:20 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Tue, 03 Nov 2020 09:26:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= +9JCv2IUGgvR4VtLEss1dFTFqXTm7p/f1Y94jVMGeSs=; b=d1BYEG1O4QSmKYw0 6uKX1+vuZwmmByerH3o5dcaMlowL9UYhhjC5yCIlAlVC4uFUz9inkzDNVUSzXSIp fulYw3VEw4f7alQcshzaPoDN9n5enWQwYX8Lv3wwg6ZLV1D9JbuKqeg98HXlopBB 7Af8KkN/Cw/L/PmU1CzduP6y5F1cM+INjQHC5h+/CFAzBtsdcf1jn0gCZxiiEUdP v+GjteALOqveZtjJjvhzNyCa0Yi/eOmj7guL82mzyXDUiVZODPQf0AF2wBdGI5nq Wuj4px/9FUK7JpfSwEE0JO3VYaVqIXY8cRcdBzQCt9L8dg90LQA7Kv2svHsu2FoO oZsZWQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=+9JCv2IUGgvR4VtLEss1dFTFqXTm7p/f1Y94jVMGe Ss=; b=LPg2jEJWkSM5VkmvhVFDtuPDAajNaTlViWRJctTEhkrldvM3kM9J9fgy2 f3QlWr/9U4sOKItpfa1IoPCn81t+dIdsxV1T55z/BWRAWcchn++9AhgBN5fjCtPp b9RUUFWXXbvmOZI6HNethGfNRm766GygOoMJYNjc1DJBLpmTHhFer5I20CBRNJ3t GkCviyrLqXIPqFhYCDffd5ZkeX7QkwOkW1X3F5W/WxSkvKfMXxBzkevOVtlj1e1G LHiCpOkCNp4nvHDDN87qRqy3IUJO3JpIfn912fc7QpmqE9N7ewnJB/3v4nwW6D3a nKZ0+7u4YYhAOcu+1o7pjUvVfDf+Q== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedruddtfedgiedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id F38333064610; Tue, 3 Nov 2020 09:26:18 -0500 (EST) From: Thomas Monjalon To: Harman Kalra Cc: Jerin Jacob , Nithin Dabilpuram , Kiran Kumar K , dev@dpdk.org, olivier.matz@6wind.com, david.marchand@redhat.com Date: Tue, 03 Nov 2020 15:26:17 +0100 Message-ID: <18233106.h1nHT6NZqv@thomas> In-Reply-To: <4848304.ISYM4h8o7B@thomas> References: <20201103141640.174043-1-hkalra@marvell.com> <4848304.ISYM4h8o7B@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] net/octeontx2: register dynamic mbuf timestamp field X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" +Cc David and Olivier to make them laugh or cry. 03/11/2020 15:24, Thomas Monjalon: > 03/11/2020 15:16, Harman Kalra: > > A crash is observed if dynamic mbuf timestamp field is > > registered in dev_start, as in most of the applications > > rte_eth_timesync_enable is called after dev_start due > > to which timestamp field did not get registered. > > So you are not reading your emails? > > I was waiting for you, so I looked at the ugly code of octeontx2 > with Olivier and David, and we fixed it already. > > Not reading emails is wasting time of everybody. > On the contrary, being available on IRC can speed up work. > > > > Signed-off-by: Harman Kalra > > --- a/drivers/net/octeontx2/otx2_ethdev.c > > +++ b/drivers/net/octeontx2/otx2_ethdev.c > > @@ -2219,16 +2219,6 @@ otx2_nix_dev_start(struct rte_eth_dev *eth_dev) > > else > > otx2_nix_timesync_disable(eth_dev); > > > > - if (dev->rx_offload_flags & NIX_RX_OFFLOAD_TSTAMP_F) { > > - rc = rte_mbuf_dyn_rx_timestamp_register( > > - &dev->tstamp.tstamp_dynfield_offset, > > - &dev->tstamp.rx_tstamp_dynflag); > > - if (rc != 0) { > > - otx2_err("Failed to register Rx timestamp field/flag"); > > - return -rte_errno; > > - } > > - } > > - > > This is wrong, you still need to register for the case > of DEV_RX_OFFLOAD_TIMESTAMP without timesync. > > In my v5, it is moved below after VF special config. > > > /* Update VF about data off shifted by 8 bytes if PTP already > > * enabled in PF owning this VF > > */ >