From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 5FCF61B0F8 for ; Thu, 25 Oct 2018 22:49:33 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id ECF5A21F00; Thu, 25 Oct 2018 16:49:32 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Thu, 25 Oct 2018 16:49:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=Yue7opi3P8lcqcb9LM9iDT3mKviRvwY8GhkKDXL/TK8=; b=SQ9UiKeI/ZP6 O5kKTZk045waTlFaSku4WzXMTvIRVT113EtD83nut6qPR4G8HtqMeoF2WNTsFMtB Rg1g7XHLmkKuO75tNo35GVqQhz0t80/5Uc83WbdGpCjoleZzAgyTnkrDAhyCB9sS HnuQSzXcx0hpSVKrCQ3BAR56TLcDkns= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=Yue7opi3P8lcqcb9LM9iDT3mKviRvwY8GhkKDXL/T K8=; b=AQe8D+prDpdQDkhfdED/51hH7woN/GQ8clt34J4Ca6EUCTxNQFytl6vyh Ap07UOJbe+YGvSlyUnng+O/W4yQ07IAAoS8poR9E8L4ACiszaH/dQ7FiS47IfzB6 WLQZ+9BKTSTNIV9wInBYcunugLSIW57uztw8iRnroaekCbtzs6qomyTB+vKJlfok wgnXAsXYfXo5MoM7frejbpgOTy7Eb2obkP7f3jOJL8NdpstknWC6E3dpyj+DoN7q epA1gVFNaUWrX91zW73L7ZjnFVKzVb2OIRgk+rBjbrn8drKL/+7IecHt7UIKgXTO Kb/nTeMS9ePaHgXa9g9irncyGHtXw== X-ME-Sender: X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 8FEE6E455C; Thu, 25 Oct 2018 16:49:30 -0400 (EDT) From: Thomas Monjalon To: Bruce Richardson Cc: Kevin Laatz , dev@dpdk.org, harry.van.haaren@intel.com, stephen@networkplumber.org, gaetan.rivet@6wind.com, shreyansh.jain@nxp.com, mattias.ronnblom@ericsson.com, Ciara Power , Brian Archbold Date: Thu, 25 Oct 2018 22:49:33 +0200 Message-ID: <1823463.pdHNGopkkG@xps> In-Reply-To: <20181025204424.GA4552@bricha3-MOBL.ger.corp.intel.com> References: <20181024132725.5142-1-kevin.laatz@intel.com> <3330387.zQnsHCFWfj@xps> <20181025204424.GA4552@bricha3-MOBL.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v8 05/13] telemetry: add client feature and sockets X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Oct 2018 20:49:33 -0000 25/10/2018 22:44, Bruce Richardson: > On Thu, Oct 25, 2018 at 10:41:53PM +0200, Thomas Monjalon wrote: > > 25/10/2018 22:29, Thomas Monjalon: > > > 24/10/2018 18:03, Kevin Laatz: > > > > --- a/lib/librte_telemetry/meson.build > > > > +++ b/lib/librte_telemetry/meson.build > > > > @@ -5,3 +5,5 @@ sources = files('rte_telemetry.c') > > > > headers = files('rte_telemetry.h', 'rte_telemetry_internal.h') > > > > deps += ['metrics', 'ethdev'] > > > > cflags += '-DALLOW_EXPERIMENTAL_API' > > > > +jansson = cc.find_library('jansson', required: true) > > > > +ext_deps += jansson > > > > > > I just discovered an issue when trying to compile for arm64 > > > (with devtools/test-meson-builds.sh): > > > > > > /usr/lib/gcc/aarch64-linux-gnu/8.2.0/../../../../aarch64-linux-gnu/bin/ld: > > > cannot find -ljansson > > > > > > I am worried because it is a real blocker. > > > > The dependency must be optional. > > Should we disable the library if jansson is not found? > > > Yes, it should be. > > Needs: > > jansson = cc.find_library('jansson', required: false) > build = jansson.found() And for the makefile? It has been introduced (too early) in patch 3: LDLIBS += -ljansson I think we must use pkg-config to check if jansson is found.