From: Ferruh Yigit <ferruh.yigit@intel.com>
To: "Morten Brørup" <mb@smartsharesystems.com>,
"Stephen Hemminger" <stephen@networkplumber.org>,
jgrajcia@cisco.com, anatoly.burakov@intel.com
Cc: <dev@dpdk.org>
Subject: Re: [PATCH] net/memif: remove unnecessary rx_intr stub
Date: Wed, 26 Jan 2022 14:24:07 +0000 [thread overview]
Message-ID: <18250b66-2dc5-e6ea-4783-9edbdc747451@intel.com> (raw)
In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35D86E07@smartserver.smartshare.dk>
On 1/15/2022 8:15 AM, Morten Brørup wrote:
>> From: Stephen Hemminger [mailto:stephen@networkplumber.org]
>> Sent: Friday, 14 January 2022 21.47
>>
>> The code in memif driver to stub out rx_irq_enable is unnecessary
>> and causes different error returns than other drivers.
>> The core ethdev code will return -ENOTSUP if the driver has
>> a null rx_queue_intr_enable callback.
>>
>> Fixes: 09c7e63a71f9 ("net/memif: introduce memory interface PMD")
>> Cc: jgrajcia@cisco.com
>> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
>
> Acked-by: Morten Brørup <mb@smartsharesystems.com>
>
No comment from maintainers, hence progressing,
Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
Applied to dpdk-next-net/main, thanks.
prev parent reply other threads:[~2022-01-26 14:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-14 20:46 Stephen Hemminger
2022-01-15 8:15 ` Morten Brørup
2022-01-26 14:24 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18250b66-2dc5-e6ea-4783-9edbdc747451@intel.com \
--to=ferruh.yigit@intel.com \
--cc=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=jgrajcia@cisco.com \
--cc=mb@smartsharesystems.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).