[PATCH] net/memif: remove unnecessary rx_intr stub

[PATCH] net/memif: remove unnecessary rx_intr stub

[Stephen Hemminger]

The code in memif driver to stub out rx_irq_enable is unnecessary
and causes different error returns than other drivers.
The core ethdev code will return -ENOTSUP if the driver has
a null rx_queue_intr_enable callback.

Fixes: 09c7e63a71f9 ("net/memif: introduce memory interface PMD")
Cc: jgrajcia@cisco.com
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 drivers/net/memif/rte_eth_memif.c | 19 -------------------
 1 file changed, 19 deletions(-)

diff --git a/drivers/net/memif/rte_eth_memif.c b/drivers/net/memif/rte_eth_memif.c
index 59cb5a82a23f..d3459c5007c4 100644
--- a/drivers/net/memif/rte_eth_memif.c
+++ b/drivers/net/memif/rte_eth_memif.c
@@ -1500,23 +1500,6 @@ memif_stats_reset(struct rte_eth_dev *dev)
 	return 0;
 }
 
-static int
-memif_rx_queue_intr_enable(struct rte_eth_dev *dev __rte_unused,
-			   uint16_t qid __rte_unused)
-{
-	MIF_LOG(WARNING, "Interrupt mode not supported.");
-
-	return -1;
-}
-
-static int
-memif_rx_queue_intr_disable(struct rte_eth_dev *dev, uint16_t qid __rte_unused)
-{
-	struct pmd_internals *pmd __rte_unused = dev->data->dev_private;
-
-	return 0;
-}
-
 static const struct eth_dev_ops ops = {
 	.dev_start = memif_dev_start,
 	.dev_stop = memif_dev_stop,
@@ -1527,8 +1510,6 @@ static const struct eth_dev_ops ops = {
 	.rx_queue_setup = memif_rx_queue_setup,
 	.rx_queue_release = memif_rx_queue_release,
 	.tx_queue_release = memif_tx_queue_release,
-	.rx_queue_intr_enable = memif_rx_queue_intr_enable,
-	.rx_queue_intr_disable = memif_rx_queue_intr_disable,
 	.link_update = memif_link_update,
 	.stats_get = memif_stats_get,
 	.stats_reset = memif_stats_reset,
-- 
2.30.2

RE: [PATCH] net/memif: remove unnecessary rx_intr stub

[Morten Brørup]

> From: Stephen Hemminger [mailto:stephen@networkplumber.org]
> Sent: Friday, 14 January 2022 21.47
> 
> The code in memif driver to stub out rx_irq_enable is unnecessary
> and causes different error returns than other drivers.
> The core ethdev code will return -ENOTSUP if the driver has
> a null rx_queue_intr_enable callback.
> 
> Fixes: 09c7e63a71f9 ("net/memif: introduce memory interface PMD")
> Cc: jgrajcia@cisco.com
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
>  drivers/net/memif/rte_eth_memif.c | 19 -------------------
>  1 file changed, 19 deletions(-)
> 
> diff --git a/drivers/net/memif/rte_eth_memif.c
> b/drivers/net/memif/rte_eth_memif.c
> index 59cb5a82a23f..d3459c5007c4 100644
> --- a/drivers/net/memif/rte_eth_memif.c
> +++ b/drivers/net/memif/rte_eth_memif.c
> @@ -1500,23 +1500,6 @@ memif_stats_reset(struct rte_eth_dev *dev)
>  	return 0;
>  }
> 
> -static int
> -memif_rx_queue_intr_enable(struct rte_eth_dev *dev __rte_unused,
> -			   uint16_t qid __rte_unused)
> -{
> -	MIF_LOG(WARNING, "Interrupt mode not supported.");
> -
> -	return -1;
> -}
> -
> -static int
> -memif_rx_queue_intr_disable(struct rte_eth_dev *dev, uint16_t qid
> __rte_unused)
> -{
> -	struct pmd_internals *pmd __rte_unused = dev->data->dev_private;
> -
> -	return 0;
> -}
> -
>  static const struct eth_dev_ops ops = {
>  	.dev_start = memif_dev_start,
>  	.dev_stop = memif_dev_stop,
> @@ -1527,8 +1510,6 @@ static const struct eth_dev_ops ops = {
>  	.rx_queue_setup = memif_rx_queue_setup,
>  	.rx_queue_release = memif_rx_queue_release,
>  	.tx_queue_release = memif_tx_queue_release,
> -	.rx_queue_intr_enable = memif_rx_queue_intr_enable,
> -	.rx_queue_intr_disable = memif_rx_queue_intr_disable,
>  	.link_update = memif_link_update,
>  	.stats_get = memif_stats_get,
>  	.stats_reset = memif_stats_reset,
> --
> 2.30.2
> 

Acked-by: Morten Brørup <mb@smartsharesystems.com>

Re: [PATCH] net/memif: remove unnecessary rx_intr stub

[Ferruh Yigit]

On 1/15/2022 8:15 AM, Morten Brørup wrote:
>> From: Stephen Hemminger [mailto:stephen@networkplumber.org]
>> Sent: Friday, 14 January 2022 21.47
>>
>> The code in memif driver to stub out rx_irq_enable is unnecessary
>> and causes different error returns than other drivers.
>> The core ethdev code will return -ENOTSUP if the driver has
>> a null rx_queue_intr_enable callback.
>>
>> Fixes: 09c7e63a71f9 ("net/memif: introduce memory interface PMD")
>> Cc: jgrajcia@cisco.com
>> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> 
> Acked-by: Morten Brørup <mb@smartsharesystems.com>
> 

No comment from maintainers, hence progressing,

Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>

Applied to dpdk-next-net/main, thanks.